From 2504b228a2e395d20ac31196e5b28c52247cd503 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 20 Oct 2025 05:15:33 +0000 Subject: [PATCH 01/47] build(deps): bump super-linter/super-linter from 7.4.0 to 8.2.1 Bumps [super-linter/super-linter](https://github.com/super-linter/super-linter) from 7.4.0 to 8.2.1. - [Release notes](https://github.com/super-linter/super-linter/releases) - [Changelog](https://github.com/super-linter/super-linter/blob/main/CHANGELOG.md) - [Commits](https://github.com/super-linter/super-linter/compare/v7.4.0...v8.2.1) --- updated-dependencies: - dependency-name: super-linter/super-linter dependency-version: 8.2.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 02ca3cb..26261be 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -27,7 +27,7 @@ jobs: fetch-depth: 0 - name: Super-linter - uses: super-linter/super-linter/slim@v7.4.0 # x-release-please-version + uses: super-linter/super-linter/slim@v8.2.1 # x-release-please-version # TODO need to create problem matchers for each linter? https://github.com/rhysd/actionlint/blob/v1.7.7/docs/usage.md#problem-matchers env: # To report GitHub Actions status checks From faf22aafb1db5c51af6bbad32abc2be2ad1274a3 Mon Sep 17 00:00:00 2001 From: nocci Date: Mon, 29 Dec 2025 11:41:09 +0000 Subject: [PATCH 02/47] =?UTF-8?q?=F0=9F=90=9B=20fix(prime-gaming):=20updat?= =?UTF-8?q?e=20URL=20and=20selectors=20for=20claims?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - change URL_CLAIM to point to new Luna claims home - update selectors for sign-in and user verification - improve handling of cookies acceptance ✨ feat(prime-gaming): enhance game claiming logic - add support for new layout and game list detection - implement flexible scrolling for loading all game cards - refine logic for internal and external game claims - improve store identification for external claims ♻️ refactor(prime-gaming): modularize game tab and list location - extract functions for opening games tab and locating games list - enhance code readability and maintainability 🐛 fix(prime-gaming): handle dynamic selectors for availability dates - support multiple selectors for availability date detection - improve error handling and logging for missing elements --- prime-gaming.js | 156 ++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 125 insertions(+), 31 deletions(-) diff --git a/prime-gaming.js b/prime-gaming.js index dada15f..8e755b8 100644 --- a/prime-gaming.js +++ b/prime-gaming.js @@ -7,7 +7,7 @@ import { cfg } from './src/config.js'; const screenshot = (...a) => resolve(cfg.dir.screenshots, 'prime-gaming', ...a); // const URL_LOGIN = 'https://www.amazon.de/ap/signin'; // wrong. needs some session args to be valid? -const URL_CLAIM = 'https://gaming.amazon.com/home'; +const URL_CLAIM = 'https://luna.amazon.com/claims/home'; console.log(datetime(), 'started checking prime-gaming'); @@ -40,9 +40,14 @@ let user; try { await page.goto(URL_CLAIM, { waitUntil: 'domcontentloaded' }); // default 'load' takes forever // need to wait for some elements to exist before checking if signed in or accepting cookies: - await Promise.any(['button:has-text("Sign in")', '[data-a-target="user-dropdown-first-name-text"]'].map(s => page.waitForSelector(s))); + await Promise.any([ + 'button:has-text("Sign in")', + 'button:has-text("Anmelden")', + '[data-a-target="user-dropdown-first-name-text"]', + '[data-testid="user-dropdown-first-name-text"]', + ].map(s => page.waitForSelector(s))); page.click('[aria-label="Cookies usage disclaimer banner"] button:has-text("Accept Cookies")').catch(_ => { }); // to not waste screen space when non-headless, TODO does not work reliably, need to wait for something else first? - while (await page.locator('button:has-text("Sign in")').count() > 0) { + while (await page.locator('button:has-text("Sign in"), button:has-text("Anmelden")').count() > 0) { console.error('Not signed in anymore.'); await page.click('button:has-text("Sign in")'); if (!cfg.debug) context.setDefaultTimeout(cfg.login_timeout); // give user some extra time to log in @@ -85,7 +90,7 @@ try { await page.waitForURL('https://gaming.amazon.com/home?signedIn=true'); if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); } - user = await page.locator('[data-a-target="user-dropdown-first-name-text"]').first().innerText(); + user = await page.locator('[data-a-target="user-dropdown-first-name-text"], [data-testid="user-dropdown-first-name-text"]').first().innerText(); console.log(`Signed in as ${user}`); // await page.click('button[aria-label="User dropdown and more options"]'); // const twitch = await page.locator('[data-a-target="TwitchDisplayName"]').first().innerText(); @@ -119,15 +124,83 @@ try { await page.waitForTimeout(3000); }); - await page.click('button[data-type="Game"]'); - const games = page.locator('div[data-a-target="offer-list-FGWP_FULL"]'); - await games.waitFor(); - // await scrollUntilStable(() => games.locator('.item-card__action').count()); // number of games - await scrollUntilStable(() => page.evaluate(() => document.querySelector('.tw-full-width').scrollHeight)); // height may change during loading while number of games is still the same? - console.log('Number of already claimed games (total):', await games.locator('p:has-text("Collected")').count()); - // can't use .all() since the list of elements via locator will change after click while we iterate over it - const internal = await games.locator('.item-card__action:has(button[data-a-target="FGWPOffer"])').elementHandles(); - const external = await games.locator('.item-card__action:has(a[data-a-target="FGWPOffer"])').all(); + const openGamesTab = async () => { + const selectors = [ + 'button[data-type="Game"]', // old layout + 'button:has-text("Games")', + '[data-test-selector="category-picker"] button:has-text("Games")', + '[data-testid="category-picker"] button:has-text("Games")', + ]; + for (const sel of selectors) { + const btn = page.locator(sel).first(); + if (await btn.count()) { + await btn.click(); + return; + } + } + // New Luna claims home already shows games list + }; + + await openGamesTab(); + + const locateGamesList = async () => { + const selectors = [ + 'div[data-a-target="offer-list-FGWP_FULL"]', // old layout + '[data-testid="offer-list"]', + '[data-test-selector="offer-list"]', + 'section:has(h2:has-text("Games with Prime"))', + 'section:has(h2:has-text("Games"))', + ]; + for (const sel of selectors) { + const loc = page.locator(sel).first(); + if (await loc.count()) return loc; + } + return null; + }; + + const games = await locateGamesList(); + // Load all cards (old and new layout) by scrolling the container or the page + if (games) await scrollUntilStable(() => games.evaluate(el => el.scrollHeight).catch(() => 0)); + await scrollUntilStable(() => page.evaluate(() => document.scrollingElement?.scrollHeight ?? 0)); + + const cards = []; + const anchorClaims = page.locator('a[href*="/claims/"][href*="amzn1.pg.item"]'); + if (await anchorClaims.count()) { + const hrefs = [...new Set(await anchorClaims.evaluateAll(anchors => anchors.map(a => a.getAttribute('href')).filter(Boolean)))]; + for (const href of hrefs) { + let url = href; + if (url.startsWith('/')) url = 'https://luna.amazon.com' + url; + const title = url.split('/claims/')[1]?.split('/')[0] || (await anchorClaims.first().innerText()) || 'Unknown title'; + cards.push({ kind: 'external', title, url }); + } + } + + if (!cards.length && games) { + const cardLocator = games.locator([ + '[data-testid="offer-card"]', + '[data-test-selector="offer-card"]', + '.item-card__action', + ].join(',')); + if (await cardLocator.count() === 0) { + console.log('No games found in list.'); + } else { + for (const handle of await cardLocator.elementHandles()) { + const text = (await handle.textContent() || '').toLowerCase(); + if (text.includes('collected')) continue; // skip already claimed + const title = await (await handle.$('h3, h4, [data-testid="item-card-title"], [data-test-selector="item-card-title"], .item-card-details__body__primary'))?.innerText() || 'Unknown title'; + const linkEl = await handle.$('a[href]'); + let url = linkEl && await linkEl.getAttribute('href'); + if (url?.startsWith('/')) url = 'https://gaming.amazon.com' + url; + const hasLinkClaim = await handle.$('a:has-text("Claim"), a:has-text("Get"), a:has-text("Details")'); + const hasButtonClaim = await handle.$('button:has-text("Claim"), button:has-text("Get"), button:has-text("Get game"), button:has-text("Play")'); + if (hasLinkClaim) cards.push({ kind: 'external', title, url }); + else if (hasButtonClaim) cards.push({ kind: 'internal', title, url, handle }); + } + } + } + + const internal = cards.filter(c => c.kind == 'internal'); + const external = cards.filter(c => c.kind == 'external'); // bottom to top: oldest to newest games internal.reverse(); external.reverse(); @@ -143,39 +216,41 @@ try { const skipBasedOnTime = async url => { // console.log(' Checking time left for game:', url); const [p, isNew] = await sameOrNewPage(url); - const dueDateOrg = await p.locator('.availability-date .tw-bold').innerText(); + const dueDateLoc = p.locator('.availability-date .tw-bold, [data-testid="availability-end-date"], [data-test-selector="availability-end-date"]'); + if (!await dueDateLoc.count()) { + if (isNew) await p.close(); + return false; + } + const dueDateOrg = await dueDateLoc.first().innerText(); const dueDate = new Date(Date.parse(dueDateOrg + ' 17:00')); const daysLeft = (dueDate.getTime() - Date.now())/1000/60/60/24; - console.log(' ', await p.locator('.availability-date').innerText(), '->', daysLeft.toFixed(2)); + const availabilityText = await p.locator('.availability-date, [data-testid="availability-end-date"], [data-test-selector="availability-end-date"]').first().innerText().catch(() => dueDateOrg); + console.log(' ', availabilityText, '->', daysLeft.toFixed(2)); if (isNew) await p.close(); return daysLeft > cfg.pg_timeLeft; } console.log('\nNumber of free unclaimed games (Prime Gaming):', internal.length); // claim games in internal store for (const card of internal) { - await card.scrollIntoViewIfNeeded(); - const title = await (await card.$('.item-card-details__body__primary')).innerText(); - const slug = await (await card.$('a')).getAttribute('href'); - const url = 'https://gaming.amazon.com' + slug.split('?')[0]; + await card.handle.scrollIntoViewIfNeeded(); + const title = card.title; + const url = card.url; console.log('Current free game:', chalk.blue(title)); - if (cfg.pg_timeLeft && await skipBasedOnTime(url)) continue; + if (cfg.pg_timeLeft && url && await skipBasedOnTime(url)) continue; if (cfg.dryrun) continue; if (cfg.interactive && !await confirm()) continue; - await (await card.$('.tw-button:has-text("Claim")')).click(); + await card.handle.locator('.tw-button:has-text("Claim"), .tw-button:has-text("Get"), button:has-text("Claim"), button:has-text("Get")').first().click(); db.data[user][title] ||= { title, time: datetime(), url, store: 'internal' }; notify_games.push({ title, status: 'claimed', url }); - // const img = await (await card.$('img.tw-image')).getAttribute('src'); - // console.log('Image:', img); - await card.screenshot({ path: screenshot('internal', `${filenamify(title)}.png`) }); + await card.handle.screenshot({ path: screenshot('internal', `${filenamify(title)}.png`) }); } console.log('\nNumber of free unclaimed games (external stores):', external.length); // claim games in external/linked stores. Linked: origin.com, epicgames.com; Redeem-key: gog.com, legacygames.com, microsoft const external_info = []; for (const card of external) { // need to get data incl. URLs in this loop and then navigate in another, otherwise .all() would update after coming back and .elementHandles() like above would lead to error due to page navigation: elementHandle.$: Protocol error (Page.adoptNode) - const title = await card.locator('.item-card-details__body__primary').innerText(); - const slug = await card.locator('a:has-text("Claim")').first().getAttribute('href'); - const url = 'https://gaming.amazon.com' + slug.split('?')[0]; - // await (await card.$('text=Claim')).click(); // goes to URL of game, no need to wait + const title = card.title; + const url = card.url ? card.url.split('?')[0] : undefined; + if (!url) continue; external_info.push({ title, url }); } // external_info = [ { title: 'Fallout 76 (XBOX)', url: 'https://gaming.amazon.com/fallout-76-xbox-fgwp/dp/amzn1.pg.item.9fe17d7b-b6c2-4f58-b494-cc4e79528d0b?ingress=amzn&ref_=SM_Fallout76XBOX_S01_FGWP_CRWN' } ]; @@ -183,13 +258,32 @@ try { console.log('Current free game:', chalk.blue(title)); // , url); await page.goto(url, { waitUntil: 'domcontentloaded' }); if (cfg.debug) await page.pause(); - const item_text = await page.innerText('[data-a-target="DescriptionItemDetails"]'); - const store = item_text.toLowerCase().replace(/.* on /, '').slice(0, -1); + let store = 'unknown'; + const detailLoc = page.locator('[data-a-target="DescriptionItemDetails"], [data-testid="DescriptionItemDetails"]'); + if (await detailLoc.count()) { + const item_text = await detailLoc.first().innerText(); + store = item_text.toLowerCase().replace(/.* on /, '').slice(0, -1); + } else if (url.includes('/claims/')) { + const slug = url.split('/claims/')[1]?.split('/')[0] || ''; + if (slug.includes('gog')) store = 'gog.com'; + else if (slug.includes('epic')) store = 'epic-games'; + else if (slug.includes('origin')) store = 'origin'; + else if (slug.includes('xbox') || slug.includes('microsoft')) store = 'microsoft store'; + else if (slug.includes('legacy')) store = 'legacy games'; + } console.log(' External store:', store); if (cfg.pg_timeLeft && await skipBasedOnTime(url)) continue; if (cfg.dryrun) continue; if (cfg.interactive && !await confirm()) continue; - await Promise.any([page.click('[data-a-target="buy-box"] .tw-button:has-text("Get game")'), page.click('[data-a-target="buy-box"] .tw-button:has-text("Claim")'), page.click('.tw-button:has-text("Complete Claim")'), page.waitForSelector('div:has-text("Link game account")'), page.waitForSelector('.thank-you-title:has-text("Success")')]); // waits for navigation + await Promise.any([ + page.click('[data-a-target="buy-box"] .tw-button:has-text("Get game")'), + page.click('[data-a-target="buy-box"] .tw-button:has-text("Claim")'), + page.click('.tw-button:has-text("Complete Claim")'), + page.click('[data-a-target="buy-box_call-to-action-text"]'), + page.click('p[data-a-target="buy-box_call-to-action-text"]'), + page.waitForSelector('div:has-text("Link game account")'), + page.waitForSelector('.thank-you-title:has-text("Success")'), + ]); // waits for navigation db.data[user][title] ||= { title, time: datetime(), url, store }; const notify_game = { title, url }; notify_games.push(notify_game); // status is updated below From 76f578e2e6edd24d1ea374ab9736ec92c598a475 Mon Sep 17 00:00:00 2001 From: nocci Date: Mon, 29 Dec 2025 14:15:22 +0000 Subject: [PATCH 03/47] =?UTF-8?q?=E2=9C=A8=20feat(auth):=20enhance=20autom?= =?UTF-8?q?atic=20login=20and=20MFA=20handling?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - add handleMFA function for improved two-step verification - implement direct login page handling with automatic sign-in 🐛 fix(claim): improve game claim process and duplicate prevention - normalize claim URLs and deduplicate by URL - fix various selectors for claim buttons and handle different languages - prevent duplicate game claims by checking existing records ♻️ refactor(utils): improve code readability and maintainability - extract normalizeClaimUrl function for URL handling - restructure logic for claim and notification processes 🌐 i18n(claim): add support for game claim text in German - handle German text for claim buttons and status checks --- prime-gaming.js | 230 +++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 199 insertions(+), 31 deletions(-) diff --git a/prime-gaming.js b/prime-gaming.js index 8e755b8..dc39bba 100644 --- a/prime-gaming.js +++ b/prime-gaming.js @@ -37,8 +37,53 @@ await page.setViewportSize({ width: cfg.width, height: cfg.height }); // TODO wo const notify_games = []; let user; +const handleMFA = async p => { + const otpField = p.locator('#auth-mfa-otpcode, input[name=otpCode]'); + if (!await otpField.count()) return false; + console.log('Two-Step Verification - enter the One Time Password (OTP), e.g. generated by your Authenticator App'); + await p.locator('#auth-mfa-remember-device, [name=rememberDevice]').check().catch(_ => {}); + const otp = cfg.pg_otpkey && authenticator.generate(cfg.pg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them + await otpField.first().pressSequentially(otp.toString()); + await p.locator('input[type="submit"], button[type="submit"]').first().click(); + return true; +}; + try { await page.goto(URL_CLAIM, { waitUntil: 'domcontentloaded' }); // default 'load' takes forever + const handleDirectLoginPage = async () => { + if (!page.url().includes('/ap/signin')) return false; + console.log('On Amazon login page (redirect). Trying to sign in automatically.'); + if (!cfg.debug) context.setDefaultTimeout(cfg.login_timeout); + const email = cfg.pg_email || await prompt({ message: 'Enter email' }); + const password = email && (cfg.pg_password || await prompt({ type: 'password', message: 'Enter password' })); + if (email && password) { + await page.fill('[name=email]', email); + await page.click('input[type="submit"]'); + await page.fill('[name=password]', password); + await page.click('input[type="submit"]'); + await handleMFA(page).catch(_ => {}); + page.waitForURL('**/ap/signin**').then(async () => { // check for wrong credentials + const error = await page.locator('.a-alert-content').first().innerText(); + if (!error.trim.length) return; + console.error('Login error:', error); + await notify(`prime-gaming: login: ${error}`); + await context.close(); // finishes potential recording + process.exit(1); + }); + await page.waitForURL(/luna\.amazon\.com\/claims\/.*signedIn=true/); + if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); + return true; + } else { + console.log('Waiting for manual login on redirect page.'); + if (cfg.headless) { + console.log('Run `SHOW=1 node prime-gaming` to login in the opened browser.'); + await context.close(); // finishes potential recording + process.exit(1); + } + return true; + } + }; + await handleDirectLoginPage(); // need to wait for some elements to exist before checking if signed in or accepting cookies: await Promise.any([ 'button:has-text("Sign in")', @@ -70,14 +115,7 @@ try { await context.close(); // finishes potential recording process.exit(1); }); - // handle MFA, but don't await it - page.waitForURL('**/ap/mfa**').then(async () => { - console.log('Two-Step Verification - enter the One Time Password (OTP), e.g. generated by your Authenticator App'); - await page.check('[name=rememberDevice]'); - const otp = cfg.pg_otpkey && authenticator.generate(cfg.pg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them - await page.locator('input[name=otpCode]').pressSequentially(otp.toString()); - await page.click('input[type="submit"]'); - }).catch(_ => { }); + handleMFA(page).catch(_ => {}); } else { console.log('Waiting for you to login in the browser.'); await notify('prime-gaming: no longer signed in and not enough options set for automatic login.'); @@ -128,6 +166,7 @@ try { const selectors = [ 'button[data-type="Game"]', // old layout 'button:has-text("Games")', + 'button:has-text("Games einlösen")', '[data-test-selector="category-picker"] button:has-text("Games")', '[data-testid="category-picker"] button:has-text("Games")', ]; @@ -138,6 +177,15 @@ try { return; } } + // New Luna claims home: try the filter/CTA button with embedded

+ const gamesTitle = page.locator('p.offer-filters__button__title:has-text("Games"), p.offer-filters__button__title:has-text("einlösen")'); + if (await gamesTitle.count()) { + const btn = gamesTitle.first().locator('xpath=ancestor::button[1]'); + if (await btn.count()) { + await btn.click(); + return; + } + } // New Luna claims home already shows games list }; @@ -163,15 +211,38 @@ try { if (games) await scrollUntilStable(() => games.evaluate(el => el.scrollHeight).catch(() => 0)); await scrollUntilStable(() => page.evaluate(() => document.scrollingElement?.scrollHeight ?? 0)); + const normalizeClaimUrl = url => { + if (!url) return { url, key: null }; + const m = url.match(/(https?:\/\/[^/]+)?(\/claims\/[^?#]+)/); + if (!m) return { url, key: url }; + const path = m[2]; + const slug = path.split('/')[2]; + return { url: 'https://luna.amazon.com' + path, key: slug || path }; + }; + const cards = []; + // New layout: direct claim buttons on cards (FGWPOffer) with "Spiel aktivieren"/"Claim" + const fgwps = page.locator('[data-a-target="FGWPOffer"]'); + if (await fgwps.count()) { + for (const handle of await fgwps.elementHandles()) { + const href = await handle.getAttribute('href'); + const { url, key } = normalizeClaimUrl(href?.startsWith('/') ? href : href || ''); + const title = + await handle.$eval('p[title], span[title]', el => el.getAttribute('title')).catch(() => null) || + await handle.$eval('p, span', el => el.textContent).catch(() => null) || + key || + 'Unknown title'; + cards.push({ kind: 'external', title, url, key }); + } + } + const anchorClaims = page.locator('a[href*="/claims/"][href*="amzn1.pg.item"]'); if (await anchorClaims.count()) { const hrefs = [...new Set(await anchorClaims.evaluateAll(anchors => anchors.map(a => a.getAttribute('href')).filter(Boolean)))]; for (const href of hrefs) { - let url = href; - if (url.startsWith('/')) url = 'https://luna.amazon.com' + url; - const title = url.split('/claims/')[1]?.split('/')[0] || (await anchorClaims.first().innerText()) || 'Unknown title'; - cards.push({ kind: 'external', title, url }); + const { url, key } = normalizeClaimUrl(href); + const title = key || (await anchorClaims.first().innerText()) || 'Unknown title'; + cards.push({ kind: 'external', title, url, key }); } } @@ -190,17 +261,28 @@ try { const title = await (await handle.$('h3, h4, [data-testid="item-card-title"], [data-test-selector="item-card-title"], .item-card-details__body__primary'))?.innerText() || 'Unknown title'; const linkEl = await handle.$('a[href]'); let url = linkEl && await linkEl.getAttribute('href'); - if (url?.startsWith('/')) url = 'https://gaming.amazon.com' + url; + if (url?.startsWith('/')) url = 'https://luna.amazon.com' + url; + const { url: normUrl, key } = normalizeClaimUrl(url); const hasLinkClaim = await handle.$('a:has-text("Claim"), a:has-text("Get"), a:has-text("Details")'); const hasButtonClaim = await handle.$('button:has-text("Claim"), button:has-text("Get"), button:has-text("Get game"), button:has-text("Play")'); - if (hasLinkClaim) cards.push({ kind: 'external', title, url }); - else if (hasButtonClaim) cards.push({ kind: 'internal', title, url, handle }); + const hasGermanCTA = await handle.$(':is(button,p,a):has-text("Spiel aktivieren"), :is(button,p,a):has-text("Spiel holen")'); + if (hasLinkClaim || hasGermanCTA) cards.push({ kind: 'external', title, url: normUrl, key }); + else if (hasButtonClaim) cards.push({ kind: 'internal', title, url: normUrl, key, handle }); } } } - const internal = cards.filter(c => c.kind == 'internal'); - const external = cards.filter(c => c.kind == 'external'); + // dedup by URL to avoid duplicates from multiple selectors + const seenUrl = new Set(); + const uniq = cards.filter(c => { + const key = c.key || c.url || c.title; + if (seenUrl.has(key)) return false; + seenUrl.add(key); + return true; + }); + + const internal = uniq.filter(c => c.kind == 'internal'); + const external = uniq.filter(c => c.kind == 'external'); // bottom to top: oldest to newest games internal.reverse(); external.reverse(); @@ -254,9 +336,46 @@ try { external_info.push({ title, url }); } // external_info = [ { title: 'Fallout 76 (XBOX)', url: 'https://gaming.amazon.com/fallout-76-xbox-fgwp/dp/amzn1.pg.item.9fe17d7b-b6c2-4f58-b494-cc4e79528d0b?ingress=amzn&ref_=SM_Fallout76XBOX_S01_FGWP_CRWN' } ]; + + const clickCTA = async p => { + const candidates = [ + p.locator('button[data-a-target="buy-box_call-to-action"]').first(), + p.locator('[data-a-target="buy-box_call-to-action"]').first(), + p.locator('[data-a-target="buy-box"] .tw-button:has-text("Get game")').first(), + p.locator('[data-a-target="buy-box"] .tw-button:has-text("Claim")').first(), + p.locator('.tw-button:has-text("Complete Claim")').first(), + p.locator('[data-a-target="buy-box_call-to-action-text"]').first().locator('xpath=ancestor::button[1]'), + p.locator('.tw-button:has-text("Spiel holen"), .tw-button:has-text("Spiel aktivieren")').first(), + p.locator('p:has-text("Spiel holen"), p:has-text("Spiel aktivieren")').first().locator('xpath=ancestor::button[1]'), + ]; + for (const c of candidates) { + if (await c.count()) { + try { + await c.waitFor({ state: 'visible', timeout: 5000 }); + if (!await c.isEnabled()) { + await c.evaluate(el => { el.disabled = false; el.removeAttribute('disabled'); el.click(); }); + } else { + await c.click(); + } + return true; + } catch (_) { + // try next candidate + } + } + } + return false; + }; + for (const { title, url } of external_info) { console.log('Current free game:', chalk.blue(title)); // , url); + const existing = db.data[user]?.[title]; + if (existing && existing.status && !existing.status.startsWith('failed')) { + console.log(` Already recorded as ${existing.status}, skipping.`); + notify_games.push({ title, url, status: 'existed' }); + continue; + } await page.goto(url, { waitUntil: 'domcontentloaded' }); + await page.waitForSelector('[data-a-target="buy-box"]', { timeout: 10000 }).catch(_ => {}); if (cfg.debug) await page.pause(); let store = 'unknown'; const detailLoc = page.locator('[data-a-target="DescriptionItemDetails"], [data-testid="DescriptionItemDetails"]'); @@ -270,23 +389,59 @@ try { else if (slug.includes('origin')) store = 'origin'; else if (slug.includes('xbox') || slug.includes('microsoft')) store = 'microsoft store'; else if (slug.includes('legacy')) store = 'legacy games'; + const lunaPlay = await page.locator('[data-a-target="LunaOffer"], button[data-a-target="LunaOffer"], button:has-text("Spielen")').count(); + if (store == 'unknown' && lunaPlay) store = 'luna'; } console.log(' External store:', store); + const notify_game = { title, url }; + notify_games.push(notify_game); // status is updated below + // Already collected? skip + const collectedLoc = page.locator('[data-a-target="ClaimStateQuantityAndDateContent"], [data-a-target="ClaimStateClaimCodeContent"]:has-text("Collected"), [data-a-target="ClaimStateVendorContent"], [data-a-target="ClaimStateViewDetailsAndInstructions"]'); + const collectedText = page.getByText(/You collected this on/i); + const collectedEpic = page.getByText(/Sent to your Epic Games Store library/i); + const collectedBanner = page.locator('p.tw-c-text-alert-success:has-text("Collected"), p.tw-c-text-alert-success:has-text("Collected this")'); + const collectedSuccessIcon = page.locator('[data-a-target="ItemCardDetailSuccessStatus"], .claim-state__success-icon'); + const disabledCTA = page.locator('[data-a-target="buy-box_call-to-action"][disabled], button[disabled]:has-text("Get game")'); + const collectedAny = await Promise.all([ + collectedLoc.count(), + collectedBanner.count(), + collectedText.count(), + collectedEpic.count(), + collectedSuccessIcon.count(), + disabledCTA.count(), + ]).then(([a, b, c, d, e, f]) => a + b + c + d + e + f > 0); + if (collectedAny) { + console.log(' Already collected, skipping.'); + notify_game.status = 'existed'; + db.data[user][title] ||= { title, time: datetime(), url, store, status: 'existed' }; + continue; + } + // Disabled CTA (e.g., needs linking or not available) + if (await disabledCTA.count()) { + if (store !== 'epic-games') { + console.log(' CTA is disabled, skipping (likely needs linking/not available).'); + notify_game.status = 'disabled'; + db.data[user][title] ||= { title, time: datetime(), url, store, status: 'disabled' }; + continue; + } else { + console.log(' CTA disabled for epic-games, will still try to link/claim.'); + } + } + if (store == 'luna') { + console.log(' Luna cloud title detected, skipping code redemption.'); + notify_game.status = 'luna (play)'; + db.data[user][title] ||= { title, time: datetime(), url, store: 'luna', status: 'luna (play)' }; + continue; + } if (cfg.pg_timeLeft && await skipBasedOnTime(url)) continue; if (cfg.dryrun) continue; if (cfg.interactive && !await confirm()) continue; + await clickCTA(page); await Promise.any([ - page.click('[data-a-target="buy-box"] .tw-button:has-text("Get game")'), - page.click('[data-a-target="buy-box"] .tw-button:has-text("Claim")'), - page.click('.tw-button:has-text("Complete Claim")'), - page.click('[data-a-target="buy-box_call-to-action-text"]'), - page.click('p[data-a-target="buy-box_call-to-action-text"]'), - page.waitForSelector('div:has-text("Link game account")'), - page.waitForSelector('.thank-you-title:has-text("Success")'), - ]); // waits for navigation + page.waitForSelector('.thank-you-title:has-text("Success")', { timeout: cfg.timeout }).catch(_ => {}), + page.waitForSelector('div:has-text("Link game account")', { timeout: cfg.timeout }).catch(_ => {}), + ]).catch(_ => {}); db.data[user][title] ||= { title, time: datetime(), url, store }; - const notify_game = { title, url }; - notify_games.push(notify_game); // status is updated below if (await page.locator('div:has-text("Link game account")').count() // TODO still needed? epic games store just has 'Link account' as the button text now. || await page.locator('div:has-text("Link account")').count()) { console.error(' Account linking is required to claim this offer!'); @@ -308,7 +463,21 @@ try { 'legacy games': 'https://www.legacygames.com/primedeal', }; if (store in redeem) { // did not work for linked origin: && !await page.locator('div:has-text("Successfully Claimed")').count() - const code = await Promise.any([page.inputValue('input[type="text"]'), page.textContent('[data-a-target="ClaimStateClaimCodeContent"]').then(s => s.replace('Your code: ', ''))]); // input: Legacy Games; text: gog.com + let code; + try { + // ensure CTA was clicked in case code is behind it + await clickCTA(page).catch(_ => {}); + code = await Promise.any([ + page.inputValue('input[type="text"]'), + page.textContent('[data-a-target="ClaimStateClaimCodeContent"]').then(s => s.replace('Your code: ', '')), + ]); + } catch (_) { + console.error(' Could not find claim code on page (timeout). Please check manually.'); + db.data[user][title].status = 'claimed (code not found)'; + notify_game.status = 'claimed (code not found)'; + await page.screenshot({ path: screenshot('external', `${filenamify(title)}_nocode.png`), fullPage: true }).catch(_ => {}); + continue; + } console.log(' Code to redeem game:', chalk.blue(code)); if (store == 'legacy games') { // may be different URL like https://legacygames.com/primeday/puzzleoftheyear/ redeem[store] = await (await page.$('li:has-text("Click here") a')).getAttribute('href'); // full text: Click here to enter your redemption code. @@ -441,11 +610,10 @@ try { // await page.pause(); } await page.goto(URL_CLAIM, { waitUntil: 'domcontentloaded' }); - await page.click('button[data-type="Game"]'); + page.click('button[data-type="Game"]').catch(_ => {}); - if (notify_games.length) { // make screenshot of all games if something was claimed + if (notify_games.length && games) { // make screenshot of all games if something was claimed and list exists const p = screenshot(`${filenamify(datetime())}.png`); - // await page.screenshot({ path: p, fullPage: true }); // fullPage does not make a difference since scroll not on body but on some element await scrollUntilStable(() => games.locator('.item-card__action').count()); const viewportSize = page.viewportSize(); // current viewport size await page.setViewportSize({ ...viewportSize, height: 3000 }); // increase height, otherwise element screenshot is cut off at the top and bottom From a21dced86ec47540efc722cb43ce900343509bc7 Mon Sep 17 00:00:00 2001 From: nocci Date: Mon, 29 Dec 2025 14:31:25 +0000 Subject: [PATCH 04/47] =?UTF-8?q?=F0=9F=93=A6=20build(ci):=20add=20build-a?= =?UTF-8?q?nd-push=20workflow=20for=20docker=20images?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - create a new CI workflow to automate image building and pushing - trigger workflow on push to main branch - include steps for checkout, login, build, and push docker images --- .forgejo/workflows/build.yml | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 .forgejo/workflows/build.yml diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml new file mode 100644 index 0000000..97fa8a0 --- /dev/null +++ b/.forgejo/workflows/build.yml @@ -0,0 +1,26 @@ +name: build-and-push + +on: + push: + branches: + - main + +jobs: + docker: + runs-on: self-hosted + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Login to registry + run: echo "${{ secrets.REG_TOKEN }}" | docker login "${{ secrets.REGISTRY }}" -u "${{ secrets.REG_USER }}" --password-stdin + + - name: Build image + run: | + docker build -t "${{ secrets.REGISTRY_IMAGE }}:${{ github.sha }}" \ + -t "${{ secrets.REGISTRY_IMAGE }}:latest" . + + - name: Push image + run: | + docker push "${{ secrets.REGISTRY_IMAGE }}:${{ github.sha }}" + docker push "${{ secrets.REGISTRY_IMAGE }}:latest" From 6f778d71ac751dec0f079739141a48c4d11ebf1d Mon Sep 17 00:00:00 2001 From: nocci Date: Mon, 29 Dec 2025 14:33:14 +0000 Subject: [PATCH 05/47] =?UTF-8?q?=F0=9F=93=9D=20docs(README):=20add=20inst?= =?UTF-8?q?ructions=20for=20building=20images=20in=20Forgejo?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - include steps for building and pushing Docker images using Forgejo - provide details on setting Forgejo secrets and using self-hosted runners --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index 17ec854..5e0ab4d 100644 --- a/README.md +++ b/README.md @@ -31,6 +31,14 @@ _This currently gives you a captcha challenge for epic-games. Until [issue #183] This will run `node epic-games; node prime-gaming; node gog` - if you only want to claim games for one of the stores, you can override the default command by appending e.g. `node epic-games` at the end of the `docker run` command, or if you want several `bash -c "node epic-games.js; node gog.js"`. Data (including json files with claimed games, codes to redeem, screenshots) is stored in the Docker volume `fgc`. +### Eigene Images aus Forgejo bauen +Falls du den Fork in einer selbst gehosteten Forgejo-Instanz pflegst: + +- Der Workflow `.forgejo/workflows/build.yml` baut/pusht das Docker-Image auf `push` nach `main`. +- Setze in Forgejo die Secrets `REGISTRY`, `REGISTRY_IMAGE`, `REG_USER`, `REG_TOKEN` (PAT mit Paket-Push). +- Self-hosted Runner mit Docker muss registriert sein (`runs-on: self-hosted`). +- Danach kannst du das Image ziehen, z.B.: `docker pull $REGISTRY_IMAGE:latest`. +

I want to run without Docker or develop locally. From bde0f34a80e8f59dce8b6b8e74b5e5286fda3320 Mon Sep 17 00:00:00 2001 From: nocci Date: Mon, 29 Dec 2025 14:36:18 +0000 Subject: [PATCH 06/47] =?UTF-8?q?=F0=9F=93=9D=20docs(README):=20simplify?= =?UTF-8?q?=20and=20update=20documentation?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - remove detailed setup instructions and history - add quick-start guide for Docker and Docker Compose - update CI and configuration sections - streamline language and formatting for clarity --- README.md | 300 +++++++++++++++--------------------------------------- 1 file changed, 80 insertions(+), 220 deletions(-) diff --git a/README.md b/README.md index 5e0ab4d..be82e97 100644 --- a/README.md +++ b/README.md @@ -1,232 +1,92 @@ -

-logo-free-games-claimer -

+Free Games Claimer (Fork) +========================== -[![Code Smells](https://sonarcloud.io/api/project_badges/measure?project=vogler_free-games-claimer&metric=code_smells)](https://sonarcloud.io/project/overview?id=vogler_free-games-claimer) -# free-games-claimer +Automates claiming of free games for: +- Epic Games Store (and Epic-linked assets) +- Amazon Prime Gaming / Luna claims (incl. external stores like GOG, Legacy, Microsoft) +- GOG giveaways +- Optional extras: Steam stats, AliExpress dailies (experimental) -Claims free games periodically on -- [Epic Games Store](https://www.epicgames.com/store/free-games) -- [Amazon Prime Gaming](https://gaming.amazon.com) -- [GOG](https://www.gog.com) -- [Unreal Engine (Assets)](https://www.unrealengine.com/marketplace/en-US/assets?count=20&sortBy=effectiveDate&sortDir=DESC&start=0&tag=4910) ([experimental](https://github.com/vogler/free-games-claimer/issues/44), same login as Epic Games) - +This fork adds a Forgejo CI pipeline and instructions for running the pre-built image from your own registry. -Pull requests welcome :) +Requirements +------------ +- Docker or Podman (empfohlen) **oder** Node.js ≥ 20 zum lokalen Lauf +- (Optional) Python `apprise` für Benachrichtigungen: `pip install apprise` +- Für Playwright: Linux-Desktop-Abhängigkeiten sind im Container enthalten; lokal ggf. `npm install` zieht Firefox mit. -![Telegram Screenshot](https://user-images.githubusercontent.com/493741/214667078-eb5c1877-2bdd-40c1-b94e-4a50d6852c06.png) - -_Works on Windows/macOS/Linux._ - -Raspberry Pi (3, 4, Zero 2): [requires 64-bit OS](https://github.com/vogler/free-games-claimer/issues/3) like Raspberry Pi OS or Ubuntu (Raspbian won't work since it's 32-bit). - -## How to run -Easy option: [install Docker](https://docs.docker.com/get-docker/) (or [podman](https://podman-desktop.io/)) and run this command in a terminal: +Schnellstart (Docker Run) +------------------------- ``` -docker run --rm -it -p 6080:6080 -v fgc:/fgc/data --pull=always ghcr.io/vogler/free-games-claimer +docker run --rm -it \ + -p 6080:6080 \ + -v fgc:/fgc/data \ + -e SHOW=1 \ + :latest \ + node prime-gaming.js +``` +- `` z. B. `git.sky-net.it/nocci/free-games-claimer` +- Ports 6080/5900: noVNC/VNC (nur nötig mit `SHOW=1`) +- Daten/Configs landen in Volume `fgc` unter `/fgc/data` + +Docker Compose Beispiel +----------------------- +```yaml +services: + fgc: + image: :latest + container_name: fgc + environment: + - SHOW=1 # Browser sichtbar via VNC/noVNC + # - PG_EMAIL=... + # - PG_PASSWORD=... + # - PG_OTPKEY=... + volumes: + - fgc:/fgc/data + ports: + - "6080:6080" # noVNC + # - "5900:5900" # VNC optional + command: bash -c "node epic-games; node prime-gaming; node gog" +volumes: + fgc: ``` -_This currently gives you a captcha challenge for epic-games. Until [issue #183](https://github.com/vogler/free-games-claimer/issues/183) is fixed, it is recommended to just run `node epic-games` without docker (see below)._ +CI / eigenes Image +------------------ +- Workflow: `.forgejo/workflows/build.yml` baut/pusht auf `push` nach `main`. +- Secrets in Forgejo setzen: + - `REGISTRY` (z. B. `git.sky-net.it`) + - `REGISTRY_IMAGE` (z. B. `git.sky-net.it/nocci/free-games-claimer`) + - `REG_USER`, `REG_TOKEN` (PAT mit Paket-Push) +- Self-hosted Runner mit Docker-Access (`runs-on: self-hosted`) wird benötigt. -This will run `node epic-games; node prime-gaming; node gog` - if you only want to claim games for one of the stores, you can override the default command by appending e.g. `node epic-games` at the end of the `docker run` command, or if you want several `bash -c "node epic-games.js; node gog.js"`. -Data (including json files with claimed games, codes to redeem, screenshots) is stored in the Docker volume `fgc`. +Konfiguration (Umgebungsvariablen) +---------------------------------- +Typische Optionen: +- `SHOW=0/1` (0 = headless, 1 = UI) +- `WIDTH`, `HEIGHT` (Browsergröße) +- `TIMEOUT`, `LOGIN_TIMEOUT` (Sek.) +- Login: `EMAIL`, `PASSWORD` global; spezifisch `EG_EMAIL`, `EG_PASSWORD`, `EG_OTPKEY`, `PG_EMAIL`, `PG_PASSWORD`, `PG_OTPKEY`, `GOG_EMAIL`, `GOG_PASSWORD` +- Prime-Gaming: `PG_REDEEM=1` (Keys automatisch einlösen, experimentell), `PG_CLAIMDLC=1`, `PG_TIMELEFT=` zum Überspringen mit langer Restzeit +- Screenshots: `SCREENSHOTS_DIR` (Standard `data/screenshots`) +- Notifications: `NOTIFY='...'` (Apprise-URL), optional `NOTIFY_TITLE` -### Eigene Images aus Forgejo bauen -Falls du den Fork in einer selbst gehosteten Forgejo-Instanz pflegst: +Du kannst eine `data/config.env` anlegen; sie wird per dotenv geladen und überschreibt nichts, was bereits in der Umgebung gesetzt ist. -- Der Workflow `.forgejo/workflows/build.yml` baut/pusht das Docker-Image auf `push` nach `main`. -- Setze in Forgejo die Secrets `REGISTRY`, `REGISTRY_IMAGE`, `REG_USER`, `REG_TOKEN` (PAT mit Paket-Push). -- Self-hosted Runner mit Docker muss registriert sein (`runs-on: self-hosted`). -- Danach kannst du das Image ziehen, z.B.: `docker pull $REGISTRY_IMAGE:latest`. +Lokal ohne Docker +----------------- +``` +npm install +SHOW=0 PG_EMAIL=... PG_PASSWORD=... PG_OTPKEY=... node prime-gaming.js +``` +- Playwright lädt Firefox beim `npm install` in `~/.cache/ms-playwright`. +- Für sichtbaren Browser `SHOW=1` (GUI/Xvfb nötig). -
- I want to run without Docker or develop locally. +Persistenz & Ausgaben +--------------------- +- Daten & Status: `data/*.json` (pro Store) +- Browserprofil: `data/browser` +- Screenshots: `data/screenshots//` +- Optionale Videos/HAR: `RECORD=1` → `data/record/` -1. [Install Node.js](https://nodejs.org/en/download) -2. Clone/download this repository and `cd` into it in a terminal -3. Run `npm install` -4. Run `pip install apprise` (or use [pipx](https://github.com/pypa/pipx) if you have [problems](https://stackoverflow.com/questions/75608323/how-do-i-solve-error-externally-managed-environment-every-time-i-use-pip-3)) to install [apprise](https://github.com/caronc/apprise) if you want notifications -5. To get updates: `git pull; npm install` -6. Run `node epic-games`, `node prime-gaming`, `node gog`... - -During `npm install` Playwright will download its Firefox to a cache in home ([doc](https://playwright.dev/docs/browsers#managing-browser-binaries)). -If you are missing some dependencies for the browser on your system, you can use `sudo npx playwright install firefox --with-deps`. - -If you don't want to use Docker for quasi-headless mode, you could run inside a virtual machine, on a server, or you wake your PC at night to avoid being interrupted. -
- -## Usage -All scripts start an automated Firefox instance, either with the browser GUI shown or hidden (*headless mode*). By default, you won't see any browser open on your host system. - -- When running inside Docker, the browser will be shown only inside the container. You can open http://localhost:6080 to interact with the browser running inside the container via noVNC (or use other VNC clients on port 5900). -- When running the scripts outside of Docker, the browser will be hidden by default; you can use `SHOW=1 ...` to show the UI (see options below). - -When running the first time, you have to login for each store you want to claim games on. -You can login indirectly via the terminal or directly in the browser. The scripts will wait until you are successfully logged in. - -There will be prompts in the terminal asking you to enter email, password, and afterwards some OTP (one time password / security code) if you have 2FA/MFA (two-/multi-factor authentication) enabled. If you want to login yourself via the browser, you can press escape in the terminal to skip the prompts. - -After login, the script will continue claiming the current games. If it still waits after you are already logged in, you can restart it (and open an issue). If you run the scripts regularly, you should not have to login again. - -### Configuration / Options -Options are set via [environment variables](https://kinsta.com/knowledgebase/what-is-an-environment-variable/) which allow for flexible configuration. - -TODO: ~~On the first run, the script will guide you through configuration and save all settings to `data/config.env`. You can edit this file directly or run `node fgc config` to run the configuration assistant again.~~ - -Available options/variables and their default values: - -| Option | Default | Description | -|--------------- |--------- |------------------------------------------------------------------------ | -| SHOW | 1 | Show browser if 1. Default for Docker, not shown when running outside. | -| WIDTH | 1280 | Width of the opened browser (and of screen for VNC in Docker). | -| HEIGHT | 1280 | Height of the opened browser (and of screen for VNC in Docker). | -| VNC_PASSWORD | | VNC password for Docker. No password used by default! | -| NOTIFY | | Notification services to use (Pushover, Slack, Telegram...), see below. [Apprise](https://github.com/caronc/apprise) | -| NOTIFY_TITLE | | Optional title for notifications, e.g. for Pushover. | -| BROWSER_DIR | data/browser | Directory for browser profile, e.g. for multiple accounts. | -| TIMEOUT | 60 | Timeout for any page action. Should be fine even on slow machines. | -| LOGIN_TIMEOUT | 180 | Timeout for login in seconds. Will wait twice (prompt + manual login). | -| EMAIL | | Default email for any login. | -| PASSWORD | | Default password for any login. | -| EG_EMAIL | | Epic Games email for login. Overrides EMAIL. | -| EG_PASSWORD | | Epic Games password for login. Overrides PASSWORD. | -| EG_OTPKEY | | Epic Games MFA OTP key. | -| EG_PARENTALPIN | | Epic Games Parental Controls PIN. | -| PG_EMAIL | | Prime Gaming email for login. Overrides EMAIL. | -| PG_PASSWORD | | Prime Gaming password for login. Overrides PASSWORD. | -| PG_OTPKEY | | Prime Gaming MFA OTP key. | -| PG_REDEEM | 0 | Prime Gaming: try to redeem keys on external stores ([experimental](https://github.com/vogler/free-games-claimer/issues/5)). | -| PG_CLAIMDLC | 0 | Prime Gaming: try to claim DLCs ([experimental](https://github.com/vogler/free-games-claimer/issues/55)). | -| GOG_EMAIL | | GOG email for login. Overrides EMAIL. | -| GOG_PASSWORD | | GOG password for login. Overrides PASSWORD. | -| GOG_NEWSLETTER | 0 | Do not unsubscribe from newsletter after claiming a game if 1. | -| LG_EMAIL | | Legacy Games: email to use for redeeming (if not set, defaults to PG_EMAIL) | - -See `src/config.js` for all options. - -#### How to set options -You can add options directly in the command or put them in a file to load. - -##### Docker -You can pass variables using `-e VAR=VAL`, for example `docker run -e EMAIL=foo@bar.baz -e NOTIFY='tgram://bottoken/ChatID' ...` or using `--env-file fgc.env` where `fgc.env` is a file on your host system (see [docs](https://docs.docker.com/engine/reference/commandline/run/#env)). You can also `docker cp` your configuration file to `/fgc/data/config.env` in the `fgc` volume to store it with the rest of the data instead of on the host ([example](https://github.com/moby/moby/issues/25245#issuecomment-365980572)). -If you are using [docker compose](https://docs.docker.com/compose/environment-variables/) (or Portainer etc.), you can put options in the `environment:` section. - -##### Without Docker -On Linux/macOS you can prefix the variables you want to set, for example `EMAIL=foo@bar.baz SHOW=1 node epic-games` will show the browser and skip asking you for your login email. On Windows you have to use `set`, [example](https://github.com/vogler/free-games-claimer/issues/314). -You can also put options in `data/config.env` which will be loaded by [dotenv](https://github.com/motdotla/dotenv). - -### Notifications -The scripts will try to send notifications for successfully claimed games and any errors like needing to log in or encountered captchas (should not happen). - -[apprise](https://github.com/caronc/apprise) is used for notifications and offers many services including Pushover, Slack, Telegram, SMS, Email, desktop and custom notifications. -You just need to set `NOTIFY` to the notification services you want to use, e.g. `NOTIFY='mailto://myemail:mypass@gmail.com' 'pbul://o.gn5kj6nfhv736I7jC3cj3QLRiyhgl98b'` - refer to their list of services and [examples](https://github.com/caronc/apprise#command-line-usage). - -### Automatic login, two-factor authentication -If you set the options for email, password and OTP key, there will be no prompts and logins should happen automatically. This is optional since all stores should stay logged in since cookies are refreshed. -To get the OTP key, it is easiest to follow the store's guide for adding an authenticator app. You should also scan the shown QR code with your favorite app to have an alternative method for 2FA. - -- **Epic Games**: visit [password & security](https://www.epicgames.com/account/password), enable 'third-party authenticator app', copy the 'Manual Entry Key' and use it to set `EG_OTPKEY`. -- **Prime Gaming**: visit Amazon 'Your Account › Login & security', 2-step verification › Manage › Add new app › Can't scan the barcode, copy the bold key and use it to set `PG_OTPKEY` -- **GOG**: only offers OTP via email - - -Beware that storing passwords and OTP keys as clear text may be a security risk. Use a unique/generated password! TODO: maybe at least offer to base64 encode for storage. - -### Epic Games Store -Run `node epic-games` (locally or in Docker). - -### Amazon Prime Gaming -Run `node prime-gaming` (locally or in Docker). - -Claiming the Amazon Games works out-of-the-box, however, for games on external stores you need to either link your account or redeem a key. - -- Stores that require account linking: Epic Games, Battle.net, Origin. -- Stores that require redeeming a key: GOG.com, Microsoft Games, Legacy Games. - - Keys and URLs are printed to the console, included in notifications and saved in `data/prime-gaming.json`. A screenshot of the page with the key is also saved to `data/screenshots`. - [TODO](https://github.com/vogler/free-games-claimer/issues/5): ~~redeem keys on external stores.~~ - - - - -### Run periodically -#### How often? -Epic Games usually has two free games *every week*, before Christmas every day. -Prime Gaming has new games *every month* or more often during Prime days. -GOG usually has one new game every couples of weeks. -Unreal Engine has new assets to claim *every first Tuesday of a month*. - - -It is safe to run the scripts every day. - -#### How to schedule? -The container/scripts will claim currently available games and then exit. -If you want it to run regularly, you have to schedule the runs yourself: - -- Linux/macOS: `crontab -e` ([example](https://github.com/vogler/free-games-claimer/discussions/56)) -- macOS: [launchd](https://stackoverflow.com/questions/132955/how-do-i-set-a-task-to-run-every-so-often) -- Windows: [task scheduler](https://active-directory-wp.com/docs/Usage/How_to_add_a_cron_job_on_Windows/Scheduled_tasks_and_cron_jobs_on_Windows/index.html) ([example](https://github.com/vogler/free-games-claimer/wiki/%5BHowTo%5D-Schedule-runs-on-Windows)), [other options](https://stackoverflow.com/questions/132971/what-is-the-windows-version-of-cron), or just put the command in a `.bat` file in Autostart if you restart often... -- any OS: use a process manager like [pm2](https://pm2.keymetrics.io/docs/usage/restart-strategies/) -- Docker Compose `command: bash -c "node epic-games; node prime-gaming; node gog; echo sleeping; sleep 1d"` additionally add `restart: unless-stopped` to it. - -TODO: ~~add some server-mode where the script just keeps running and claims games e.g. every day.~~ - -### Problems? - -Check the open [issues](https://github.com/vogler/free-games-claimer/issues) and comment there or open a new issue. - -If you're a developer, you can use `PWDEBUG=1 ...` to [inspect](https://playwright.dev/docs/inspector) which opens a debugger where you can step through the script. - - -## History/DevLog -
- Click to expand - -Tried [epicgames-freebies-claimer](https://github.com/Revadike/epicgames-freebies-claimer), but had problems since epicgames introduced hcaptcha (see [issue](https://github.com/Revadike/epicgames-freebies-claimer/issues/172)). - -Played around with puppeteer before, now trying newer https://playwright.dev which is pretty similar. -Playwright Inspector and `codegen` to generate scripts are nice, but failed to generate the right code for clicking a button in an iframe. - -Added [main.spec.ts](https://github.com/vogler/epicgames-claimer/commit/e5ce7916ab6329cfc7134677c4d89c2b3fa3ba97#diff-d18d03e9c407a20e05fbf03cbd6f9299857740544fb6b50d6a70b9c6fbc35831) which was the test script generated by `npx playwright codegen` with manual fix for clicking buttons in the created iframe. Can be executed by `npx playwright test`. The test runner has options `--debug` and `--timeout` and can execute typescript which is nice. However, this only worked up to the button 'I Agree', and then showed an hcaptcha. - -Added [main.captcha.js](https://github.com/vogler/epicgames-claimer/commit/e5ce7916ab6329cfc7134677c4d89c2b3fa3ba97#diff-d18d03e9c407a20e05fbf03cbd6f9299857740544fb6b50d6a70b9c6fbc35831) which uses beta of `playwright-extra@next` and `@extra/recaptcha@next` (from [comment on puppeteer-extra](https://github.com/berstend/puppeteer-extra/pull/303#issuecomment-775277480)). -However, `playwright-extra` seems to be old and missing `:has-text` selector (fixed [here](https://github.com/vogler/epicgames-claimer/commit/ba97a0e840b65f4476cca18e28d8461b0c703420)) and `page.frameLocator`, so the script did not run without adjustments. -Also, solving via [2captcha](https://2captcha.com?from=13225256) is a paid service which takes time and may be unreliable. - - -Added [main.stealth.js](https://github.com/vogler/epicgames-claimer/commit/64d0ba8ce71baec3947d1b64acd567befcb39340#diff-f70d3bd29df4a343f11062a97063953173491ce30fe34f69a0fc52517adbf342) which uses the stealth plugin without `playwright-extra` wrapper but up-to-date `playwright` (from [comment](https://github.com/berstend/puppeteer-extra/issues/454#issuecomment-917437212)). -The listed evasions are enough to not show an hcaptcha. Script claimed game successfully in non-headless mode. - -Removed `main.captcha.js`. -Using Playwright Test (`main.spec.ts`) instead of Library (`main.stealth.js`) has the advantage of free CLI like `--debug` and `--timeout`. - - -Button selectors should preferably use text in order to be more stable against changes in the DOM. - -Renamed repository from epicgames-claimer to free-games-claimer since a script for Amazon Prime Gaming was also added. Removed all old scripts in favor of just `epic-games.js` and `prime-gaming.js`. - -epic games: `headless` mode gets hcaptcha challenge. More details/references in [issue](https://github.com/vogler/free-games-claimer/issues/2). - -https://github.com/vogler/free-games-claimer/pull/11 introduced a Dockerfile for running non-headless inside the container via xvfb which makes it headless for the host running the container. - -v1.0 Standalone scripts node epic-games and node prime-gaming using Chromium. - -Changed to Firefox for all scripts since Chromium led to captchas. Claiming then also worked in headless mode without Docker. - -Added options via env vars, configurable in `data/config.env`. - -Added OTP generation via otplib for automatic login, even with 2FA. - -Added notifications via [apprise](https://github.com/caronc/apprise). -
- -[![Star History Chart](https://api.star-history.com/svg?repos=vogler/free-games-claimer&type=Date)](https://star-history.com/#vogler/free-games-claimer&Date) - - -![Alt](https://repobeats.axiom.co/api/embed/a1c5e6e420d90e0d6b34c1285e92a69a44138faa.svg "Repobeats analytics image") - ---- - -Logo with smaller aspect ratio (for Telegram bot etc.): 👾 - [emojipedia](https://emojipedia.org/alien-monster/) - -![logo-fgc](https://user-images.githubusercontent.com/493741/214589922-093d6557-6393-421c-b577-da58ff3671bc.png) +Tipp: Bei Captchas oder Erst-Login `SHOW=1` nutzen und einmal manuell einloggen; Cookies bleiben im Profil. Notifications via `NOTIFY` helfen bei Fehlermeldungen (z. B. Captcha, Login).*** From eba07721ca09a04c0c95e2f9672f87d084c6ee15 Mon Sep 17 00:00:00 2001 From: nocci Date: Mon, 29 Dec 2025 14:38:54 +0000 Subject: [PATCH 07/47] =?UTF-8?q?=F0=9F=93=9D=20docs(README):=20update=20i?= =?UTF-8?q?nstructions=20and=20clarify=20configurations?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - update registry image references to point to `git.sky-net.it/nocci/free-games-claimer` - improve clarity on Docker and Docker Compose examples - translate German sections into English for wider accessibility - add detailed explanations for environment variables and configurations - enhance quickstart and CI instructions for better understanding --- README.md | 83 +++++++++++++++++++++++++++---------------------------- 1 file changed, 41 insertions(+), 42 deletions(-) diff --git a/README.md b/README.md index be82e97..8ccf31c 100644 --- a/README.md +++ b/README.md @@ -3,41 +3,40 @@ Free Games Claimer (Fork) Automates claiming of free games for: - Epic Games Store (and Epic-linked assets) -- Amazon Prime Gaming / Luna claims (incl. external stores like GOG, Legacy, Microsoft) +- Amazon Prime Gaming / Luna claims (including external stores like GOG, Legacy, Microsoft) - GOG giveaways - Optional extras: Steam stats, AliExpress dailies (experimental) -This fork adds a Forgejo CI pipeline and instructions for running the pre-built image from your own registry. +This fork adds a Forgejo CI pipeline and instructions for running the pre-built image from the registry at `git.sky-net.it/nocci/free-games-claimer`. Requirements ------------ -- Docker or Podman (empfohlen) **oder** Node.js ≥ 20 zum lokalen Lauf -- (Optional) Python `apprise` für Benachrichtigungen: `pip install apprise` -- Für Playwright: Linux-Desktop-Abhängigkeiten sind im Container enthalten; lokal ggf. `npm install` zieht Firefox mit. +- Docker or Podman (recommended), or Node.js ≥ 20 for local runs +- Optional notifications: `pip install apprise` +- Playwright dependencies are baked into the container; locally, `npm install` downloads Firefox. -Schnellstart (Docker Run) -------------------------- +Quickstart (Docker Run) +----------------------- ``` docker run --rm -it \ -p 6080:6080 \ -v fgc:/fgc/data \ -e SHOW=1 \ - :latest \ + git.sky-net.it/nocci/free-games-claimer:latest \ node prime-gaming.js ``` -- `` z. B. `git.sky-net.it/nocci/free-games-claimer` -- Ports 6080/5900: noVNC/VNC (nur nötig mit `SHOW=1`) -- Daten/Configs landen in Volume `fgc` unter `/fgc/data` +- Ports 6080/5900: noVNC/VNC (only needed with `SHOW=1`) +- Data/configs are stored in volume `fgc` under `/fgc/data` -Docker Compose Beispiel ------------------------ +Docker Compose Example +---------------------- ```yaml services: fgc: - image: :latest + image: git.sky-net.it/nocci/free-games-claimer:latest container_name: fgc environment: - - SHOW=1 # Browser sichtbar via VNC/noVNC + - SHOW=1 # show browser via VNC/noVNC # - PG_EMAIL=... # - PG_PASSWORD=... # - PG_OTPKEY=... @@ -51,42 +50,42 @@ volumes: fgc: ``` -CI / eigenes Image ------------------- -- Workflow: `.forgejo/workflows/build.yml` baut/pusht auf `push` nach `main`. -- Secrets in Forgejo setzen: - - `REGISTRY` (z. B. `git.sky-net.it`) - - `REGISTRY_IMAGE` (z. B. `git.sky-net.it/nocci/free-games-claimer`) - - `REG_USER`, `REG_TOKEN` (PAT mit Paket-Push) -- Self-hosted Runner mit Docker-Access (`runs-on: self-hosted`) wird benötigt. +CI / Build Your Own Image +------------------------- +- Workflow: `.forgejo/workflows/build.yml` builds/pushes on `push` to `main`. +- Secrets needed in Forgejo: + - `REGISTRY` (e.g., `git.sky-net.it`) + - `REGISTRY_IMAGE` (e.g., `git.sky-net.it/nocci/free-games-claimer`) + - `REG_USER`, `REG_TOKEN` (PAT with package push) +- Requires a self-hosted runner with Docker access (`runs-on: self-hosted`). -Konfiguration (Umgebungsvariablen) ----------------------------------- -Typische Optionen: +Configuration (Environment Variables) +------------------------------------- +Common options: - `SHOW=0/1` (0 = headless, 1 = UI) -- `WIDTH`, `HEIGHT` (Browsergröße) -- `TIMEOUT`, `LOGIN_TIMEOUT` (Sek.) -- Login: `EMAIL`, `PASSWORD` global; spezifisch `EG_EMAIL`, `EG_PASSWORD`, `EG_OTPKEY`, `PG_EMAIL`, `PG_PASSWORD`, `PG_OTPKEY`, `GOG_EMAIL`, `GOG_PASSWORD` -- Prime-Gaming: `PG_REDEEM=1` (Keys automatisch einlösen, experimentell), `PG_CLAIMDLC=1`, `PG_TIMELEFT=` zum Überspringen mit langer Restzeit -- Screenshots: `SCREENSHOTS_DIR` (Standard `data/screenshots`) -- Notifications: `NOTIFY='...'` (Apprise-URL), optional `NOTIFY_TITLE` +- `WIDTH`, `HEIGHT` (browser size) +- `TIMEOUT`, `LOGIN_TIMEOUT` (seconds) +- Login: `EMAIL`, `PASSWORD` global; per store `EG_EMAIL`, `EG_PASSWORD`, `EG_OTPKEY`, `PG_EMAIL`, `PG_PASSWORD`, `PG_OTPKEY`, `GOG_EMAIL`, `GOG_PASSWORD` +- Prime Gaming: `PG_REDEEM=1` (auto-redeem keys, experimental), `PG_CLAIMDLC=1`, `PG_TIMELEFT=` to skip long-remaining offers +- Screenshots: `SCREENSHOTS_DIR` (default `data/screenshots`) +- Notifications: `NOTIFY='...'` (Apprise URL), optional `NOTIFY_TITLE` -Du kannst eine `data/config.env` anlegen; sie wird per dotenv geladen und überschreibt nichts, was bereits in der Umgebung gesetzt ist. +You can place a `data/config.env`; it is loaded via dotenv and is overridden by explicitly set environment variables. -Lokal ohne Docker ------------------ +Local Run Without Docker +------------------------ ``` npm install SHOW=0 PG_EMAIL=... PG_PASSWORD=... PG_OTPKEY=... node prime-gaming.js ``` -- Playwright lädt Firefox beim `npm install` in `~/.cache/ms-playwright`. -- Für sichtbaren Browser `SHOW=1` (GUI/Xvfb nötig). +- Playwright downloads Firefox to `~/.cache/ms-playwright`. +- Use `SHOW=1` for a visible browser (requires GUI/Xvfb). -Persistenz & Ausgaben +Persistence & Outputs --------------------- -- Daten & Status: `data/*.json` (pro Store) -- Browserprofil: `data/browser` +- Data/status: `data/*.json` (per store) +- Browser profile: `data/browser` - Screenshots: `data/screenshots//` -- Optionale Videos/HAR: `RECORD=1` → `data/record/` +- Optional videos/HAR: `RECORD=1` → `data/record/` -Tipp: Bei Captchas oder Erst-Login `SHOW=1` nutzen und einmal manuell einloggen; Cookies bleiben im Profil. Notifications via `NOTIFY` helfen bei Fehlermeldungen (z. B. Captcha, Login).*** +Tip: For captchas or first-time login, run with `SHOW=1` and log in once; cookies stay in the profile. Notifications via `NOTIFY` help surface errors (e.g., captcha, login). From eb5b9bbb6e8890e51072c2a592dd14d45a469d83 Mon Sep 17 00:00:00 2001 From: nocci Date: Mon, 29 Dec 2025 15:01:55 +0000 Subject: [PATCH 08/47] =?UTF-8?q?=F0=9F=91=B7=20ci(build):=20enhance=20doc?= =?UTF-8?q?ker=20build=20process=20with=20buildx?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - add Docker Buildx setup for advanced build capabilities - update build step to use buildx for multi-platform support --- .forgejo/workflows/build.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index 97fa8a0..3aa7b56 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -9,6 +9,9 @@ jobs: docker: runs-on: self-hosted steps: + - name: Set up Docker Buildx + uses: docker/setup-buildx-action@v3 + - name: Checkout uses: actions/checkout@v4 @@ -17,8 +20,9 @@ jobs: - name: Build image run: | - docker build -t "${{ secrets.REGISTRY_IMAGE }}:${{ github.sha }}" \ - -t "${{ secrets.REGISTRY_IMAGE }}:latest" . + docker buildx build --load \ + -t "${{ secrets.REGISTRY_IMAGE }}:${{ github.sha }}" \ + -t "${{ secrets.REGISTRY_IMAGE }}:latest" . - name: Push image run: | From 0a729d0cbfa562f6913bbe2d7a0085e2da07ab72 Mon Sep 17 00:00:00 2001 From: nocci Date: Mon, 29 Dec 2025 15:08:00 +0000 Subject: [PATCH 09/47] =?UTF-8?q?=F0=9F=94=A7=20chore(workflow):=20simplif?= =?UTF-8?q?y=20docker=20image=20tagging=20and=20pushing?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - remove specific sha tag from build and push steps - streamline workflow by focusing on latest tag --- .forgejo/workflows/build.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index 3aa7b56..cb83fb0 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -21,10 +21,8 @@ jobs: - name: Build image run: | docker buildx build --load \ - -t "${{ secrets.REGISTRY_IMAGE }}:${{ github.sha }}" \ -t "${{ secrets.REGISTRY_IMAGE }}:latest" . - name: Push image run: | - docker push "${{ secrets.REGISTRY_IMAGE }}:${{ github.sha }}" docker push "${{ secrets.REGISTRY_IMAGE }}:latest" From 9d79f9ac7851f8d4dabdb0cb0e5bc1dd3cc29525 Mon Sep 17 00:00:00 2001 From: nocci Date: Mon, 29 Dec 2025 15:54:41 +0000 Subject: [PATCH 10/47] =?UTF-8?q?=F0=9F=93=9D=20docs(README):=20update=20c?= =?UTF-8?q?onfiguration=20and=20remove=20CI=20section?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - remove outdated CI/build instructions - add new environment variable options for configuration 🐛 fix(util): handle notification errors gracefully - resolve promise instead of rejecting on notification errors - prevent whole run from failing due to notification issues --- README.md | 16 +++++++--------- src/util.js | 3 ++- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 8ccf31c..16ac157 100644 --- a/README.md +++ b/README.md @@ -50,15 +50,6 @@ volumes: fgc: ``` -CI / Build Your Own Image -------------------------- -- Workflow: `.forgejo/workflows/build.yml` builds/pushes on `push` to `main`. -- Secrets needed in Forgejo: - - `REGISTRY` (e.g., `git.sky-net.it`) - - `REGISTRY_IMAGE` (e.g., `git.sky-net.it/nocci/free-games-claimer`) - - `REG_USER`, `REG_TOKEN` (PAT with package push) -- Requires a self-hosted runner with Docker access (`runs-on: self-hosted`). - Configuration (Environment Variables) ------------------------------------- Common options: @@ -69,6 +60,13 @@ Common options: - Prime Gaming: `PG_REDEEM=1` (auto-redeem keys, experimental), `PG_CLAIMDLC=1`, `PG_TIMELEFT=` to skip long-remaining offers - Screenshots: `SCREENSHOTS_DIR` (default `data/screenshots`) - Notifications: `NOTIFY='...'` (Apprise URL), optional `NOTIFY_TITLE` +- Browser profile: `BROWSER_DIR` (default `data/browser`) +- Recording: `RECORD=1` to save videos/HAR to `data/record/` +- Debugging: `DEBUG=1` (opens Playwright inspector), `DEBUG_NETWORK=1` (logs requests), `TIME=1` (prints timings) +- Dry run / Interaction: `DRYRUN=1` (do not claim), `INTERACTIVE=1` (ask before claiming), `HEADLESS` is derived from `SHOW`/`DEBUG` +- Directories: `SCREENSHOTS_DIR`, `BROWSER_DIR`, `DATA_DIR` (prefix for data; default under `data/`) +- VNC/noVNC: `VNC_PASSWORD` (for Docker entrypoint), `NOVNC_PORT`/`VNC_PORT` (Docker) +- General timeouts: `TIMEOUT` (per action), `LOGIN_TIMEOUT` (extra time for login) You can place a `data/config.env`; it is loaded via dotenv and is overridden by explicitly set environment variables. diff --git a/src/util.js b/src/util.js index 308952d..49424f8 100644 --- a/src/util.js +++ b/src/util.js @@ -125,7 +125,8 @@ export const notify = html => new Promise((resolve, reject) => { if (error.message.includes('command not found')) { console.info('Run `pip install apprise`. See https://github.com/vogler/free-games-claimer#notifications'); } - return reject(error); + // don't fail the whole run on notification errors + return resolve(); } if (stderr) console.error(`stderr: ${stderr}`); if (stdout) console.log(`stdout: ${stdout}`); From e39cca93c23fe1412ca1bdecbbeda45843bd060f Mon Sep 17 00:00:00 2001 From: nocci Date: Mon, 29 Dec 2025 17:19:39 +0100 Subject: [PATCH 11/47] better README.md --- README.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 16ac157..248995e 100644 --- a/README.md +++ b/README.md @@ -2,12 +2,9 @@ Free Games Claimer (Fork) ========================== Automates claiming of free games for: -- Epic Games Store (and Epic-linked assets) -- Amazon Prime Gaming / Luna claims (including external stores like GOG, Legacy, Microsoft) +- Amazon Luna Gaming / Luna claims (including external stores like GOG, Epic Games, Legacy Games ) - GOG giveaways -- Optional extras: Steam stats, AliExpress dailies (experimental) - -This fork adds a Forgejo CI pipeline and instructions for running the pre-built image from the registry at `git.sky-net.it/nocci/free-games-claimer`. +- Optional extras: Steam stats, AliExpress dailies (not implemated yet) Requirements ------------ From 0e5303da623e186951c8ff01614f688ca09bcd16 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 11:02:01 +0000 Subject: [PATCH 12/47] =?UTF-8?q?=F0=9F=91=B7=20ci(workflow):=20add=20lint?= =?UTF-8?q?=20job=20to=20build=20workflow?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - introduce lint job in build.yml for code quality checks - ensure lint job runs before docker job - setup Node.js and install dependencies for ESLint --- .forgejo/workflows/build.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index cb83fb0..c15f8c5 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -6,7 +6,22 @@ on: - main jobs: + lint: + runs-on: self-hosted + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version: 20 + - name: Install dependencies + run: npm ci + - name: Run ESLint + run: npm run lint + docker: + needs: lint runs-on: self-hosted steps: - name: Set up Docker Buildx From d40a577f4778669c10e644f582aa2cd0012af490 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 12:38:03 +0000 Subject: [PATCH 13/47] =?UTF-8?q?=F0=9F=91=B7=20ci(build):=20add=20SonarQu?= =?UTF-8?q?be=20scan=20to=20build=20workflow?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - introduce SonarQube scanning step for code quality analysis - update workflow dependencies and execution order 🐛 fix(auth): improve error handling and code formatting - remove unused imports and fix code indentation - enhance error handling with improved catch blocks 💄 style(general): standardize code formatting and style consistency - update various files to ensure consistent code style - adjust indentation and whitespace for readability --- .forgejo/workflows/build.yml | 25 ++++++++++- aliexpress.js | 30 ++++++++----- prime-gaming.js | 54 ++++++++++++----------- src/util.js | 8 ++-- steam-games.js | 10 ++--- test/sigint-enquirer-raw-keeps-running.js | 4 +- test/sigint-enquirer-raw.js | 26 +++++------ 7 files changed, 95 insertions(+), 62 deletions(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index c15f8c5..882e541 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -20,9 +20,32 @@ jobs: - name: Run ESLint run: npm run lint - docker: + sonar: needs: lint runs-on: self-hosted + steps: + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 + - name: SonarQube Scan + env: + SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }} + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + run: | + docker run --rm \ + -e SONAR_HOST_URL="$SONAR_HOST_URL" \ + -e SONAR_TOKEN="$SONAR_TOKEN" \ + -v "$PWD:/usr/src" \ + -w /usr/src \ + sonarsource/sonar-scanner-cli \ + sonar-scanner \ + -Dsonar.host.url="$SONAR_HOST_URL" \ + -Dsonar.login="$SONAR_TOKEN" + + docker: + needs: [lint, sonar] + runs-on: self-hosted steps: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 diff --git a/aliexpress.js b/aliexpress.js index 52e75a0..6d654d3 100644 --- a/aliexpress.js +++ b/aliexpress.js @@ -1,5 +1,5 @@ import { firefox } from 'playwright-firefox'; // stealth plugin needs no outdated playwright-extra -import { datetime, filenamify, prompt, handleSIGINT, stealth } from './src/util.js'; +import { datetime, filenamify, prompt, handleSIGINT } from './src/util.js'; import { cfg } from './src/config.js'; // using https://github.com/apify/fingerprint-suite worked, but has no launchPersistentContext... @@ -8,8 +8,8 @@ import { FingerprintInjector } from 'fingerprint-injector'; import { FingerprintGenerator } from 'fingerprint-generator'; const { fingerprint, headers } = new FingerprintGenerator().getFingerprint({ - devices: ["mobile"], - operatingSystems: ["android"], + devices: ['mobile'], + operatingSystems: ['android'], }); const context = await firefox.launchPersistentContext(cfg.dir.browser, { @@ -21,11 +21,11 @@ const context = await firefox.launchPersistentContext(cfg.dir.browser, { handleSIGINT: false, // have to handle ourselves and call context.close(), otherwise recordings from above won't be saved userAgent: fingerprint.navigator.userAgent, viewport: { - width: fingerprint.screen.width, - height: fingerprint.screen.height, + width: fingerprint.screen.width, + height: fingerprint.screen.height, }, extraHTTPHeaders: { - 'accept-language': headers['accept-language'], + 'accept-language': headers['accept-language'], }, }); handleSIGINT(context); @@ -36,7 +36,7 @@ context.setDefaultTimeout(cfg.debug ? 0 : cfg.timeout); const page = context.pages().length ? context.pages()[0] : await context.newPage(); // should always exist -const auth = async (url) => { +const auth = async url => { console.log('auth', url); await page.goto(url, { waitUntil: 'domcontentloaded' }); // redirects to https://login.aliexpress.com/?return_url=https%3A%2F%2Fwww.aliexpress.com%2Fp%2Fcoin-pc-index%2Findex.html @@ -45,7 +45,7 @@ const auth = async (url) => { console.error('Not logged in! Will wait for 120s for you to login...'); // await page.waitForTimeout(120*1000); // or try automated - page.locator('span:has-text("Switch account")').click().catch(_ => {}); // sometimes no longer logged in, but previous user/email is pre-selected -> in this case we want to go back to the classic login + page.locator('span:has-text("Switch account")').click().catch(() => {}); // sometimes no longer logged in, but previous user/email is pre-selected -> in this case we want to go back to the classic login const login = page.locator('.login-container'); const email = cfg.ae_email || await prompt({ message: 'Enter email' }); const emailInput = login.locator('input[label="Email or phone number"]'); @@ -58,11 +58,11 @@ const auth = async (url) => { await login.locator('input[label="Password"]').fill(password); await login.locator('button:has-text("Sign in")').click(); const error = login.locator('.error-text'); - error.waitFor().then(async _ => console.error('Login error:', await error.innerText())); + error.waitFor().then(async () => console.error('Login error:', await error.innerText())); await page.waitForURL(url); // await page.addLocatorHandler(page.getByRole('button', { name: 'Accept cookies' }), btn => btn.click()); - page.getByRole('button', { name: 'Accept cookies' }).click().then(_ => console.log('Accepted cookies')).catch(_ => { }); - }), page.locator('#nav-user-account').waitFor()]).catch(_ => {}); + page.getByRole('button', { name: 'Accept cookies' }).click().then(() => console.log('Accepted cookies')).catch(() => { }); + }), page.locator('#nav-user-account').waitFor()]).catch(() => {}); // await page.locator('#nav-user-account').hover(); // console.log('Logged in as:', await page.locator('.welcome-name').innerText()); @@ -80,6 +80,7 @@ const urls = { merge: 'https://m.aliexpress.com/p/merge-market/index.html', }; +/* eslint-disable no-unused-vars */ const coins = async () => { // await auth(urls.coins); await Promise.any([page.locator('.checkin-button').click(), page.locator('.addcoin').waitFor()]); @@ -103,6 +104,7 @@ const euro = async () => { const merge = async () => { await page.pause(); }; +/* eslint-enable no-unused-vars */ try { // await coins(); @@ -112,7 +114,11 @@ try { // gogo, // euro, merge, - ].reduce((a, f) => a.then(async _ => { await auth(urls[f.name]); await f(); console.log() }), Promise.resolve()); + ].reduce((a, f) => a.then(async () => { + await auth(urls[f.name]); + await f(); + console.log(); + }), Promise.resolve()); // await page.pause(); } catch (error) { diff --git a/prime-gaming.js b/prime-gaming.js index dc39bba..0c982bd 100644 --- a/prime-gaming.js +++ b/prime-gaming.js @@ -41,7 +41,7 @@ const handleMFA = async p => { const otpField = p.locator('#auth-mfa-otpcode, input[name=otpCode]'); if (!await otpField.count()) return false; console.log('Two-Step Verification - enter the One Time Password (OTP), e.g. generated by your Authenticator App'); - await p.locator('#auth-mfa-remember-device, [name=rememberDevice]').check().catch(_ => {}); + await p.locator('#auth-mfa-remember-device, [name=rememberDevice]').check().catch(() => {}); const otp = cfg.pg_otpkey && authenticator.generate(cfg.pg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them await otpField.first().pressSequentially(otp.toString()); await p.locator('input[type="submit"], button[type="submit"]').first().click(); @@ -61,7 +61,7 @@ try { await page.click('input[type="submit"]'); await page.fill('[name=password]', password); await page.click('input[type="submit"]'); - await handleMFA(page).catch(_ => {}); + await handleMFA(page).catch(() => {}); page.waitForURL('**/ap/signin**').then(async () => { // check for wrong credentials const error = await page.locator('.a-alert-content').first().innerText(); if (!error.trim.length) return; @@ -91,7 +91,7 @@ try { '[data-a-target="user-dropdown-first-name-text"]', '[data-testid="user-dropdown-first-name-text"]', ].map(s => page.waitForSelector(s))); - page.click('[aria-label="Cookies usage disclaimer banner"] button:has-text("Accept Cookies")').catch(_ => { }); // to not waste screen space when non-headless, TODO does not work reliably, need to wait for something else first? + page.click('[aria-label="Cookies usage disclaimer banner"] button:has-text("Accept Cookies")').catch(() => { }); // to not waste screen space when non-headless, TODO does not work reliably, need to wait for something else first? while (await page.locator('button:has-text("Sign in"), button:has-text("Anmelden")').count() > 0) { console.error('Not signed in anymore.'); await page.click('button:has-text("Sign in")'); @@ -115,7 +115,7 @@ try { await context.close(); // finishes potential recording process.exit(1); }); - handleMFA(page).catch(_ => {}); + handleMFA(page).catch(() => {}); } else { console.log('Waiting for you to login in the browser.'); await notify('prime-gaming: no longer signed in and not enough options set for automatic login.'); @@ -209,7 +209,7 @@ try { const games = await locateGamesList(); // Load all cards (old and new layout) by scrolling the container or the page if (games) await scrollUntilStable(() => games.evaluate(el => el.scrollHeight).catch(() => 0)); - await scrollUntilStable(() => page.evaluate(() => document.scrollingElement?.scrollHeight ?? 0)); + await scrollUntilStable(() => page.evaluate(() => globalThis.document?.scrollingElement?.scrollHeight ?? 0)); const normalizeClaimUrl = url => { if (!url) return { url, key: null }; @@ -241,7 +241,7 @@ try { const hrefs = [...new Set(await anchorClaims.evaluateAll(anchors => anchors.map(a => a.getAttribute('href')).filter(Boolean)))]; for (const href of hrefs) { const { url, key } = normalizeClaimUrl(href); - const title = key || (await anchorClaims.first().innerText()) || 'Unknown title'; + const title = key || await anchorClaims.first().innerText() || 'Unknown title'; cards.push({ kind: 'external', title, url, key }); } } @@ -286,15 +286,15 @@ try { // bottom to top: oldest to newest games internal.reverse(); external.reverse(); - const sameOrNewPage = async url => new Promise(async (resolve, _reject) => { + const sameOrNewPage = async url => { const isNew = page.url() != url; let p = page; if (isNew) { p = await context.newPage(); await p.goto(url, { waitUntil: 'domcontentloaded' }); } - resolve([p, isNew]); - }); + return [p, isNew]; + }; const skipBasedOnTime = async url => { // console.log(' Checking time left for game:', url); const [p, isNew] = await sameOrNewPage(url); @@ -305,12 +305,12 @@ try { } const dueDateOrg = await dueDateLoc.first().innerText(); const dueDate = new Date(Date.parse(dueDateOrg + ' 17:00')); - const daysLeft = (dueDate.getTime() - Date.now())/1000/60/60/24; + const daysLeft = (dueDate.getTime() - Date.now()) / 1000 / 60 / 60 / 24; const availabilityText = await p.locator('.availability-date, [data-testid="availability-end-date"], [data-test-selector="availability-end-date"]').first().innerText().catch(() => dueDateOrg); console.log(' ', availabilityText, '->', daysLeft.toFixed(2)); if (isNew) await p.close(); return daysLeft > cfg.pg_timeLeft; - } + }; console.log('\nNumber of free unclaimed games (Prime Gaming):', internal.length); // claim games in internal store for (const card of internal) { @@ -353,12 +353,16 @@ try { try { await c.waitFor({ state: 'visible', timeout: 5000 }); if (!await c.isEnabled()) { - await c.evaluate(el => { el.disabled = false; el.removeAttribute('disabled'); el.click(); }); + await c.evaluate(el => { + el.disabled = false; + el.removeAttribute('disabled'); + el.click(); + }); } else { await c.click(); } return true; - } catch (_) { + } catch { // try next candidate } } @@ -375,7 +379,7 @@ try { continue; } await page.goto(url, { waitUntil: 'domcontentloaded' }); - await page.waitForSelector('[data-a-target="buy-box"]', { timeout: 10000 }).catch(_ => {}); + await page.waitForSelector('[data-a-target="buy-box"]', { timeout: 10000 }).catch(() => {}); if (cfg.debug) await page.pause(); let store = 'unknown'; const detailLoc = page.locator('[data-a-target="DescriptionItemDetails"], [data-testid="DescriptionItemDetails"]'); @@ -438,9 +442,9 @@ try { if (cfg.interactive && !await confirm()) continue; await clickCTA(page); await Promise.any([ - page.waitForSelector('.thank-you-title:has-text("Success")', { timeout: cfg.timeout }).catch(_ => {}), - page.waitForSelector('div:has-text("Link game account")', { timeout: cfg.timeout }).catch(_ => {}), - ]).catch(_ => {}); + page.waitForSelector('.thank-you-title:has-text("Success")', { timeout: cfg.timeout }).catch(() => {}), + page.waitForSelector('div:has-text("Link game account")', { timeout: cfg.timeout }).catch(() => {}), + ]).catch(() => {}); db.data[user][title] ||= { title, time: datetime(), url, store }; if (await page.locator('div:has-text("Link game account")').count() // TODO still needed? epic games store just has 'Link account' as the button text now. || await page.locator('div:has-text("Link account")').count()) { @@ -466,16 +470,16 @@ try { let code; try { // ensure CTA was clicked in case code is behind it - await clickCTA(page).catch(_ => {}); + await clickCTA(page).catch(() => {}); code = await Promise.any([ page.inputValue('input[type="text"]'), page.textContent('[data-a-target="ClaimStateClaimCodeContent"]').then(s => s.replace('Your code: ', '')), ]); - } catch (_) { + } catch { console.error(' Could not find claim code on page (timeout). Please check manually.'); db.data[user][title].status = 'claimed (code not found)'; notify_game.status = 'claimed (code not found)'; - await page.screenshot({ path: screenshot('external', `${filenamify(title)}_nocode.png`), fullPage: true }).catch(_ => {}); + await page.screenshot({ path: screenshot('external', `${filenamify(title)}_nocode.png`), fullPage: true }).catch(() => {}); continue; } console.log(' Code to redeem game:', chalk.blue(code)); @@ -563,7 +567,7 @@ try { if (j?.events?.cart.length && j.events.cart[0]?.data?.reason == 'UserAlreadyOwnsContent') { redeem_action = 'already redeemed'; console.error(' error: UserAlreadyOwnsContent'); - } else if (true) { // TODO what's returned on success? + } else { // TODO what's returned on success? redeem_action = 'redeemed'; db.data[user][title].status = 'claimed and redeemed?'; console.log(' Redeemed successfully? Please report if not in https://github.com/vogler/free-games-claimer/issues/5'); @@ -610,7 +614,7 @@ try { // await page.pause(); } await page.goto(URL_CLAIM, { waitUntil: 'domcontentloaded' }); - page.click('button[data-type="Game"]').catch(_ => {}); + page.click('button[data-type="Game"]').catch(() => {}); if (notify_games.length && games) { // make screenshot of all games if something was claimed and list exists const p = screenshot(`${filenamify(datetime())}.png`); @@ -628,7 +632,7 @@ try { await loot.waitFor(); process.stdout.write('Loading all DLCs on page...'); - await scrollUntilStable(() => loot.locator('[data-a-target="item-card"]').count()) + await scrollUntilStable(() => loot.locator('[data-a-target="item-card"]').count()); console.log('\nNumber of already claimed DLC:', await loot.locator('p:has-text("Collected")').count()); @@ -657,7 +661,7 @@ try { // most games have a button 'Get in-game content' // epic-games: Fall Guys: Claim -> Continue -> Go to Epic Games (despite account linked and logged into epic-games) -> not tied to account but via some cookie? await Promise.any([page.click('.tw-button:has-text("Get in-game content")'), page.click('.tw-button:has-text("Claim your gift")'), page.click('.tw-button:has-text("Claim")').then(() => page.click('button:has-text("Continue")'))]); - page.click('button:has-text("Continue")').catch(_ => { }); + page.click('button:has-text("Continue")').catch(() => { }); const linkAccountButton = page.locator('[data-a-target="LinkAccountButton"]'); let unlinked_store; if (await linkAccountButton.count()) { @@ -674,7 +678,7 @@ try { dlc_unlinked[unlinked_store] ??= []; dlc_unlinked[unlinked_store].push(title); } else { - const code = await page.inputValue('input[type="text"]').catch(_ => undefined); + const code = await page.inputValue('input[type="text"]').catch(() => undefined); console.log(' Code to redeem game:', chalk.blue(code)); db.data[user][title].code = code; db.data[user][title].status = 'claimed'; diff --git a/src/util.js b/src/util.js index 49424f8..8ba63a3 100644 --- a/src/util.js +++ b/src/util.js @@ -96,21 +96,21 @@ const timeoutPlugin = timeout => enquirer => { // cancel prompt after timeout ms prompt.hint = () => 'timeout'; prompt.cancel(); }, timeout); - prompt.on('submit', _ => clearTimeout(t)); - prompt.on('cancel', _ => clearTimeout(t)); + prompt.on('submit', () => clearTimeout(t)); + prompt.on('cancel', () => clearTimeout(t)); }); }; enquirer.use(timeoutPlugin(cfg.login_timeout)); // TODO may not want to have this timeout for all prompts; better extend Prompt and add a timeout prompt option // single prompt that just returns the non-empty value instead of an object // @ts-ignore -export const prompt = o => enquirer.prompt({ name: 'name', type: 'input', message: 'Enter value', ...o }).then(r => r.name).catch(_ => {}); +export const prompt = o => enquirer.prompt({ name: 'name', type: 'input', message: 'Enter value', ...o }).then(r => r.name).catch(() => {}); export const confirm = o => prompt({ type: 'confirm', message: 'Continue?', ...o }); // notifications via apprise CLI import { execFile } from 'child_process'; import { cfg } from './config.js'; -export const notify = html => new Promise((resolve, reject) => { +export const notify = html => new Promise(resolve => { if (!cfg.notify) { if (cfg.debug) console.debug('notify: NOTIFY is not set!'); return resolve(); diff --git a/steam-games.js b/steam-games.js index 9b307fc..ed54253 100644 --- a/steam-games.js +++ b/steam-games.js @@ -12,8 +12,8 @@ import { FingerprintInjector } from 'fingerprint-injector'; import { FingerprintGenerator } from 'fingerprint-generator'; const { fingerprint, headers } = new FingerprintGenerator().getFingerprint({ - devices: ["desktop"], - operatingSystems: ["windows"], + devices: ['desktop'], + operatingSystems: ['windows'], }); const context = await firefox.launchPersistentContext(cfg.dir.browser, { @@ -22,11 +22,11 @@ const context = await firefox.launchPersistentContext(cfg.dir.browser, { locale: 'en-US', // ignore OS locale to be sure to have english text for locators -> done via /en in URL userAgent: fingerprint.navigator.userAgent, viewport: { - width: fingerprint.screen.width, - height: fingerprint.screen.height, + width: fingerprint.screen.width, + height: fingerprint.screen.height, }, extraHTTPHeaders: { - 'accept-language': headers['accept-language'], + 'accept-language': headers['accept-language'], }, }); // await stealth(context); diff --git a/test/sigint-enquirer-raw-keeps-running.js b/test/sigint-enquirer-raw-keeps-running.js index 23d9983..ccb3081 100644 --- a/test/sigint-enquirer-raw-keeps-running.js +++ b/test/sigint-enquirer-raw-keeps-running.js @@ -12,10 +12,10 @@ function onRawSIGINT(fn) { } }); } -console.log(1) +console.log(1); onRawSIGINT(() => { console.log('raw'); process.exit(1); }); -console.log(2) +console.log(2); // onRawSIGINT workaround for enquirer keeps the process from exiting here... diff --git a/test/sigint-enquirer-raw.js b/test/sigint-enquirer-raw.js index e6b538d..c85ee0d 100644 --- a/test/sigint-enquirer-raw.js +++ b/test/sigint-enquirer-raw.js @@ -7,19 +7,19 @@ import { prompt, handleSIGINT } from '../src/util.js'; // }); handleSIGINT(); -function onRawSIGINT(fn) { - const { stdin, stdout } = process; - stdin.setRawMode(true); - stdin.resume(); - stdin.on('data', data => { - const key = data.toString('utf-8'); - if (key === '\u0003') { // ctrl + c - fn(); - } else { - stdout.write(key); - } - }); -} +// function onRawSIGINT(fn) { +// const { stdin, stdout } = process; +// stdin.setRawMode(true); +// stdin.resume(); +// stdin.on('data', data => { +// const key = data.toString('utf-8'); +// if (key === '\u0003') { // ctrl + c +// fn(); +// } else { +// stdout.write(key); +// } +// }); +// } // onRawSIGINT(() => { // console.log('raw'); process.exit(1); // }); From 5b1d966c6e7569658ff9f5920a4ab383ce954905 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 12:40:06 +0000 Subject: [PATCH 14/47] =?UTF-8?q?=F0=9F=91=B7=20ci(build):=20enhance=20son?= =?UTF-8?q?ar=20scanner=20configuration?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - extract project key from properties file for dynamic setup - add projectBaseDir to sonar scanner command for accurate analysis --- .forgejo/workflows/build.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index 882e541..a251a62 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -33,6 +33,7 @@ jobs: SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} run: | + PROJECT_KEY=$(grep -E '^sonar.projectKey=' sonar-project.properties | cut -d= -f2 | tr -d '\r') docker run --rm \ -e SONAR_HOST_URL="$SONAR_HOST_URL" \ -e SONAR_TOKEN="$SONAR_TOKEN" \ @@ -41,7 +42,9 @@ jobs: sonarsource/sonar-scanner-cli \ sonar-scanner \ -Dsonar.host.url="$SONAR_HOST_URL" \ - -Dsonar.login="$SONAR_TOKEN" + -Dsonar.token="$SONAR_TOKEN" \ + -Dsonar.projectKey="${PROJECT_KEY:-free-games-claimer}" \ + -Dsonar.projectBaseDir=/usr/src docker: needs: [lint, sonar] From 56ca1f63d4a7894d79ad80d1736380d03ae732af Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 12:42:36 +0000 Subject: [PATCH 15/47] =?UTF-8?q?=F0=9F=91=B7=20ci(build):=20enhance=20son?= =?UTF-8?q?ar=20project=20key=20configuration?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - add SONAR_PROJECT_KEY environment variable for flexibility - fallback to default or file-based project key if not set --- .forgejo/workflows/build.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index a251a62..d2aa8e0 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -32,8 +32,13 @@ jobs: env: SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }} run: | - PROJECT_KEY=$(grep -E '^sonar.projectKey=' sonar-project.properties | cut -d= -f2 | tr -d '\r') + PROJECT_KEY="${SONAR_PROJECT_KEY}" + if [ -z "$PROJECT_KEY" ] && [ -f sonar-project.properties ]; then + PROJECT_KEY=$(grep -E '^sonar.projectKey=' sonar-project.properties | cut -d= -f2 | tr -d '\r') + fi + PROJECT_KEY=${PROJECT_KEY:-free-games-claimer} docker run --rm \ -e SONAR_HOST_URL="$SONAR_HOST_URL" \ -e SONAR_TOKEN="$SONAR_TOKEN" \ From 8626fa5a0f856c66c9cc5b16ad71ef1db80864e2 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 12:57:44 +0000 Subject: [PATCH 16/47] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20refactor(build):=20e?= =?UTF-8?q?nhance=20sonar=20scanner=20configuration?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - set default host url for sonar scanner to ensure consistency - add sonar.sources and sonar.scm.provider for improved analysis --- .forgejo/workflows/build.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index d2aa8e0..501cf33 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -34,21 +34,24 @@ jobs: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }} run: | + HOST_URL=${SONAR_HOST_URL:-https://sonata.cyber77.de} PROJECT_KEY="${SONAR_PROJECT_KEY}" if [ -z "$PROJECT_KEY" ] && [ -f sonar-project.properties ]; then PROJECT_KEY=$(grep -E '^sonar.projectKey=' sonar-project.properties | cut -d= -f2 | tr -d '\r') fi PROJECT_KEY=${PROJECT_KEY:-free-games-claimer} docker run --rm \ - -e SONAR_HOST_URL="$SONAR_HOST_URL" \ + -e SONAR_HOST_URL="$HOST_URL" \ -e SONAR_TOKEN="$SONAR_TOKEN" \ -v "$PWD:/usr/src" \ -w /usr/src \ sonarsource/sonar-scanner-cli \ sonar-scanner \ - -Dsonar.host.url="$SONAR_HOST_URL" \ + -Dsonar.host.url="$HOST_URL" \ -Dsonar.token="$SONAR_TOKEN" \ -Dsonar.projectKey="${PROJECT_KEY:-free-games-claimer}" \ + -Dsonar.sources=. \ + -Dsonar.scm.provider=git \ -Dsonar.projectBaseDir=/usr/src docker: From e11d40bdda5f2628229ec3456ac3faad77ecc1e8 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 13:01:14 +0000 Subject: [PATCH 17/47] =?UTF-8?q?=F0=9F=91=B7=20ci(build):=20enforce=20son?= =?UTF-8?q?ar=20host=20url=20secret=20presence?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - update HOST_URL to require SONAR_HOST_URL secret for enhanced security configuration - improve error handling by ensuring critical secrets are set --- .forgejo/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index 501cf33..b1cbd6d 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -34,7 +34,7 @@ jobs: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }} run: | - HOST_URL=${SONAR_HOST_URL:-https://sonata.cyber77.de} + HOST_URL=${SONAR_HOST_URL:?SONAR_HOST_URL secret not set} PROJECT_KEY="${SONAR_PROJECT_KEY}" if [ -z "$PROJECT_KEY" ] && [ -f sonar-project.properties ]; then PROJECT_KEY=$(grep -E '^sonar.projectKey=' sonar-project.properties | cut -d= -f2 | tr -d '\r') From 608b6b87cdce748043cc17b36fdd1846f9a64972 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 13:02:52 +0000 Subject: [PATCH 18/47] =?UTF-8?q?=F0=9F=91=B7=20ci(build):=20simplify=20so?= =?UTF-8?q?nar=20project=20key=20retrieval?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - remove redundant conditional logic for project key extraction - enforce mandatory SONAR_PROJECT_KEY secret for consistency - change sonar.scm.provider to 'none' for improved configuration --- .forgejo/workflows/build.yml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index b1cbd6d..a2e5c5e 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -35,11 +35,7 @@ jobs: SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }} run: | HOST_URL=${SONAR_HOST_URL:?SONAR_HOST_URL secret not set} - PROJECT_KEY="${SONAR_PROJECT_KEY}" - if [ -z "$PROJECT_KEY" ] && [ -f sonar-project.properties ]; then - PROJECT_KEY=$(grep -E '^sonar.projectKey=' sonar-project.properties | cut -d= -f2 | tr -d '\r') - fi - PROJECT_KEY=${PROJECT_KEY:-free-games-claimer} + PROJECT_KEY=${SONAR_PROJECT_KEY:?SONAR_PROJECT_KEY secret not set} docker run --rm \ -e SONAR_HOST_URL="$HOST_URL" \ -e SONAR_TOKEN="$SONAR_TOKEN" \ @@ -49,9 +45,9 @@ jobs: sonar-scanner \ -Dsonar.host.url="$HOST_URL" \ -Dsonar.token="$SONAR_TOKEN" \ - -Dsonar.projectKey="${PROJECT_KEY:-free-games-claimer}" \ + -Dsonar.projectKey="$PROJECT_KEY" \ -Dsonar.sources=. \ - -Dsonar.scm.provider=git \ + -Dsonar.scm.provider=none \ -Dsonar.projectBaseDir=/usr/src docker: From 02972a04d46978da59adf6d9de6f1a9f65611d26 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 13:05:40 +0000 Subject: [PATCH 19/47] =?UTF-8?q?=F0=9F=90=9B=20fix(ci):=20handle=20missin?= =?UTF-8?q?g=20sonar=20project=20key=20gracefully?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - set default empty value for PROJECT_KEY variable - add fallback to read sonar-project.properties if secret is not provided - exit with error if PROJECT_KEY is still unset after checks --- .forgejo/workflows/build.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index a2e5c5e..636aff9 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -35,7 +35,14 @@ jobs: SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }} run: | HOST_URL=${SONAR_HOST_URL:?SONAR_HOST_URL secret not set} - PROJECT_KEY=${SONAR_PROJECT_KEY:?SONAR_PROJECT_KEY secret not set} + PROJECT_KEY=${SONAR_PROJECT_KEY:-} + if [ -z "$PROJECT_KEY" ] && [ -f sonar-project.properties ]; then + PROJECT_KEY=$(grep -E '^sonar.projectKey=' sonar-project.properties | cut -d= -f2 | tr -d '\r') + fi + if [ -z "$PROJECT_KEY" ]; then + echo "SONAR_PROJECT_KEY secret not set and no sonar-project.properties entry found" >&2 + exit 1 + fi docker run --rm \ -e SONAR_HOST_URL="$HOST_URL" \ -e SONAR_TOKEN="$SONAR_TOKEN" \ @@ -44,7 +51,6 @@ jobs: sonarsource/sonar-scanner-cli \ sonar-scanner \ -Dsonar.host.url="$HOST_URL" \ - -Dsonar.token="$SONAR_TOKEN" \ -Dsonar.projectKey="$PROJECT_KEY" \ -Dsonar.sources=. \ -Dsonar.scm.provider=none \ From 405660e0f2def741f7029a61f23f3081234d6f52 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 13:06:49 +0000 Subject: [PATCH 20/47] =?UTF-8?q?=F0=9F=90=9B=20fix(ci):=20adjust=20sonar?= =?UTF-8?q?=20scm=20configuration?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - change sonar.scm.provider to sonar.scm.disabled for compatibility --- .forgejo/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index 636aff9..31abf10 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -53,7 +53,7 @@ jobs: -Dsonar.host.url="$HOST_URL" \ -Dsonar.projectKey="$PROJECT_KEY" \ -Dsonar.sources=. \ - -Dsonar.scm.provider=none \ + -Dsonar.scm.disabled=true \ -Dsonar.projectBaseDir=/usr/src docker: From 6c4eb948fc2a2d6976f2f318375092b59485a0fe Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 13:08:44 +0000 Subject: [PATCH 21/47] alles jut --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 248995e..a8fae1f 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,8 @@ Free Games Claimer (Fork) ========================== +[![Quality Gate Status](https://sonata.cyber77.de/api/project_badges/measure?project=free-games-claimer&metric=alert_status&token=sqb_99c83edf82a1331f0c649f8a5b698b4ec8f9a965)](https://sonata.cyber77.de/dashboard?id=free-games-claimer) + Automates claiming of free games for: - Amazon Luna Gaming / Luna claims (including external stores like GOG, Epic Games, Legacy Games ) - GOG giveaways From 25fb2d983812044cd341cd3441dc827b56aed46b Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 13:19:36 +0000 Subject: [PATCH 22/47] chore: remove github workflows and configs --- .github/FUNDING.yml | 13 ------- .github/dependabot.yml | 28 -------------- .github/renovate.json | 7 ---- .github/workflows/docker.yml | 72 ------------------------------------ .github/workflows/lint.yml | 36 ------------------ .github/workflows/sonar.yml | 42 --------------------- 6 files changed, 198 deletions(-) delete mode 100644 .github/FUNDING.yml delete mode 100644 .github/dependabot.yml delete mode 100644 .github/renovate.json delete mode 100644 .github/workflows/docker.yml delete mode 100644 .github/workflows/lint.yml delete mode 100644 .github/workflows/sonar.yml diff --git a/.github/FUNDING.yml b/.github/FUNDING.yml deleted file mode 100644 index 9a0d965..0000000 --- a/.github/FUNDING.yml +++ /dev/null @@ -1,13 +0,0 @@ -# These are supported funding model platforms - -github: vogler # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2] -patreon: fgc # Replace with a single Patreon username -open_collective: # Replace with a single Open Collective username -ko_fi: vogler # Replace with a single Ko-fi username -tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel -community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry -liberapay: vogler # Replace with a single Liberapay username -issuehunt: # Replace with a single IssueHunt username -otechie: # Replace with a single Otechie username -lfx_crowdfunding: # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry -custom: ["https://www.buymeacoffee.com/vogler", "https://paypal.me/voglerr"] # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2'] diff --git a/.github/dependabot.yml b/.github/dependabot.yml deleted file mode 100644 index 1b47972..0000000 --- a/.github/dependabot.yml +++ /dev/null @@ -1,28 +0,0 @@ -# To get started with Dependabot version updates, you'll need to specify which -# package ecosystems to update and where the package manifests are located. -# Please see the documentation for all configuration options: -# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates - -version: 2 -updates: - - package-ecosystem: "npm" - directory: "/" - schedule: - interval: "weekly" - # commit-message: - # prefix: "npm" - # include: "scope" - - package-ecosystem: "docker" - directory: "/" - schedule: - interval: "weekly" - # commit-message: - # prefix: "docker" - # include: "scope" - - package-ecosystem: "github-actions" - directory: "/" - schedule: - interval: "weekly" - # commit-message: - # prefix: "github-actions" - # include: "scope" diff --git a/.github/renovate.json b/.github/renovate.json deleted file mode 100644 index ecfd5ff..0000000 --- a/.github/renovate.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "$schema": "https://docs.renovatebot.com/renovate-schema.json", - "enabled": false, - "extends": [ - "config:recommended" - ] -} diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml deleted file mode 100644 index 8c12487..0000000 --- a/.github/workflows/docker.yml +++ /dev/null @@ -1,72 +0,0 @@ -name: Build and push Docker image (amd64, arm64 to hub.docker.com and ghcr.io) - -on: - workflow_dispatch: # allows manual trigger - push: # push on branch - branches: [main, dev] - paths: # ignore changes to .md files - - '**' - - '!*.md' - # - '!.github/**' - pull_request: # runs when opened/reopned or when the head branch is updated - -permissions: - contents: read - packages: write - -env: - BRANCH: ${{ github.head_ref || github.ref_name }} # head_ref/base_ref are only set for PRs, for branches ref_name will be used - -jobs: - docker: - runs-on: ubuntu-latest - steps: - - - name: Checkout - uses: actions/checkout@v4 - - - name: Set environment variables - run: | - echo "NOW=$(date -R)" >> $GITHUB_ENV # date -Iseconds; date +'%Y-%m-%dT%H:%M:%S' - if [[ "$BRANCH" == "main" ]]; then - echo "IMAGE_TAG=latest" >> $GITHUB_ENV - else - echo "IMAGE_TAG=$BRANCH" >> $GITHUB_ENV - fi - - - name: Set up QEMU - uses: docker/setup-qemu-action@v3 - - - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v3 - - - name: Login to Docker Hub - uses: docker/login-action@v3 - # if: ${{ secrets.DOCKERHUB_USERNAME != '' && secrets.DOCKERHUB_TOKEN != '' }} # does not work: Unrecognized named-value: 'secrets' - https://www.cloudtruth.com/blog/skipping-jobs-in-github-actions-when-secrets-are-unavailable-securely-inject-configuration-secrets-into-github - with: - username: ${{ secrets.DOCKERHUB_USERNAME }} - password: ${{ secrets.DOCKERHUB_TOKEN }} - - - name: Login to GitHub Container Registry - uses: docker/login-action@v3 - with: - registry: ghcr.io - username: ${{ github.actor }} # actor is user that opened PR, was repository_owner before - password: ${{ secrets.GITHUB_TOKEN }} - - - name: Build and push - uses: docker/build-push-action@v6 - if: ${{ env.IMAGE_TAG != '' }} - with: - context: . - push: ${{ secrets.DOCKERHUB_USERNAME != '' }} - build-args: | - COMMIT=${{ github.sha }} - BRANCH=${{ env.BRANCH }} - NOW=${{ env.NOW }} - platforms: linux/amd64,linux/arm64 - tags: | - ${{ secrets.DOCKERHUB_USERNAME }}/free-games-claimer:${{env.IMAGE_TAG}} - ghcr.io/${{ github.actor }}/free-games-claimer:${{env.IMAGE_TAG}} - cache-from: type=gha - cache-to: type=gha,mode=max diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml deleted file mode 100644 index 02ca3cb..0000000 --- a/.github/workflows/lint.yml +++ /dev/null @@ -1,36 +0,0 @@ -# https://github.com/marketplace/actions/super-linter#get-started -name: Lint - -on: # yamllint disable-line rule:truthy - push: null - pull_request: null - -permissions: {} - -jobs: - lint: - name: Lint - runs-on: ubuntu-latest - - permissions: - contents: read - packages: read - # To report GitHub Actions status checks - statuses: write - - steps: - - name: Checkout code - uses: actions/checkout@v4 - with: - # super-linter needs the full git history to get the - # list of files that changed across commits - fetch-depth: 0 - - - name: Super-linter - uses: super-linter/super-linter/slim@v7.4.0 # x-release-please-version - # TODO need to create problem matchers for each linter? https://github.com/rhysd/actionlint/blob/v1.7.7/docs/usage.md#problem-matchers - env: - # To report GitHub Actions status checks - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - # TODO automatically fix linting issues and commit them for PRs - # fix-lint-issues: # https://github.com/marketplace/actions/super-linter#github-actions-workflow-example-pull-request diff --git a/.github/workflows/sonar.yml b/.github/workflows/sonar.yml deleted file mode 100644 index 29f81c6..0000000 --- a/.github/workflows/sonar.yml +++ /dev/null @@ -1,42 +0,0 @@ -name: Sonar - -on: - # Trigger analysis when pushing in main or pull requests, and when creating a pull request. - push: - branches: - - main - pull_request: - types: [opened, synchronize, reopened] - -permissions: - contents: read - -jobs: - sonarcloud: - runs-on: ubuntu-latest - steps: - - - uses: actions/checkout@v4 - with: - # Disabling shallow clone is recommended for improving relevancy of reporting. Otherwise sonarcloud will show a warning. - fetch-depth: 0 - - - uses: actions/setup-node@v4 - with: - cache: 'npm' - - - name: Install dev dependencies which includde ESLint + plugins - run: npm install --only=dev - - - name: Run ESLint - continue-on-error: true - run: npx eslint . -f json -o eslint_report.json - - - name: Fix ESLint paths - run: sed -i 's+/home/runner/work/free-games-claimer/free-games-claimer+/github/workspace+g' eslint_report.json - - - name: SonarCloud Scan - uses: sonarsource/sonarcloud-github-action@master - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} From 2a4653062a9664ae836ce521a63d9efd319bda58 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 13:22:54 +0000 Subject: [PATCH 23/47] ci: make sonar scan pick up sources --- .forgejo/workflows/build.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index 31abf10..f90d5ef 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -43,6 +43,11 @@ jobs: echo "SONAR_PROJECT_KEY secret not set and no sonar-project.properties entry found" >&2 exit 1 fi + echo "Sonar project key: $PROJECT_KEY" + echo "Listing workspace:" + ls -la + echo "Sample files:" + find . -maxdepth 2 -type f | head -n 20 docker run --rm \ -e SONAR_HOST_URL="$HOST_URL" \ -e SONAR_TOKEN="$SONAR_TOKEN" \ @@ -53,6 +58,7 @@ jobs: -Dsonar.host.url="$HOST_URL" \ -Dsonar.projectKey="$PROJECT_KEY" \ -Dsonar.sources=. \ + -Dsonar.inclusions=**/*.js \ -Dsonar.scm.disabled=true \ -Dsonar.projectBaseDir=/usr/src From 00b36a65b1a921c158357ff04a8193ac9cf36a44 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 13:25:17 +0000 Subject: [PATCH 24/47] ci: quote sonar inclusions to avoid shell glob --- .forgejo/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index f90d5ef..e37f5bf 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -58,7 +58,7 @@ jobs: -Dsonar.host.url="$HOST_URL" \ -Dsonar.projectKey="$PROJECT_KEY" \ -Dsonar.sources=. \ - -Dsonar.inclusions=**/*.js \ + "-Dsonar.inclusions=**/*.js" \ -Dsonar.scm.disabled=true \ -Dsonar.projectBaseDir=/usr/src From 94be980c955b44339e0898bebce31c0c6b50accb Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 14:22:07 +0000 Subject: [PATCH 25/47] ci: debug sonar scanner mount and remove extra inclusions --- .forgejo/workflows/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index e37f5bf..e229218 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -48,6 +48,8 @@ jobs: ls -la echo "Sample files:" find . -maxdepth 2 -type f | head -n 20 + echo "Check files inside scanner container:" + docker run --rm -v "$PWD:/usr/src" -w /usr/src alpine sh -c "ls -la /usr/src | head && find /usr/src -maxdepth 2 -type f -name '*.js' | head -n 20" docker run --rm \ -e SONAR_HOST_URL="$HOST_URL" \ -e SONAR_TOKEN="$SONAR_TOKEN" \ @@ -58,7 +60,6 @@ jobs: -Dsonar.host.url="$HOST_URL" \ -Dsonar.projectKey="$PROJECT_KEY" \ -Dsonar.sources=. \ - "-Dsonar.inclusions=**/*.js" \ -Dsonar.scm.disabled=true \ -Dsonar.projectBaseDir=/usr/src From b5e9111039af8d7968edd5d0d8d9d2cd476ec6d6 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 14:23:43 +0000 Subject: [PATCH 26/47] ci: mount workspace explicitly for sonar scanner --- .forgejo/workflows/build.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index e229218..e7abefc 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -34,6 +34,7 @@ jobs: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }} run: | + WORKDIR=${GITHUB_WORKSPACE:-$PWD} HOST_URL=${SONAR_HOST_URL:?SONAR_HOST_URL secret not set} PROJECT_KEY=${SONAR_PROJECT_KEY:-} if [ -z "$PROJECT_KEY" ] && [ -f sonar-project.properties ]; then @@ -49,19 +50,19 @@ jobs: echo "Sample files:" find . -maxdepth 2 -type f | head -n 20 echo "Check files inside scanner container:" - docker run --rm -v "$PWD:/usr/src" -w /usr/src alpine sh -c "ls -la /usr/src | head && find /usr/src -maxdepth 2 -type f -name '*.js' | head -n 20" + docker run --rm -v "$WORKDIR:/project" -w /project alpine sh -c "pwd; ls -la . | head && find . -maxdepth 2 -type f -name '*.js' | head -n 20" docker run --rm \ -e SONAR_HOST_URL="$HOST_URL" \ -e SONAR_TOKEN="$SONAR_TOKEN" \ - -v "$PWD:/usr/src" \ - -w /usr/src \ + -v "$WORKDIR:/project" \ + -w /project \ sonarsource/sonar-scanner-cli \ sonar-scanner \ -Dsonar.host.url="$HOST_URL" \ -Dsonar.projectKey="$PROJECT_KEY" \ -Dsonar.sources=. \ -Dsonar.scm.disabled=true \ - -Dsonar.projectBaseDir=/usr/src + -Dsonar.projectBaseDir=/project docker: needs: [lint, sonar] From f82c158a6b0b5d49046c7abfdb33572057e84ea2 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 14:27:12 +0000 Subject: [PATCH 27/47] ci: run sonar-scanner locally instead of docker --- .forgejo/workflows/build.yml | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index e7abefc..5c14708 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -28,6 +28,12 @@ jobs: uses: actions/checkout@v4 with: fetch-depth: 0 + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version: 20 + - name: Install Sonar Scanner (npm) + run: npm install -g sonarqube-scanner - name: SonarQube Scan env: SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }} @@ -49,20 +55,14 @@ jobs: ls -la echo "Sample files:" find . -maxdepth 2 -type f | head -n 20 - echo "Check files inside scanner container:" - docker run --rm -v "$WORKDIR:/project" -w /project alpine sh -c "pwd; ls -la . | head && find . -maxdepth 2 -type f -name '*.js' | head -n 20" - docker run --rm \ - -e SONAR_HOST_URL="$HOST_URL" \ - -e SONAR_TOKEN="$SONAR_TOKEN" \ - -v "$WORKDIR:/project" \ - -w /project \ - sonarsource/sonar-scanner-cli \ - sonar-scanner \ - -Dsonar.host.url="$HOST_URL" \ - -Dsonar.projectKey="$PROJECT_KEY" \ - -Dsonar.sources=. \ - -Dsonar.scm.disabled=true \ - -Dsonar.projectBaseDir=/project + echo "Running local sonar-scanner..." + sonar-scanner \ + -Dsonar.host.url="$HOST_URL" \ + -Dsonar.login="$SONAR_TOKEN" \ + -Dsonar.projectKey="$PROJECT_KEY" \ + -Dsonar.sources=. \ + -Dsonar.scm.disabled=true \ + -Dsonar.projectBaseDir="$WORKDIR" docker: needs: [lint, sonar] From e4b1f60a662895d98b70a929b04e41df81dd2ed1 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 14:31:17 +0000 Subject: [PATCH 28/47] chore: use execFile for git commands in version check --- src/version.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/version.js b/src/version.js index bfcd12a..cd054d8 100644 --- a/src/version.js +++ b/src/version.js @@ -1,15 +1,15 @@ // check if running the latest version import { log } from 'console'; -import { exec } from 'child_process'; +import { execFile } from 'child_process'; -const execp = cmd => new Promise((resolve, reject) => { - exec(cmd, (error, stdout, stderr) => { +const runGit = (...args) => new Promise((resolve, reject) => { + execFile('git', args, { cwd: process.cwd() }, (error, stdout, stderr) => { if (stderr) console.error(`stderr: ${stderr}`); // if (stdout) console.log(`stdout: ${stdout}`); if (error) { console.log(`error: ${error.message}`); - if (error.message.includes('command not found')) { + if (error.code === 'ENOENT' || error.message.includes('command not found')) { console.info('Install git to check for updates!'); } return reject(error); @@ -29,8 +29,8 @@ if (process.env.NOVNC_PORT) { date = process.env.NOW; } else { log('Not running inside Docker.'); - sha = await execp('git rev-parse HEAD'); - date = await execp('git show -s --format=%cD'); // same as format as `date -R` (RFC2822) + sha = await runGit('rev-parse', 'HEAD'); + date = await runGit('show', '-s', '--format=%cD'); // same as format as `date -R` (RFC2822) // date = await execp('git show -s --format=%ch'); // %ch is same as --date=human (short/relative) } From 9e2bc89ff23a65a7a7b4b1d6df8683c51e46e025 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 14:36:41 +0000 Subject: [PATCH 29/47] chore: clean up util notify/prompt lint findings --- src/util.js | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/src/util.js b/src/util.js index 8ba63a3..0709e21 100644 --- a/src/util.js +++ b/src/util.js @@ -19,7 +19,9 @@ export const delay = ms => new Promise(resolve => setTimeout(resolve, ms)); export const datetimeUTC = (d = new Date()) => d.toISOString().replace('T', ' ').replace('Z', ''); // same as datetimeUTC() but for local timezone, e.g., UTC + 2h for the above in DE export const datetime = (d = new Date()) => datetimeUTC(new Date(d.getTime() - d.getTimezoneOffset() * 60000)); -export const filenamify = s => s.replaceAll(':', '.').replace(/[^a-z0-9 _\-.]/gi, '_'); // alternative: https://www.npmjs.com/package/filenamify - On Unix-like systems, / is reserved. On Windows, <>:"/\|?* along with trailing periods are reserved. +export const filenamify = s => s + .replaceAll(':', '.') + .replaceAll(/[^a-z0-9 _\-.]/gi, '_'); // alternative: https://www.npmjs.com/package/filenamify - On Unix-like systems, / is reserved. On Windows, <>:"/\|?* along with trailing periods are reserved. export const handleSIGINT = (context = null) => process.on('SIGINT', async () => { // e.g. when killed by Ctrl-C console.error('\nInterrupted by SIGINT. Exit!'); // Exception shows where the script was:\n'); // killed before catch in docker... @@ -90,24 +92,28 @@ export const stealth = async context => { // alternative inquirer is big (node_modules 29MB, enquirer 9.7MB, prompts 9.8MB, none 9.4MB) and slower // open issue: prevents handleSIGINT() to work if prompt is cancelled with Ctrl-C instead of Escape: https://github.com/enquirer/enquirer/issues/372 import Enquirer from 'enquirer'; const enquirer = new Enquirer(); -const timeoutPlugin = timeout => enquirer => { // cancel prompt after timeout ms - enquirer.on('prompt', prompt => { +const timeoutPlugin = defaultTimeout => enquirer => { // cancel prompt after timeout ms; can be disabled per prompt via options.timeout = 0 + const onPrompt = prompt => { + const effectiveTimeout = prompt.options?.timeout ?? defaultTimeout; + if (!effectiveTimeout) return; const t = setTimeout(() => { prompt.hint = () => 'timeout'; prompt.cancel(); - }, timeout); - prompt.on('submit', () => clearTimeout(t)); - prompt.on('cancel', () => clearTimeout(t)); - }); + }, effectiveTimeout); + const clear = () => clearTimeout(t); + prompt.on('submit', clear); + prompt.on('cancel', clear); + }; + enquirer.on('prompt', onPrompt); }; -enquirer.use(timeoutPlugin(cfg.login_timeout)); // TODO may not want to have this timeout for all prompts; better extend Prompt and add a timeout prompt option +enquirer.use(timeoutPlugin(cfg.login_timeout)); // single prompt that just returns the non-empty value instead of an object // @ts-ignore export const prompt = o => enquirer.prompt({ name: 'name', type: 'input', message: 'Enter value', ...o }).then(r => r.name).catch(() => {}); export const confirm = o => prompt({ type: 'confirm', message: 'Continue?', ...o }); // notifications via apprise CLI -import { execFile } from 'child_process'; +import { execFile } from 'node:child_process'; import { cfg } from './config.js'; export const notify = html => new Promise(resolve => { @@ -115,10 +121,9 @@ export const notify = html => new Promise(resolve => { if (cfg.debug) console.debug('notify: NOTIFY is not set!'); return resolve(); } - // const cmd = `apprise '${cfg.notify}' ${title} -i html -b '${html}'`; // this had problems if e.g. ' was used in arg; could have `npm i shell-escape`, but instead using safer execFile which takes args as array instead of exec which spawned a shell to execute the command const args = [cfg.notify, '-i', 'html', '-b', `'${html}'`]; - if (cfg.notify_title) args.push(...['-t', cfg.notify_title]); - if (cfg.debug) console.debug(`apprise ${args.map(a => `'${a}'`).join(' ')}`); // this also doesn't escape, but it's just for info + if (cfg.notify_title) args.push('-t', cfg.notify_title); + if (cfg.debug) console.debug(`apprise ${args.join(' ')}`); // this also doesn't escape, but it's just for info execFile('apprise', args, (error, stdout, stderr) => { if (error) { console.log(`error: ${error.message}`); From 69282c63d5f38b020e4de89404b381f44239fa35 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 14:54:14 +0000 Subject: [PATCH 30/47] Address Sonar warnings and harden runtime --- Dockerfile | 17 ++++++++++++++--- aliexpress.js | 2 +- prime-gaming.js | 4 +++- src/util.js | 5 +++-- src/version.js | 6 ++++-- 5 files changed, 25 insertions(+), 9 deletions(-) diff --git a/Dockerfile b/Dockerfile index a8c5e24..bd737ae 100644 --- a/Dockerfile +++ b/Dockerfile @@ -45,6 +45,8 @@ RUN apt-get update \ /var/lib/apt/lists/* \ /var/tmp/* +RUN useradd -ms /bin/bash fgc + # RUN node --version # RUN npm --version @@ -61,10 +63,16 @@ RUN npm install # From 1.38 Playwright will no longer install browser automatically for playwright, but apparently still for playwright-firefox: https://github.com/microsoft/playwright/releases/tag/v1.38.0 # RUN npx playwright install firefox -COPY . . +# Only copy the files we actually need in the image to avoid accidentally adding secrets. +COPY *.js ./ +COPY eslint.config.js jsconfig.json sonar-project.properties ./ +COPY src ./src +COPY test ./test +COPY docker-entrypoint.sh ./ # Shell scripts need Linux line endings. On Windows, git might be configured to check out dos/CRLF line endings, so we convert them for those people in case they want to build the image. They could also use --config core.autocrlf=input RUN dos2unix ./*.sh && chmod +x ./*.sh +RUN chown -R fgc:fgc /fgc COPY docker-entrypoint.sh /usr/local/bin/ ARG COMMIT="" @@ -87,8 +95,9 @@ LABEL org.opencontainers.image.title="free-games-claimer" \ # Configure VNC via environment variables: ENV VNC_PORT 5900 ENV NOVNC_PORT 6080 -EXPOSE 5900 -EXPOSE 6080 +# Ports are not exposed by default; publish explicitly with -p when you really need GUI access. +# EXPOSE 5900 +# EXPOSE 6080 # Configure Xvfb via environment variables: ENV WIDTH 1920 @@ -98,6 +107,8 @@ ENV DEPTH 24 # Show browser instead of running headless ENV SHOW 1 +USER fgc + # Script to setup display server & VNC is always executed. ENTRYPOINT ["docker-entrypoint.sh"] # Default command to run. This is replaced by appending own command, e.g. `docker run ... node prime-gaming` to only run this script. diff --git a/aliexpress.js b/aliexpress.js index 6d654d3..f10dc46 100644 --- a/aliexpress.js +++ b/aliexpress.js @@ -40,7 +40,7 @@ const auth = async url => { console.log('auth', url); await page.goto(url, { waitUntil: 'domcontentloaded' }); // redirects to https://login.aliexpress.com/?return_url=https%3A%2F%2Fwww.aliexpress.com%2Fp%2Fcoin-pc-index%2Findex.html - await Promise.any([page.waitForURL(/.*login\.aliexpress.com.*/).then(async () => { + await Promise.any([page.waitForURL(url => url.includes('login.aliexpress.com')).then(async () => { // manual login console.error('Not logged in! Will wait for 120s for you to login...'); // await page.waitForTimeout(120*1000); diff --git a/prime-gaming.js b/prime-gaming.js index 0c982bd..00e8466 100644 --- a/prime-gaming.js +++ b/prime-gaming.js @@ -385,7 +385,9 @@ try { const detailLoc = page.locator('[data-a-target="DescriptionItemDetails"], [data-testid="DescriptionItemDetails"]'); if (await detailLoc.count()) { const item_text = await detailLoc.first().innerText(); - store = item_text.toLowerCase().replace(/.* on /, '').slice(0, -1); + const lower = item_text.toLowerCase(); + const onPos = lower.lastIndexOf(' on '); + if (onPos >= 0) store = lower.slice(onPos + 4).replace(/[.!]$/, ''); } else if (url.includes('/claims/')) { const slug = url.split('/claims/')[1]?.split('/')[0] || ''; if (slug.includes('gog')) store = 'gog.com'; diff --git a/src/util.js b/src/util.js index 0709e21..df6a29a 100644 --- a/src/util.js +++ b/src/util.js @@ -121,10 +121,11 @@ export const notify = html => new Promise(resolve => { if (cfg.debug) console.debug('notify: NOTIFY is not set!'); return resolve(); } + const appriseBin = process.env.APPRISE_BIN || '/usr/local/bin/apprise'; const args = [cfg.notify, '-i', 'html', '-b', `'${html}'`]; if (cfg.notify_title) args.push('-t', cfg.notify_title); - if (cfg.debug) console.debug(`apprise ${args.join(' ')}`); // this also doesn't escape, but it's just for info - execFile('apprise', args, (error, stdout, stderr) => { + if (cfg.debug) console.debug(`${appriseBin} ${args.join(' ')}`); // this also doesn't escape, but it's just for info + execFile(appriseBin, args, (error, stdout, stderr) => { if (error) { console.log(`error: ${error.message}`); if (error.message.includes('command not found')) { diff --git a/src/version.js b/src/version.js index cd054d8..b5cf838 100644 --- a/src/version.js +++ b/src/version.js @@ -1,10 +1,12 @@ // check if running the latest version import { log } from 'console'; -import { execFile } from 'child_process'; +import { execFile } from 'node:child_process'; + +const gitBin = process.env.GIT_BIN || '/usr/bin/git'; const runGit = (...args) => new Promise((resolve, reject) => { - execFile('git', args, { cwd: process.cwd() }, (error, stdout, stderr) => { + execFile(gitBin, args, { cwd: process.cwd() }, (error, stdout, stderr) => { if (stderr) console.error(`stderr: ${stderr}`); // if (stdout) console.log(`stdout: ${stdout}`); if (error) { From 37ffd0954526b204735a150f637d7d2732c94f88 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 14:56:50 +0000 Subject: [PATCH 31/47] Refactor prompt timeout plugin to reduce nesting --- src/util.js | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/src/util.js b/src/util.js index df6a29a..dab047f 100644 --- a/src/util.js +++ b/src/util.js @@ -92,19 +92,22 @@ export const stealth = async context => { // alternative inquirer is big (node_modules 29MB, enquirer 9.7MB, prompts 9.8MB, none 9.4MB) and slower // open issue: prevents handleSIGINT() to work if prompt is cancelled with Ctrl-C instead of Escape: https://github.com/enquirer/enquirer/issues/372 import Enquirer from 'enquirer'; const enquirer = new Enquirer(); -const timeoutPlugin = defaultTimeout => enquirer => { // cancel prompt after timeout ms; can be disabled per prompt via options.timeout = 0 - const onPrompt = prompt => { - const effectiveTimeout = prompt.options?.timeout ?? defaultTimeout; - if (!effectiveTimeout) return; - const t = setTimeout(() => { - prompt.hint = () => 'timeout'; - prompt.cancel(); - }, effectiveTimeout); - const clear = () => clearTimeout(t); - prompt.on('submit', clear); - prompt.on('cancel', clear); - }; - enquirer.on('prompt', onPrompt); +const timeoutHint = () => 'timeout'; +const cancelPromptWithHint = prompt => { + prompt.hint = timeoutHint; + prompt.cancel(); +}; +const applyPromptTimeout = (prompt, timeout) => { + if (!timeout) return; + const timer = setTimeout(cancelPromptWithHint, timeout, prompt); + const clearTimer = () => clearTimeout(timer); + prompt.on('submit', clearTimer); + prompt.on('cancel', clearTimer); +}; +// cancel prompt after timeout ms; can be disabled per prompt via options.timeout = 0 +const timeoutPlugin = defaultTimeout => enquirerInstance => { + const onPrompt = prompt => applyPromptTimeout(prompt, prompt.options?.timeout ?? defaultTimeout); + enquirerInstance.on('prompt', onPrompt); }; enquirer.use(timeoutPlugin(cfg.login_timeout)); // single prompt that just returns the non-empty value instead of an object From 405e80185140928bdecf2eb477876a7595cf8a5a Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 15:39:11 +0000 Subject: [PATCH 32/47] Clean Sonar findings: merge RUNs, drop commented code, update node imports --- Dockerfile | 10 ++++---- aliexpress.js | 17 -------------- epic-games.js | 4 ++-- src/migrate.js | 2 +- src/version.js | 18 ++------------- test/notify.js | 61 ++++++++++++++++++++++++++----------------------- unrealengine.js | 4 ++-- 7 files changed, 44 insertions(+), 72 deletions(-) diff --git a/Dockerfile b/Dockerfile index bd737ae..d5f53da 100644 --- a/Dockerfile +++ b/Dockerfile @@ -45,13 +45,12 @@ RUN apt-get update \ /var/lib/apt/lists/* \ /var/tmp/* -RUN useradd -ms /bin/bash fgc - # RUN node --version # RUN npm --version -RUN ln -s /usr/share/novnc/vnc_auto.html /usr/share/novnc/index.html -RUN pip install apprise +RUN useradd -ms /bin/bash fgc \ + && ln -s /usr/share/novnc/vnc_auto.html /usr/share/novnc/index.html \ + && pip install apprise WORKDIR /fgc COPY package*.json ./ @@ -71,8 +70,7 @@ COPY test ./test COPY docker-entrypoint.sh ./ # Shell scripts need Linux line endings. On Windows, git might be configured to check out dos/CRLF line endings, so we convert them for those people in case they want to build the image. They could also use --config core.autocrlf=input -RUN dos2unix ./*.sh && chmod +x ./*.sh -RUN chown -R fgc:fgc /fgc +RUN dos2unix ./*.sh && chmod +x ./*.sh && chown -R fgc:fgc /fgc COPY docker-entrypoint.sh /usr/local/bin/ ARG COMMIT="" diff --git a/aliexpress.js b/aliexpress.js index f10dc46..a28cf8a 100644 --- a/aliexpress.js +++ b/aliexpress.js @@ -14,7 +14,6 @@ const { fingerprint, headers } = new FingerprintGenerator().getFingerprint({ const context = await firefox.launchPersistentContext(cfg.dir.browser, { headless: cfg.headless, - // viewport: { width: cfg.width, height: cfg.height }, locale: 'en-US', // ignore OS locale to be sure to have english text for locators -> done via /en in URL recordVideo: cfg.record ? { dir: 'data/record/', size: { width: cfg.width, height: cfg.height } } : undefined, // will record a .webm video for each page navigated; without size, video would be scaled down to fit 800x800 recordHar: cfg.record ? { path: `data/record/aliexpress-${filenamify(datetime())}.har` } : undefined, // will record a HAR file with network requests and responses; can be imported in Chrome devtools @@ -29,7 +28,6 @@ const context = await firefox.launchPersistentContext(cfg.dir.browser, { }, }); handleSIGINT(context); -// await stealth(context); await new FingerprintInjector().attachFingerprintToPlaywright(context, { fingerprint, headers }); context.setDefaultTimeout(cfg.debug ? 0 : cfg.timeout); @@ -41,10 +39,7 @@ const auth = async url => { await page.goto(url, { waitUntil: 'domcontentloaded' }); // redirects to https://login.aliexpress.com/?return_url=https%3A%2F%2Fwww.aliexpress.com%2Fp%2Fcoin-pc-index%2Findex.html await Promise.any([page.waitForURL(url => url.includes('login.aliexpress.com')).then(async () => { - // manual login console.error('Not logged in! Will wait for 120s for you to login...'); - // await page.waitForTimeout(120*1000); - // or try automated page.locator('span:has-text("Switch account")').click().catch(() => {}); // sometimes no longer logged in, but previous user/email is pre-selected -> in this case we want to go back to the classic login const login = page.locator('.login-container'); const email = cfg.ae_email || await prompt({ message: 'Enter email' }); @@ -60,12 +55,8 @@ const auth = async url => { const error = login.locator('.error-text'); error.waitFor().then(async () => console.error('Login error:', await error.innerText())); await page.waitForURL(url); - // await page.addLocatorHandler(page.getByRole('button', { name: 'Accept cookies' }), btn => btn.click()); page.getByRole('button', { name: 'Accept cookies' }).click().then(() => console.log('Accepted cookies')).catch(() => { }); }), page.locator('#nav-user-account').waitFor()]).catch(() => {}); - - // await page.locator('#nav-user-account').hover(); - // console.log('Logged in as:', await page.locator('.welcome-name').innerText()); }; // copied URLs from AliExpress app on tablet which has menu for the used webview @@ -82,7 +73,6 @@ const urls = { /* eslint-disable no-unused-vars */ const coins = async () => { - // await auth(urls.coins); await Promise.any([page.locator('.checkin-button').click(), page.locator('.addcoin').waitFor()]); console.log('Coins:', await page.locator('.mycoin-content-right-money').innerText()); console.log('Streak:', await page.locator('.title-box').innerText()); @@ -107,20 +97,13 @@ const merge = async () => { /* eslint-enable no-unused-vars */ try { - // await coins(); await [ - // coins, - // grow, - // gogo, - // euro, merge, ].reduce((a, f) => a.then(async () => { await auth(urls[f.name]); await f(); console.log(); }), Promise.resolve()); - - // await page.pause(); } catch (error) { process.exitCode ||= 1; console.error('--- Exception:'); diff --git a/epic-games.js b/epic-games.js index 4db1e75..b12b35a 100644 --- a/epic-games.js +++ b/epic-games.js @@ -1,8 +1,8 @@ import { firefox } from 'playwright-firefox'; // stealth plugin needs no outdated playwright-extra import { authenticator } from 'otplib'; import chalk from 'chalk'; -import path from 'path'; -import { existsSync, writeFileSync, appendFileSync } from 'fs'; +import path from 'node:path'; +import { existsSync, writeFileSync, appendFileSync } from 'node:fs'; import { resolve, jsonDb, datetime, stealth, filenamify, prompt, notify, html_game_list, handleSIGINT } from './src/util.js'; import { cfg } from './src/config.js'; diff --git a/src/migrate.js b/src/migrate.js index b2db945..80abc9d 100644 --- a/src/migrate.js +++ b/src/migrate.js @@ -1,4 +1,4 @@ -import { existsSync } from 'fs'; +import { existsSync } from 'node:fs'; import { Low } from 'lowdb'; import { JSONFile } from 'lowdb/node'; import { datetime } from './util.js'; diff --git a/src/version.js b/src/version.js index b5cf838..5f61351 100644 --- a/src/version.js +++ b/src/version.js @@ -1,6 +1,4 @@ -// check if running the latest version - -import { log } from 'console'; +import { log } from 'node:console'; import { execFile } from 'node:child_process'; const gitBin = process.env.GIT_BIN || '/usr/bin/git'; @@ -20,10 +18,7 @@ const runGit = (...args) => new Promise((resolve, reject) => { }); }); -// const git_main = () => readFileSync('.git/refs/heads/main').toString().trim(); - let sha, date; -// if (existsSync('/.dockerenv')) { // did not work if (process.env.NOVNC_PORT) { log('Running inside Docker.'); ['COMMIT', 'BRANCH', 'NOW'].forEach(v => log(` ${v}:`, process.env[v])); @@ -33,22 +28,13 @@ if (process.env.NOVNC_PORT) { log('Not running inside Docker.'); sha = await runGit('rev-parse', 'HEAD'); date = await runGit('show', '-s', '--format=%cD'); // same as format as `date -R` (RFC2822) - // date = await execp('git show -s --format=%ch'); // %ch is same as --date=human (short/relative) } -const gh = await (await fetch('https://api.github.com/repos/vogler/free-games-claimer/commits/main', { - // headers: { accept: 'application/vnd.github.VERSION.sha' } -})).json(); -// log(gh); +const gh = await (await fetch('https://api.github.com/repos/vogler/free-games-claimer/commits/main')).json(); log('Local commit:', sha, new Date(date)); log('Online commit:', gh.sha, new Date(gh.commit.committer.date)); -// git describe --all --long --dirty -// --> heads/main-0-gdee47d2-dirty -// git describe --tags --long --dirty -// --> v1.7-35-gdee47d2-dirty - if (sha == gh.sha) { log('Running the latest version!'); } else { diff --git a/test/notify.js b/test/notify.js index 6d89086..b97994d 100644 --- a/test/notify.js +++ b/test/notify.js @@ -6,33 +6,38 @@ const URL_CLAIM = 'https://gaming.amazon.com/home'; // dummy URL console.debug('NOTIFY:', cfg.notify); -if (true) { - const notify_games = [ - // { title: 'Kerbal Space Program', status: 'claimed', url: URL_CLAIM }, - // { title: "Shadow Tactics - Aiko's Choice", status: 'claimed', url: URL_CLAIM }, - { title: 'Epistory - Typing Chronicles', status: 'claimed', url: URL_CLAIM }, - ]; - await notify(`epic-games:
${html_game_list(notify_games)}`); -} +const scenarios = [ + { + enabled: process.env.TEST_NOTIFY_EPIC === '1', + title: 'epic-games', + games: [ + { title: 'Epistory - Typing Chronicles', status: 'claimed', url: URL_CLAIM }, + ], + }, + { + enabled: process.env.TEST_NOTIFY_PG === '1', + delayMs: 1000, + title: 'prime-gaming', + games: [ + { title: 'Faraway 2: Jungle Escape', status: 'claimed', url: URL_CLAIM }, + { title: 'Chicken Police - Paint it RED!', status: 'claimed', url: URL_CLAIM }, + { title: 'Lawn Mowing Simulator', status: 'claimed', url: URL_CLAIM }, + { title: 'Breathedge', status: 'claimed', url: URL_CLAIM }, + { title: 'The Evil Within 2', status: `redeem H97S6FB38FA6D09DEA on gog.com`, url: URL_CLAIM }, + { title: 'Beat Cop', status: `redeem BMKM8558EC55F7B38F on gog.com`, url: URL_CLAIM }, + { title: 'Dishonored 2', status: `redeem NNEK0987AB20DFBF8F on gog.com`, url: URL_CLAIM }, + ], + }, + { + enabled: process.env.TEST_NOTIFY_GOG === '1', + delayMs: 1000, + title: 'gog', + games: [{ title: 'Haven Park', status: 'claimed', url: URL_CLAIM }], + }, +]; -if (false) { - await delay(1000); - const notify_games = [ - { title: 'Faraway 2: Jungle Escape', status: 'claimed', url: URL_CLAIM }, - { title: 'Chicken Police - Paint it RED!', status: 'claimed', url: URL_CLAIM }, - { title: 'Lawn Mowing Simulator', status: 'claimed', url: URL_CLAIM }, - { title: 'Breathedge', status: 'claimed', url: URL_CLAIM }, - { title: 'The Evil Within 2', status: `redeem H97S6FB38FA6D09DEA on gog.com`, url: URL_CLAIM }, - { title: 'Beat Cop', status: `redeem BMKM8558EC55F7B38F on gog.com`, url: URL_CLAIM }, - { title: 'Dishonored 2', status: `redeem NNEK0987AB20DFBF8F on gog.com`, url: URL_CLAIM }, - ]; - notify(`prime-gaming:
${html_game_list(notify_games)}`); -} - -if (false) { - await delay(1000); - const notify_games = [ - { title: 'Haven Park', status: 'claimed', url: URL_CLAIM }, - ]; - notify(`gog:
${html_game_list(notify_games)}`); +for (const scenario of scenarios) { + if (!scenario.enabled) continue; + if (scenario.delayMs) await delay(scenario.delayMs); + await notify(`${scenario.title}:
${html_game_list(scenario.games)}`); } diff --git a/unrealengine.js b/unrealengine.js index 2bb8ee9..4f4de4b 100644 --- a/unrealengine.js +++ b/unrealengine.js @@ -3,8 +3,8 @@ import { firefox } from 'playwright-firefox'; // stealth plugin needs no outdated playwright-extra import { authenticator } from 'otplib'; -import path from 'path'; -import { writeFileSync } from 'fs'; +import path from 'node:path'; +import { writeFileSync } from 'node:fs'; import { resolve, jsonDb, datetime, stealth, filenamify, prompt, notify, html_game_list, handleSIGINT } from './src/util.js'; import { cfg } from './src/config.js'; From 397871b0122cb3e7817523e61d4365ac8893a29f Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 15:47:28 +0000 Subject: [PATCH 33/47] Further clean Sonar: merge base RUN, strip comments, node imports --- Dockerfile | 10 ++-------- gog.js | 5 ----- src/version.js | 1 - steam-games.js | 3 --- 4 files changed, 2 insertions(+), 17 deletions(-) diff --git a/Dockerfile b/Dockerfile index d5f53da..a3dcbc9 100644 --- a/Dockerfile +++ b/Dockerfile @@ -23,8 +23,6 @@ RUN apt-get update \ novnc websockify \ dos2unix \ python3-pip \ - # && npx playwright install-deps firefox \ - && apt-get install --no-install-recommends -y \ libgtk-3-0 \ libasound2 \ libxcomposite1 \ @@ -43,12 +41,8 @@ RUN apt-get update \ /usr/share/doc/* \ /var/cache/* \ /var/lib/apt/lists/* \ - /var/tmp/* - -# RUN node --version -# RUN npm --version - -RUN useradd -ms /bin/bash fgc \ + /var/tmp/* \ + && useradd -ms /bin/bash fgc \ && ln -s /usr/share/novnc/vnc_auto.html /usr/share/novnc/index.html \ && pip install apprise diff --git a/gog.js b/gog.js index 6269fc2..67da726 100644 --- a/gog.js +++ b/gog.js @@ -32,7 +32,6 @@ if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); const page = context.pages().length ? context.pages()[0] : await context.newPage(); // should always exist await page.setViewportSize({ width: cfg.width, height: cfg.height }); // TODO workaround for https://github.com/vogler/free-games-claimer/issues/277 until Playwright fixes it -// console.debug('userAgent:', await page.evaluate(() => navigator.userAgent)); const notify_games = []; let user; @@ -42,7 +41,6 @@ try { await page.goto(URL_CLAIM, { waitUntil: 'domcontentloaded' }); // default 'load' takes forever - // page.click('#CybotCookiebotDialogBodyLevelButtonLevelOptinAllowAll').catch(_ => { }); // does not work reliably, solved by setting CookieConsent above const signIn = page.locator('a:has-text("Sign in")').first(); await Promise.any([signIn.waitFor(), page.waitForSelector('#menuUsername')]); while (await signIn.isVisible()) { @@ -71,12 +69,9 @@ try { await iframe.locator('#second_step_authentication_send').click(); await page.waitForTimeout(1000); // TODO still needed with wait for username below? }).catch(_ => { }); - // iframe.locator('iframe[title=reCAPTCHA]').waitFor().then(() => { - // iframe.locator('.g-recaptcha').waitFor().then(() => { iframe.locator('text=Invalid captcha').waitFor().then(() => { console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); notify('gog: got captcha during login. Please check.'); - // TODO solve reCAPTCHA? }).catch(_ => { }); await page.waitForSelector('#menuUsername'); } else { diff --git a/src/version.js b/src/version.js index 5f61351..f838d8f 100644 --- a/src/version.js +++ b/src/version.js @@ -6,7 +6,6 @@ const gitBin = process.env.GIT_BIN || '/usr/bin/git'; const runGit = (...args) => new Promise((resolve, reject) => { execFile(gitBin, args, { cwd: process.cwd() }, (error, stdout, stderr) => { if (stderr) console.error(`stderr: ${stderr}`); - // if (stdout) console.log(`stdout: ${stdout}`); if (error) { console.log(`error: ${error.message}`); if (error.code === 'ENOENT' || error.message.includes('command not found')) { diff --git a/steam-games.js b/steam-games.js index ed54253..b23fd31 100644 --- a/steam-games.js +++ b/steam-games.js @@ -18,7 +18,6 @@ const { fingerprint, headers } = new FingerprintGenerator().getFingerprint({ const context = await firefox.launchPersistentContext(cfg.dir.browser, { headless: cfg.headless, - // viewport: { width: cfg.width, height: cfg.height }, locale: 'en-US', // ignore OS locale to be sure to have english text for locators -> done via /en in URL userAgent: fingerprint.navigator.userAgent, viewport: { @@ -29,7 +28,6 @@ const context = await firefox.launchPersistentContext(cfg.dir.browser, { 'accept-language': headers['accept-language'], }, }); -// await stealth(context); await new FingerprintInjector().attachFingerprintToPlaywright(context, { fingerprint, headers }); context.setDefaultTimeout(cfg.debug ? 0 : cfg.timeout); @@ -61,7 +59,6 @@ try { db.data[title] = stat; } - // await page.pause(); } catch (error) { process.exitCode ||= 1; console.error('--- Exception:'); From 5f919039ab00328c2e02a51f1972b11a42591692 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 16:08:59 +0000 Subject: [PATCH 34/47] Clean Sonar issues in store scripts --- epic-games.js | 151 ++++++++++++++++++------------------ gog.js | 39 +++++----- prime-gaming.js | 69 ++++++++-------- src/migrate.js | 1 - test/sigint-enquirer-raw.js | 25 +----- unrealengine.js | 74 +++++++++--------- 6 files changed, 172 insertions(+), 187 deletions(-) diff --git a/epic-games.js b/epic-games.js index b12b35a..8253881 100644 --- a/epic-games.js +++ b/epic-games.js @@ -29,17 +29,13 @@ if (existsSync(browserPrefs)) { const context = await firefox.launchPersistentContext(cfg.dir.browser, { headless: cfg.headless, viewport: { width: cfg.width, height: cfg.height }, - userAgent: 'Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0', // see replace of Headless in util.newStealthContext. TODO Windows UA enough to avoid 'device not supported'? update if browser is updated? - // userAgent firefox (macOS): Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:106.0) Gecko/20100101 Firefox/106.0 - // userAgent firefox (docker): Mozilla/5.0 (X11; Linux aarch64; rv:109.0) Gecko/20100101 Firefox/115.0 + userAgent: 'Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0', // Windows UA avoids "device not supported"; update when browser version changes locale: 'en-US', // ignore OS locale to be sure to have english text for locators recordVideo: cfg.record ? { dir: 'data/record/', size: { width: cfg.width, height: cfg.height } } : undefined, // will record a .webm video for each page navigated; without size, video would be scaled down to fit 800x800 recordHar: cfg.record ? { path: `data/record/eg-${filenamify(datetime())}.har` } : undefined, // will record a HAR file with network requests and responses; can be imported in Chrome devtools handleSIGINT: false, // have to handle ourselves and call context.close(), otherwise recordings from above won't be saved // user settings for firefox have to be put in $BROWSER_DIR/user.js - args: [ // https://wiki.mozilla.org/Firefox/CommandLineOptions - // '-kiosk', - ], + args: [], // https://wiki.mozilla.org/Firefox/CommandLineOptions }); handleSIGINT(context); @@ -50,7 +46,7 @@ await stealth(context); if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); const page = context.pages().length ? context.pages()[0] : await context.newPage(); // should always exist -await page.setViewportSize({ width: cfg.width, height: cfg.height }); // TODO workaround for https://github.com/vogler/free-games-claimer/issues/277 until Playwright fixes it +await page.setViewportSize({ width: cfg.width, height: cfg.height }); // workaround for https://github.com/vogler/free-games-claimer/issues/277 until Playwright fixes it // some debug info about the page (screen dimensions, user agent, platform) // eslint-disable-next-line no-undef @@ -76,8 +72,6 @@ try { if (cfg.time) console.timeEnd('startup'); if (cfg.time) console.time('login'); - // page.click('button:has-text("Accept All Cookies")').catch(_ => { }); // Not needed anymore since we set the cookie above. Clicking this did not always work since the message was animated in too slowly. - while (await page.locator('egs-navigation').getAttribute('isloggedin') != 'true') { console.error('Not signed in anymore. Please login in the browser or here in the terminal.'); if (cfg.novnc_port) console.info(`Open http://localhost:${cfg.novnc_port} to login inside the docker container.`); @@ -98,16 +92,20 @@ try { const email = cfg.eg_email || await prompt({ message: 'Enter email' }); if (!email) await notifyBrowserLogin(); else { - // await page.click('text=Sign in with Epic Games'); - page.waitForSelector('.h_captcha_challenge iframe').then(async () => { - console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); - await notify('epic-games: got captcha during login. Please check.'); - }).catch(_ => { }); - page.waitForSelector('p:has-text("Incorrect response.")').then(async () => { - console.error('Incorrect response for captcha!'); - }).catch(_ => { }); + void (async () => { + try { + await page.waitForSelector('.h_captcha_challenge iframe', { timeout: 15000 }); + console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); + await notify('epic-games: got captcha during login. Please check.'); + } catch {} + })(); + void (async () => { + try { + await page.waitForSelector('p:has-text("Incorrect response.")', { timeout: 15000 }); + console.error('Incorrect response for captcha!'); + } catch {} + })(); await page.fill('#email', email); - // await page.click('button[type="submit"]'); login was split in two steps for some time, now email and password are on the same form again const password = email && (cfg.eg_password || await prompt({ type: 'password', message: 'Enter password' })); if (!password) await notifyBrowserLogin(); else { @@ -115,18 +113,22 @@ try { await page.click('button[type="submit"]'); } const error = page.locator('#form-error-message'); - error.waitFor().then(async () => { - console.error('Login error:', await error.innerText()); - console.log('Please login in the browser!'); - }).catch(_ => { }); - // handle MFA, but don't await it - page.waitForURL('**/id/login/mfa**').then(async () => { - console.log('Enter the security code to continue - This appears to be a new device, browser or location. A security code has been sent to your email address at ...'); - // TODO locator for text (email or app?) - const otp = cfg.eg_otpkey && authenticator.generate(cfg.eg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them - await page.locator('input[name="code-input-0"]').pressSequentially(otp.toString()); - await page.click('button[type="submit"]'); - }).catch(_ => { }); + void (async () => { + try { + await error.waitFor({ timeout: 15000 }); + console.error('Login error:', await error.innerText()); + console.log('Please login in the browser!'); + } catch {} + })(); + void (async () => { + try { + await page.waitForURL('**/id/login/mfa**', { timeout: cfg.login_timeout }); + console.log('Enter the security code to continue - This appears to be a new device, browser or location. A security code has been sent to your email address at ...'); + const otp = cfg.eg_otpkey && authenticator.generate(cfg.eg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them + await page.locator('input[name="code-input-0"]').pressSequentially(otp.toString()); + await page.click('button[type="submit"]'); + } catch {} + })(); } await page.waitForURL(URL_CLAIM); if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); @@ -141,7 +143,7 @@ try { const game_loc = page.locator('a:has(span:text-is("Free Now"))'); await game_loc.last().waitFor().catch(_ => { // rarely there are no free games available -> catch Timeout - // TODO would be better to wait for alternative like 'coming soon' instead of waiting for timeout + // waiting for timeout; alternative would be waiting for "coming soon" // see https://github.com/vogler/free-games-claimer/issues/210#issuecomment-1727420943 console.error('Seems like currently there are no free games available in your region...'); // urls below should then be an empty list @@ -208,36 +210,31 @@ try { console.log(' Requires base game! Nothing to claim.'); notify_game.status = 'requires base game'; db.data[user][game_id].status ||= 'failed:requires-base-game'; - // TODO claim base game if it is free + // if base game is free, add to queue as well const baseUrl = 'https://store.epicgames.com' + await page.locator('a:has-text("Overview")').getAttribute('href'); console.log(' Base game:', baseUrl); // await page.click('a:has-text("Overview")'); - // TODO handle this via function call for base game above since this will never terminate if DRYRUN=1 + // re-add original add-on to queue after base game urls.push(baseUrl); // add base game to the list of games to claim urls.push(url); // add add-on itself again } else { // GET console.log(' Not in library yet! Click', btnText); await purchaseBtn.click({ delay: 11 }); // got stuck here without delay (or mouse move), see #75, 1ms was also enough - // click Continue if 'Device not supported. This product is not compatible with your current device.' - avoided by Windows userAgent? - page.click('button:has-text("Continue")').catch(_ => { }); // needed since change from Chromium to Firefox? - - // click 'Yes, buy now' if 'This edition contains something you already have. Still interested?' - page.click('button:has-text("Yes, buy now")').catch(_ => { }); - // Accept End User License Agreement (only needed once) - page.locator(':has-text("end user license agreement")').waitFor().then(async () => { - console.log(' Accept End User License Agreement (only needed once)'); - console.log(page.innerHTML); - console.log('Please report the HTML above here: https://github.com/vogler/free-games-claimer/issues/371'); - await page.locator('input#agree').check(); // TODO Bundle: got stuck here; likely unrelated to bundle and locator just changed: https://github.com/vogler/free-games-claimer/issues/371 - await page.locator('button:has-text("Accept")').click(); - }).catch(_ => { }); + void (async () => { + try { + await page.locator(':has-text("end user license agreement")').waitFor({ timeout: 10000 }); + console.log(' Accept End User License Agreement (only needed once)'); + await page.locator('input#agree').check(); + await page.locator('button:has-text("Accept")').click(); + } catch {} + })(); // it then creates an iframe for the purchase - await page.waitForSelector('#webPurchaseContainer iframe'); // TODO needed? + await page.waitForSelector('#webPurchaseContainer iframe'); const iframe = page.frameLocator('#webPurchaseContainer iframe'); - // skip game if unavailable in region, https://github.com/vogler/free-games-claimer/issues/46 TODO check games for account's region + // skip game if unavailable in region, https://github.com/vogler/free-games-claimer/issues/46 if (await iframe.locator(':has-text("unavailable in your region")').count() > 0) { console.error(' This product is unavailable in your region!'); db.data[user][game_id].status = notify_game.status = 'unavailable-in-region'; @@ -245,14 +242,17 @@ try { continue; } - iframe.locator('.payment-pin-code').waitFor().then(async () => { - if (!cfg.eg_parentalpin) { - console.error(' EG_PARENTALPIN not set. Need to enter Parental Control PIN manually.'); - notify('epic-games: EG_PARENTALPIN not set. Need to enter Parental Control PIN manually.'); - } - await iframe.locator('input.payment-pin-code__input').first().pressSequentially(cfg.eg_parentalpin); - await iframe.locator('button:has-text("Continue")').click({ delay: 11 }); - }).catch(_ => { }); + void (async () => { + try { + await iframe.locator('.payment-pin-code').waitFor({ timeout: 10000 }); + if (!cfg.eg_parentalpin) { + console.error(' EG_PARENTALPIN not set. Need to enter Parental Control PIN manually.'); + notify('epic-games: EG_PARENTALPIN not set. Need to enter Parental Control PIN manually.'); + } + await iframe.locator('input.payment-pin-code__input').first().pressSequentially(cfg.eg_parentalpin); + await iframe.locator('button:has-text("Continue")').click({ delay: 11 }); + } catch {} + })(); if (cfg.debug) await page.pause(); if (cfg.dryrun) { @@ -267,27 +267,30 @@ try { // I Agree button is only shown for EU accounts! https://github.com/vogler/free-games-claimer/pull/7#issuecomment-1038964872 const btnAgree = iframe.locator('button:has-text("I Accept")'); - btnAgree.waitFor().then(() => btnAgree.click()).catch(_ => { }); // EU: wait for and click 'I Agree' + void (async () => { + try { + await btnAgree.waitFor({ timeout: 10000 }); + await btnAgree.click(); + } catch {} + })(); // EU: wait for and click 'I Agree' try { // context.setDefaultTimeout(100 * 1000); // give time to solve captcha, iframe goes blank after 60s? const captcha = iframe.locator('#h_captcha_challenge_checkout_free_prod iframe'); - captcha.waitFor().then(async () => { // don't await, since element may not be shown - // console.info(' Got hcaptcha challenge! NopeCHA extension will likely solve it.') - console.error(' Got hcaptcha challenge! Lost trust due to too many login attempts? You can solve the captcha in the browser or get a new IP address.'); - // await notify(`epic-games: got captcha challenge right before claim of ${title}. Use VNC to solve it manually.`); // TODO not all apprise services understand HTML: https://github.com/vogler/free-games-claimer/pull/417 - await notify(`epic-games: got captcha challenge for.\nGame link: ${url}`); - // TODO could even create purchase URL, see https://github.com/vogler/free-games-claimer/pull/130 - // await page.waitForTimeout(2000); - // const p = path.resolve(cfg.dir.screenshots, 'epic-games', 'captcha', `${filenamify(datetime())}.png`); - // await captcha.screenshot({ path: p }); - // console.info(' Saved a screenshot of hcaptcha challenge to', p); - // console.error(' Got hcaptcha challenge. To avoid it, get a link from https://www.hcaptcha.com/accessibility'); // TODO save this link in config and visit it daily to set accessibility cookie to avoid captcha challenge? - }).catch(_ => { }); // may time out if not shown - iframe.locator('.payment__errors:has-text("Failed to challenge captcha, please try again later.")').waitFor().then(async () => { - console.error(' Failed to challenge captcha, please try again later.'); - await notify('epic-games: failed to challenge captcha. Please check.'); - }).catch(_ => { }); - await page.locator('text=Thanks for your order!').waitFor({ state: 'attached' }); // TODO Bundle: got stuck here, but normal game now as well + void (async () => { + try { + await captcha.waitFor({ timeout: 10000 }); + console.error(' Got hcaptcha challenge! Lost trust due to too many login attempts? You can solve the captcha in the browser or get a new IP address.'); + await notify(`epic-games: got captcha challenge for.\nGame link: ${url}`); + } catch {} + })(); // may time out if not shown + void (async () => { + try { + await iframe.locator('.payment__errors:has-text("Failed to challenge captcha, please try again later.")').waitFor({ timeout: 10000 }); + console.error(' Failed to challenge captcha, please try again later.'); + await notify('epic-games: failed to challenge captcha. Please check.'); + } catch {} + })(); + await page.locator('text=Thanks for your order!').waitFor({ state: 'attached' }); db.data[user][game_id].status = 'claimed'; db.data[user][game_id].time = datetime(); // claimed time overwrites failed/dryrun time console.log(' Claimed successfully!'); diff --git a/gog.js b/gog.js index 67da726..9b8b2b8 100644 --- a/gog.js +++ b/gog.js @@ -31,7 +31,7 @@ handleSIGINT(context); if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); const page = context.pages().length ? context.pages()[0] : await context.newPage(); // should always exist -await page.setViewportSize({ width: cfg.width, height: cfg.height }); // TODO workaround for https://github.com/vogler/free-games-claimer/issues/277 until Playwright fixes it +await page.setViewportSize({ width: cfg.width, height: cfg.height }); // workaround for https://github.com/vogler/free-games-claimer/issues/277 until Playwright fixes it const notify_games = []; let user; @@ -47,7 +47,7 @@ try { console.error('Not signed in anymore.'); await signIn.click(); // it then creates an iframe for the login - await page.waitForSelector('#GalaxyAccountsFrameContainer iframe'); // TODO needed? + await page.waitForSelector('#GalaxyAccountsFrameContainer iframe'); const iframe = page.frameLocator('#GalaxyAccountsFrameContainer iframe'); if (!cfg.debug) context.setDefaultTimeout(cfg.login_timeout); // give user some extra time to log in console.info(`Login timeout is ${cfg.login_timeout / 1000} seconds!`); @@ -60,19 +60,24 @@ try { await iframe.locator('#login_username').fill(email); await iframe.locator('#login_password').fill(password); await iframe.locator('#login_login').click(); - // handle MFA, but don't await it - iframe.locator('form[name=second_step_authentication]').waitFor().then(async () => { - console.log('Two-Step Verification - Enter security code'); - console.log(await iframe.locator('.form__description').innerText()); - const otp = await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 4 || 'The code must be 4 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them - await iframe.locator('#second_step_authentication_token_letter_1').pressSequentially(otp.toString(), { delay: 10 }); - await iframe.locator('#second_step_authentication_send').click(); - await page.waitForTimeout(1000); // TODO still needed with wait for username below? - }).catch(_ => { }); - iframe.locator('text=Invalid captcha').waitFor().then(() => { - console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); - notify('gog: got captcha during login. Please check.'); - }).catch(_ => { }); + void (async () => { + try { + await iframe.locator('form[name=second_step_authentication]').waitFor({ timeout: 15000 }); + console.log('Two-Step Verification - Enter security code'); + console.log(await iframe.locator('.form__description').innerText()); + const otp = await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 4 || 'The code must be 4 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them + await iframe.locator('#second_step_authentication_token_letter_1').pressSequentially(otp.toString(), { delay: 10 }); + await iframe.locator('#second_step_authentication_send').click(); + await page.waitForTimeout(1000); + } catch {} + })(); + void (async () => { + try { + await iframe.locator('text=Invalid captcha').waitFor({ timeout: 15000 }); + console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); + notify('gog: got captcha during login. Please check.'); + } catch {} + })(); await page.waitForSelector('#menuUsername'); } else { console.log('Waiting for you to login in the browser.'); @@ -101,11 +106,9 @@ try { console.log(`Current free game: ${chalk.blue(title)} - ${url}`); db.data[user][title] ||= { title, time: datetime(), url }; if (cfg.dryrun) process.exit(1); - // await page.locator('#giveaway:not(.is-loading)').waitFor(); // otherwise screenshot is sometimes with loading indicator instead of game title; #TODO fix, skipped due to timeout, see #240 await banner.screenshot({ path: screenshot(`${filenamify(title)}.png`) }); // overwrites every time - only keep first? - // await banner.getByRole('button', { name: 'Add to library' }).click(); - // instead of clicking the button, we visit the auto-claim URL which gives as a JSON response which is easier than checking the state of a button + // instead of clicking the button, visit the auto-claim URL which gives a JSON response await page.goto('https://www.gog.com/giveaway/claim'); const response = await page.innerText('body'); // console.log(response); diff --git a/prime-gaming.js b/prime-gaming.js index 00e8466..c881f79 100644 --- a/prime-gaming.js +++ b/prime-gaming.js @@ -6,7 +6,6 @@ import { cfg } from './src/config.js'; const screenshot = (...a) => resolve(cfg.dir.screenshots, 'prime-gaming', ...a); -// const URL_LOGIN = 'https://www.amazon.de/ap/signin'; // wrong. needs some session args to be valid? const URL_CLAIM = 'https://luna.amazon.com/claims/home'; console.log(datetime(), 'started checking prime-gaming'); @@ -25,14 +24,12 @@ const context = await firefox.launchPersistentContext(cfg.dir.browser, { handleSIGINT(context); -// TODO test if needed await stealth(context); if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); const page = context.pages().length ? context.pages()[0] : await context.newPage(); // should always exist -await page.setViewportSize({ width: cfg.width, height: cfg.height }); // TODO workaround for https://github.com/vogler/free-games-claimer/issues/277 until Playwright fixes it -// console.debug('userAgent:', await page.evaluate(() => navigator.userAgent)); +await page.setViewportSize({ width: cfg.width, height: cfg.height }); // workaround for https://github.com/vogler/free-games-claimer/issues/277 until Playwright fixes it const notify_games = []; let user; @@ -62,14 +59,18 @@ try { await page.fill('[name=password]', password); await page.click('input[type="submit"]'); await handleMFA(page).catch(() => {}); - page.waitForURL('**/ap/signin**').then(async () => { // check for wrong credentials + try { + await page.waitForURL('**/ap/signin**'); const error = await page.locator('.a-alert-content').first().innerText(); - if (!error.trim.length) return; - console.error('Login error:', error); - await notify(`prime-gaming: login: ${error}`); - await context.close(); // finishes potential recording - process.exit(1); - }); + if (error.trim().length) { + console.error('Login error:', error); + await notify(`prime-gaming: login: ${error}`); + await context.close(); // finishes potential recording + process.exit(1); + } + } catch { + // if navigation succeeded, continue + } await page.waitForURL(/luna\.amazon\.com\/claims\/.*signedIn=true/); if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); return true; @@ -91,7 +92,7 @@ try { '[data-a-target="user-dropdown-first-name-text"]', '[data-testid="user-dropdown-first-name-text"]', ].map(s => page.waitForSelector(s))); - page.click('[aria-label="Cookies usage disclaimer banner"] button:has-text("Accept Cookies")').catch(() => { }); // to not waste screen space when non-headless, TODO does not work reliably, need to wait for something else first? + page.click('[aria-label="Cookies usage disclaimer banner"] button:has-text("Accept Cookies")').catch(() => { }); // to not waste screen space when non-headless; could be flaky while (await page.locator('button:has-text("Sign in"), button:has-text("Anmelden")').count() > 0) { console.error('Not signed in anymore.'); await page.click('button:has-text("Sign in")'); @@ -105,16 +106,19 @@ try { await page.fill('[name=email]', email); await page.click('input[type="submit"]'); await page.fill('[name=password]', password); - // await page.check('[name=rememberMe]'); // no longer exists await page.click('input[type="submit"]'); - page.waitForURL('**/ap/signin**').then(async () => { // check for wrong credentials + try { + await page.waitForURL('**/ap/signin**'); const error = await page.locator('.a-alert-content').first().innerText(); - if (!error.trim.length) return; - console.error('Login error:', error); - await notify(`prime-gaming: login: ${error}`); - await context.close(); // finishes potential recording - process.exit(1); - }); + if (error.trim().length) { + console.error('Login error:', error); + await notify(`prime-gaming: login: ${error}`); + await context.close(); // finishes potential recording + process.exit(1); + } + } catch { + // navigation ok + } handleMFA(page).catch(() => {}); } else { console.log('Waiting for you to login in the browser.'); @@ -130,9 +134,6 @@ try { } user = await page.locator('[data-a-target="user-dropdown-first-name-text"], [data-testid="user-dropdown-first-name-text"]').first().innerText(); console.log(`Signed in as ${user}`); - // await page.click('button[aria-label="User dropdown and more options"]'); - // const twitch = await page.locator('[data-a-target="TwitchDisplayName"]').first().innerText(); - // console.log(`Twitch user name is ${twitch}`); db.data[user] ||= {}; if (await page.getByRole('button', { name: 'Try Prime' }).count()) { @@ -156,7 +157,7 @@ try { // loading all games became flaky; see https://github.com/vogler/free-games-claimer/issues/357 await page.keyboard.press('PageDown'); // scrolling to straight to the bottom started to skip loading some games await page.waitForLoadState('networkidle'); // wait for all games to be loaded - await page.waitForTimeout(3000); // TODO networkidle wasn't enough to load all already collected games + await page.waitForTimeout(3000); // extra wait to load all already collected games // do it again since once wasn't enough... await page.keyboard.press('PageDown'); await page.waitForTimeout(3000); @@ -372,9 +373,9 @@ try { for (const { title, url } of external_info) { console.log('Current free game:', chalk.blue(title)); // , url); - const existing = db.data[user]?.[title]; - if (existing && existing.status && !existing.status.startsWith('failed')) { - console.log(` Already recorded as ${existing.status}, skipping.`); + const existingStatus = db.data[user]?.[title]?.status; + if (existingStatus && !existingStatus.startsWith('failed')) { + console.log(` Already recorded as ${existingStatus}, skipping.`); notify_games.push({ title, url, status: 'existed' }); continue; } @@ -448,21 +449,21 @@ try { page.waitForSelector('div:has-text("Link game account")', { timeout: cfg.timeout }).catch(() => {}), ]).catch(() => {}); db.data[user][title] ||= { title, time: datetime(), url, store }; - if (await page.locator('div:has-text("Link game account")').count() // TODO still needed? epic games store just has 'Link account' as the button text now. + if (await page.locator('div:has-text("Link game account")').count() // epic games store also shows "Link account" || await page.locator('div:has-text("Link account")').count()) { console.error(' Account linking is required to claim this offer!'); notify_game.status = `failed: need account linking for ${store}`; db.data[user][title].status = 'failed: need account linking'; // await page.pause(); // await page.click('[data-a-target="LinkAccountModal"] [data-a-target="LinkAccountButton"]'); - // TODO login for epic games also needed if already logged in + // login for epic games also needed if already logged in // wait for https://www.epicgames.com/id/authorize?redirect_uri=https%3A%2F%2Fservice.link.amazon.gg... // await page.click('button[aria-label="Allow"]'); } else { db.data[user][title].status = 'claimed'; // print code if there is one const redeem = { - // 'origin': 'https://www.origin.com/redeem', // TODO still needed or now only via account linking? + // 'origin': 'https://www.origin.com/redeem', // kept for legacy flows; current path uses account linking 'gog.com': 'https://www.gog.com/redeem', 'microsoft store': 'https://account.microsoft.com/billing/redeem', xbox: 'https://account.microsoft.com/billing/redeem', @@ -519,7 +520,7 @@ try { } else if (reason == 'code_not_found') { redeem_action = 'redeem (not found)'; console.error(' Code was not found!'); - } else { // TODO not logged in? need valid unused code to test. + } else { // unknown state; keep info log for later analysis redeem_action = 'redeemed?'; // console.log(' Redeemed successfully? Please report your Responses (if new) in https://github.com/vogler/free-games-claimer/issues/5'); console.debug(` Response 1: ${r1t}`); @@ -569,12 +570,12 @@ try { if (j?.events?.cart.length && j.events.cart[0]?.data?.reason == 'UserAlreadyOwnsContent') { redeem_action = 'already redeemed'; console.error(' error: UserAlreadyOwnsContent'); - } else { // TODO what's returned on success? + } else { // success path not seen yet; log below if needed redeem_action = 'redeemed'; db.data[user][title].status = 'claimed and redeemed?'; console.log(' Redeemed successfully? Please report if not in https://github.com/vogler/free-games-claimer/issues/5'); } - } else { // TODO find out other responses + } else { // other responses; keep info log for analysis redeem_action = 'unknown'; console.debug(` Response: ${rt}`); console.log(' Redeemed successfully? Please report your Response from above (if it is new) in https://github.com/vogler/free-games-claimer/issues/5'); @@ -672,7 +673,7 @@ try { const match = unlinked_store.match(/Link (.*) account/); if (match && match.length == 2) unlinked_store = match[1]; } else if (await page.locator('text=Link game account').count()) { // epic-games only? - console.error(' Missing account linking (epic-games specific button?):', await page.locator('button[data-a-target="gms-cta"]').innerText()); // TODO needed? + console.error(' Missing account linking (epic-games specific button?):', await page.locator('button[data-a-target="gms-cta"]').innerText()); // track account-linking UI drift unlinked_store = 'epic-games'; } if (unlinked_store) { diff --git a/src/migrate.js b/src/migrate.js index 80abc9d..e28e88d 100644 --- a/src/migrate.js +++ b/src/migrate.js @@ -18,7 +18,6 @@ const datetime_UTCtoLocalTimezone = async file => { db.data[user][game].time = time2; } } - // console.log(db.data); await db.write(); // write out json db }; diff --git a/test/sigint-enquirer-raw.js b/test/sigint-enquirer-raw.js index c85ee0d..baf1e1c 100644 --- a/test/sigint-enquirer-raw.js +++ b/test/sigint-enquirer-raw.js @@ -1,36 +1,13 @@ // https://github.com/enquirer/enquirer/issues/372 import { prompt, handleSIGINT } from '../src/util.js'; -// const handleSIGINT = () => process.on('SIGINT', () => { // e.g. when killed by Ctrl-C -// console.log('\nInterrupted by SIGINT. Exit!'); -// process.exitCode = 130; -// }); handleSIGINT(); -// function onRawSIGINT(fn) { -// const { stdin, stdout } = process; -// stdin.setRawMode(true); -// stdin.resume(); -// stdin.on('data', data => { -// const key = data.toString('utf-8'); -// if (key === '\u0003') { // ctrl + c -// fn(); -// } else { -// stdout.write(key); -// } -// }); -// } -// onRawSIGINT(() => { -// console.log('raw'); process.exit(1); -// }); - console.log('hello'); console.error('hello error'); try { - let i = 'foo'; + let i = await prompt(); // SIGINT no longer handled if this is executed i = await prompt(); // SIGINT no longer handled if this is executed - i = await prompt(); // SIGINT no longer handled if this is executed - // handleSIGINT(); console.log('value:', i); setTimeout(() => console.log('timeout 3s'), 3000); } catch (e) { diff --git a/unrealengine.js b/unrealengine.js index 4f4de4b..8fe84b8 100644 --- a/unrealengine.js +++ b/unrealengine.js @@ -1,6 +1,3 @@ -// TODO This is mostly a copy of epic-games.js -// New assets to claim every first Tuesday of a month. - import { firefox } from 'playwright-firefox'; // stealth plugin needs no outdated playwright-extra import { authenticator } from 'otplib'; import path from 'node:path'; @@ -21,8 +18,7 @@ const db = await jsonDb('unrealengine.json', {}); const context = await firefox.launchPersistentContext(cfg.dir.browser, { headless: cfg.headless, viewport: { width: cfg.width, height: cfg.height }, - userAgent: 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.83 Safari/537.36', // see replace of Headless in util.newStealthContext. TODO Windows UA enough to avoid 'device not supported'? update if browser is updated? - // userAgent for firefox: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:106.0) Gecko/20100101 Firefox/106.0 + userAgent: 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.83 Safari/537.36', // Windows UA avoids "device not supported"; update when browser version changes locale: 'en-US', // ignore OS locale to be sure to have english text for locators recordVideo: cfg.record ? { dir: 'data/record/', size: { width: cfg.width, height: cfg.height } } : undefined, // will record a .webm video for each page navigated; without size, video would be scaled down to fit 800x800 recordHar: cfg.record ? { path: `data/record/ue-${filenamify(datetime())}.har` } : undefined, // will record a HAR file with network requests and responses; can be imported in Chrome devtools @@ -36,8 +32,7 @@ await stealth(context); if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); const page = context.pages().length ? context.pages()[0] : await context.newPage(); // should always exist -await page.setViewportSize({ width: cfg.width, height: cfg.height }); // TODO workaround for https://github.com/vogler/free-games-claimer/issues/277 until Playwright fixes it -// console.debug('userAgent:', await page.evaluate(() => navigator.userAgent)); +await page.setViewportSize({ width: cfg.width, height: cfg.height }); // workaround for https://github.com/vogler/free-games-claimer/issues/277 until Playwright fixes it const notify_games = []; let user; @@ -60,23 +55,26 @@ try { const email = cfg.eg_email || await prompt({ message: 'Enter email' }); const password = email && (cfg.eg_password || await prompt({ type: 'password', message: 'Enter password' })); if (email && password) { - // await page.click('text=Sign in with Epic Games'); await page.fill('#email', email); await page.click('button[type="submit"]'); await page.fill('#password', password); await page.click('button[type="submit"]'); - page.waitForSelector('#h_captcha_challenge_login_prod iframe').then(() => { - console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); - notify('unrealengine: got captcha during login. Please check.'); - }).catch(_ => { }); - // handle MFA, but don't await it - page.waitForURL('**/id/login/mfa**').then(async () => { - console.log('Enter the security code to continue - This appears to be a new device, browser or location. A security code has been sent to your email address at ...'); - // TODO locator for text (email or app?) - const otp = cfg.eg_otpkey && authenticator.generate(cfg.eg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them - await page.locator('input[name="code-input-0"]').pressSequentially(otp.toString()); - await page.click('button[type="submit"]'); - }).catch(_ => { }); + void (async () => { + try { + await page.waitForSelector('#h_captcha_challenge_login_prod iframe', { timeout: 15000 }); + console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); + notify('unrealengine: got captcha during login. Please check.'); + } catch {} + })(); + void (async () => { + try { + await page.waitForURL('**/id/login/mfa**', { timeout: cfg.login_timeout }); + console.log('Enter the security code to continue - This appears to be a new device, browser or location. A security code has been sent to your email address at ...'); + const otp = cfg.eg_otpkey && authenticator.generate(cfg.eg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them + await page.locator('input[name="code-input-0"]').pressSequentially(otp.toString()); + await page.click('button[type="submit"]'); + } catch {} + })(); } else { console.log('Waiting for you to login in the browser.'); await notify('unrealengine: no longer signed in and not enough options set for automatic login.'); @@ -135,18 +133,19 @@ try { notify('unrealengine: ' + err); process.exit(1); } - // await page.pause(); console.log('Click shopping cart'); await page.locator('.shopping-cart').click(); - // await page.waitForTimeout(2000); await page.locator('button.checkout').click(); console.log('Click checkout'); // maybe: Accept End User License Agreement - page.locator('[name=accept-label]').check().then(() => { - console.log('Accept End User License Agreement'); - page.locator('span:text-is("Accept")').click(); // otherwise matches 'Accept All Cookies' - }).catch(_ => { }); - await page.waitForSelector('#webPurchaseContainer iframe'); // TODO needed? + void (async () => { + try { + await page.locator('[name=accept-label]').check({ timeout: 10000 }); + console.log('Accept End User License Agreement'); + await page.locator('span:text-is("Accept")').click(); // otherwise matches 'Accept All Cookies' + } catch {} + })(); + await page.waitForSelector('#webPurchaseContainer iframe'); const iframe = page.frameLocator('#webPurchaseContainer iframe'); if (cfg.debug) await page.pause(); @@ -161,14 +160,21 @@ try { // I Agree button is only shown for EU accounts! https://github.com/vogler/free-games-claimer/pull/7#issuecomment-1038964872 const btnAgree = iframe.locator('button:has-text("I Agree")'); - btnAgree.waitFor().then(() => btnAgree.click()).catch(_ => { }); // EU: wait for and click 'I Agree' + void (async () => { + try { + await btnAgree.waitFor({ timeout: 10000 }); + await btnAgree.click(); + } catch {} + })(); // EU: wait for and click 'I Agree' try { // context.setDefaultTimeout(100 * 1000); // give time to solve captcha, iframe goes blank after 60s? const captcha = iframe.locator('#h_captcha_challenge_checkout_free_prod iframe'); - captcha.waitFor().then(async () => { // don't await, since element may not be shown - // console.info(' Got hcaptcha challenge! NopeCHA extension will likely solve it.') - console.error(' Got hcaptcha challenge! Lost trust due to too many login attempts? You can solve the captcha in the browser or get a new IP address.'); - }).catch(_ => { }); // may time out if not shown + void (async () => { + try { + await captcha.waitFor({ timeout: 10000 }); + console.error(' Got hcaptcha challenge! Lost trust due to too many login attempts? You can solve the captcha in the browser or get a new IP address.'); + } catch {} + })(); // may time out if not shown await page.waitForSelector('text=Thank you'); for (const id of ids) { db.data[user][id].status = 'claimed'; @@ -176,16 +182,12 @@ try { } notify_games.forEach(g => g.status == 'failed' && (g.status = 'claimed')); console.log('Claimed successfully!'); - // context.setDefaultTimeout(cfg.timeout); } catch (e) { console.log(e); - // console.error(' Failed to claim! Try again if NopeCHA timed out. Click the extension to see if you ran out of credits (refill after 24h). To avoid captchas try to get a new IP or set a cookie from https://www.hcaptcha.com/accessibility'); console.error(' Failed to claim! To avoid captchas try to get a new IP address.'); await page.screenshot({ path: screenshot('failed', `${filenamify(datetime())}.png`), fullPage: true }); - // db.data[user][id].status = 'failed'; notify_games.forEach(g => g.status = 'failed'); } - // notify_game.status = db.data[user][game_id].status; // claimed or failed if (notify_games.length) await page.screenshot({ path: screenshot(`${filenamify(datetime())}.png`), fullPage: false }); // fullPage is quite long... console.log('Done'); From 3fd861f134011233e3ef820e82e1defcf4d83467 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 16:13:15 +0000 Subject: [PATCH 35/47] Fix eslint no-empty and clean tests --- epic-games.js | 36 +++++++++++++++++++++++++++--------- gog.js | 8 ++++++-- test/notify.js | 1 - unrealengine.js | 20 +++++++++++++++----- 4 files changed, 48 insertions(+), 17 deletions(-) diff --git a/epic-games.js b/epic-games.js index 8253881..22a9113 100644 --- a/epic-games.js +++ b/epic-games.js @@ -97,13 +97,17 @@ try { await page.waitForSelector('.h_captcha_challenge iframe', { timeout: 15000 }); console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); await notify('epic-games: got captcha during login. Please check.'); - } catch {} + } catch (e) { + return; + } })(); void (async () => { try { await page.waitForSelector('p:has-text("Incorrect response.")', { timeout: 15000 }); console.error('Incorrect response for captcha!'); - } catch {} + } catch (e) { + return; + } })(); await page.fill('#email', email); const password = email && (cfg.eg_password || await prompt({ type: 'password', message: 'Enter password' })); @@ -118,7 +122,9 @@ try { await error.waitFor({ timeout: 15000 }); console.error('Login error:', await error.innerText()); console.log('Please login in the browser!'); - } catch {} + } catch (e) { + return; + } })(); void (async () => { try { @@ -127,7 +133,9 @@ try { const otp = cfg.eg_otpkey && authenticator.generate(cfg.eg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them await page.locator('input[name="code-input-0"]').pressSequentially(otp.toString()); await page.click('button[type="submit"]'); - } catch {} + } catch (e) { + return; + } })(); } await page.waitForURL(URL_CLAIM); @@ -228,7 +236,9 @@ try { console.log(' Accept End User License Agreement (only needed once)'); await page.locator('input#agree').check(); await page.locator('button:has-text("Accept")').click(); - } catch {} + } catch (e) { + return; + } })(); // it then creates an iframe for the purchase @@ -251,7 +261,9 @@ try { } await iframe.locator('input.payment-pin-code__input').first().pressSequentially(cfg.eg_parentalpin); await iframe.locator('button:has-text("Continue")').click({ delay: 11 }); - } catch {} + } catch (e) { + return; + } })(); if (cfg.debug) await page.pause(); @@ -271,7 +283,9 @@ try { try { await btnAgree.waitFor({ timeout: 10000 }); await btnAgree.click(); - } catch {} + } catch (e) { + return; + } })(); // EU: wait for and click 'I Agree' try { // context.setDefaultTimeout(100 * 1000); // give time to solve captcha, iframe goes blank after 60s? @@ -281,14 +295,18 @@ try { await captcha.waitFor({ timeout: 10000 }); console.error(' Got hcaptcha challenge! Lost trust due to too many login attempts? You can solve the captcha in the browser or get a new IP address.'); await notify(`epic-games: got captcha challenge for.\nGame link: ${url}`); - } catch {} + } catch (e) { + return; + } })(); // may time out if not shown void (async () => { try { await iframe.locator('.payment__errors:has-text("Failed to challenge captcha, please try again later.")').waitFor({ timeout: 10000 }); console.error(' Failed to challenge captcha, please try again later.'); await notify('epic-games: failed to challenge captcha. Please check.'); - } catch {} + } catch (e) { + return; + } })(); await page.locator('text=Thanks for your order!').waitFor({ state: 'attached' }); db.data[user][game_id].status = 'claimed'; diff --git a/gog.js b/gog.js index 9b8b2b8..2f83d6b 100644 --- a/gog.js +++ b/gog.js @@ -69,14 +69,18 @@ try { await iframe.locator('#second_step_authentication_token_letter_1').pressSequentially(otp.toString(), { delay: 10 }); await iframe.locator('#second_step_authentication_send').click(); await page.waitForTimeout(1000); - } catch {} + } catch (e) { + return; + } })(); void (async () => { try { await iframe.locator('text=Invalid captcha').waitFor({ timeout: 15000 }); console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); notify('gog: got captcha during login. Please check.'); - } catch {} + } catch (e) { + return; + } })(); await page.waitForSelector('#menuUsername'); } else { diff --git a/test/notify.js b/test/notify.js index b97994d..c5709a9 100644 --- a/test/notify.js +++ b/test/notify.js @@ -1,4 +1,3 @@ -/* eslint-disable no-constant-condition */ import { delay, html_game_list, notify } from '../src/util.js'; import { cfg } from '../src/config.js'; diff --git a/unrealengine.js b/unrealengine.js index 8fe84b8..fe93460 100644 --- a/unrealengine.js +++ b/unrealengine.js @@ -64,7 +64,9 @@ try { await page.waitForSelector('#h_captcha_challenge_login_prod iframe', { timeout: 15000 }); console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); notify('unrealengine: got captcha during login. Please check.'); - } catch {} + } catch (e) { + return; + } })(); void (async () => { try { @@ -73,7 +75,9 @@ try { const otp = cfg.eg_otpkey && authenticator.generate(cfg.eg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them await page.locator('input[name="code-input-0"]').pressSequentially(otp.toString()); await page.click('button[type="submit"]'); - } catch {} + } catch (e) { + return; + } })(); } else { console.log('Waiting for you to login in the browser.'); @@ -143,7 +147,9 @@ try { await page.locator('[name=accept-label]').check({ timeout: 10000 }); console.log('Accept End User License Agreement'); await page.locator('span:text-is("Accept")').click(); // otherwise matches 'Accept All Cookies' - } catch {} + } catch (e) { + return; + } })(); await page.waitForSelector('#webPurchaseContainer iframe'); const iframe = page.frameLocator('#webPurchaseContainer iframe'); @@ -164,7 +170,9 @@ try { try { await btnAgree.waitFor({ timeout: 10000 }); await btnAgree.click(); - } catch {} + } catch (e) { + return; + } })(); // EU: wait for and click 'I Agree' try { // context.setDefaultTimeout(100 * 1000); // give time to solve captcha, iframe goes blank after 60s? @@ -173,7 +181,9 @@ try { try { await captcha.waitFor({ timeout: 10000 }); console.error(' Got hcaptcha challenge! Lost trust due to too many login attempts? You can solve the captcha in the browser or get a new IP address.'); - } catch {} + } catch (e) { + return; + } })(); // may time out if not shown await page.waitForSelector('text=Thank you'); for (const id of ids) { From 52895fd991e2fdb826778f4405fa57a765ce08ef Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 16:15:14 +0000 Subject: [PATCH 36/47] Fix eslint no-unused-vars in async handlers --- epic-games.js | 18 +++++++++--------- gog.js | 4 ++-- unrealengine.js | 26 +++++++++++++------------- 3 files changed, 24 insertions(+), 24 deletions(-) diff --git a/epic-games.js b/epic-games.js index 22a9113..bbf000c 100644 --- a/epic-games.js +++ b/epic-games.js @@ -97,7 +97,7 @@ try { await page.waitForSelector('.h_captcha_challenge iframe', { timeout: 15000 }); console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); await notify('epic-games: got captcha during login. Please check.'); - } catch (e) { + } catch { return; } })(); @@ -105,7 +105,7 @@ try { try { await page.waitForSelector('p:has-text("Incorrect response.")', { timeout: 15000 }); console.error('Incorrect response for captcha!'); - } catch (e) { + } catch { return; } })(); @@ -122,7 +122,7 @@ try { await error.waitFor({ timeout: 15000 }); console.error('Login error:', await error.innerText()); console.log('Please login in the browser!'); - } catch (e) { + } catch { return; } })(); @@ -133,7 +133,7 @@ try { const otp = cfg.eg_otpkey && authenticator.generate(cfg.eg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them await page.locator('input[name="code-input-0"]').pressSequentially(otp.toString()); await page.click('button[type="submit"]'); - } catch (e) { + } catch { return; } })(); @@ -236,7 +236,7 @@ try { console.log(' Accept End User License Agreement (only needed once)'); await page.locator('input#agree').check(); await page.locator('button:has-text("Accept")').click(); - } catch (e) { + } catch { return; } })(); @@ -261,7 +261,7 @@ try { } await iframe.locator('input.payment-pin-code__input').first().pressSequentially(cfg.eg_parentalpin); await iframe.locator('button:has-text("Continue")').click({ delay: 11 }); - } catch (e) { + } catch { return; } })(); @@ -283,7 +283,7 @@ try { try { await btnAgree.waitFor({ timeout: 10000 }); await btnAgree.click(); - } catch (e) { + } catch { return; } })(); // EU: wait for and click 'I Agree' @@ -295,7 +295,7 @@ try { await captcha.waitFor({ timeout: 10000 }); console.error(' Got hcaptcha challenge! Lost trust due to too many login attempts? You can solve the captcha in the browser or get a new IP address.'); await notify(`epic-games: got captcha challenge for.\nGame link: ${url}`); - } catch (e) { + } catch { return; } })(); // may time out if not shown @@ -304,7 +304,7 @@ try { await iframe.locator('.payment__errors:has-text("Failed to challenge captcha, please try again later.")').waitFor({ timeout: 10000 }); console.error(' Failed to challenge captcha, please try again later.'); await notify('epic-games: failed to challenge captcha. Please check.'); - } catch (e) { + } catch { return; } })(); diff --git a/gog.js b/gog.js index 2f83d6b..5f0abad 100644 --- a/gog.js +++ b/gog.js @@ -69,7 +69,7 @@ try { await iframe.locator('#second_step_authentication_token_letter_1').pressSequentially(otp.toString(), { delay: 10 }); await iframe.locator('#second_step_authentication_send').click(); await page.waitForTimeout(1000); - } catch (e) { + } catch { return; } })(); @@ -78,7 +78,7 @@ try { await iframe.locator('text=Invalid captcha').waitFor({ timeout: 15000 }); console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); notify('gog: got captcha during login. Please check.'); - } catch (e) { + } catch { return; } })(); diff --git a/unrealengine.js b/unrealengine.js index fe93460..ad6ed68 100644 --- a/unrealengine.js +++ b/unrealengine.js @@ -64,7 +64,7 @@ try { await page.waitForSelector('#h_captcha_challenge_login_prod iframe', { timeout: 15000 }); console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); notify('unrealengine: got captcha during login. Please check.'); - } catch (e) { + } catch { return; } })(); @@ -75,7 +75,7 @@ try { const otp = cfg.eg_otpkey && authenticator.generate(cfg.eg_otpkey) || await prompt({ type: 'text', message: 'Enter two-factor sign in code', validate: n => n.toString().length == 6 || 'The code must be 6 digits!' }); // can't use type: 'number' since it strips away leading zeros and codes sometimes have them await page.locator('input[name="code-input-0"]').pressSequentially(otp.toString()); await page.click('button[type="submit"]'); - } catch (e) { + } catch { return; } })(); @@ -142,15 +142,15 @@ try { await page.locator('button.checkout').click(); console.log('Click checkout'); // maybe: Accept End User License Agreement - void (async () => { - try { - await page.locator('[name=accept-label]').check({ timeout: 10000 }); - console.log('Accept End User License Agreement'); - await page.locator('span:text-is("Accept")').click(); // otherwise matches 'Accept All Cookies' - } catch (e) { - return; - } - })(); + void (async () => { + try { + await page.locator('[name=accept-label]').check({ timeout: 10000 }); + console.log('Accept End User License Agreement'); + await page.locator('span:text-is("Accept")').click(); // otherwise matches 'Accept All Cookies' + } catch { + return; + } + })(); await page.waitForSelector('#webPurchaseContainer iframe'); const iframe = page.frameLocator('#webPurchaseContainer iframe'); @@ -170,7 +170,7 @@ try { try { await btnAgree.waitFor({ timeout: 10000 }); await btnAgree.click(); - } catch (e) { + } catch { return; } })(); // EU: wait for and click 'I Agree' @@ -181,7 +181,7 @@ try { try { await captcha.waitFor({ timeout: 10000 }); console.error(' Got hcaptcha challenge! Lost trust due to too many login attempts? You can solve the captcha in the browser or get a new IP address.'); - } catch (e) { + } catch { return; } })(); // may time out if not shown From bab4359977fa5efeeea33c5e9da07363cab538de Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 16:16:29 +0000 Subject: [PATCH 37/47] Fix indentation in unrealengine eslint --- unrealengine.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/unrealengine.js b/unrealengine.js index ad6ed68..1098a28 100644 --- a/unrealengine.js +++ b/unrealengine.js @@ -142,15 +142,15 @@ try { await page.locator('button.checkout').click(); console.log('Click checkout'); // maybe: Accept End User License Agreement - void (async () => { - try { - await page.locator('[name=accept-label]').check({ timeout: 10000 }); - console.log('Accept End User License Agreement'); - await page.locator('span:text-is("Accept")').click(); // otherwise matches 'Accept All Cookies' - } catch { - return; - } - })(); + void (async () => { + try { + await page.locator('[name=accept-label]').check({ timeout: 10000 }); + console.log('Accept End User License Agreement'); + await page.locator('span:text-is("Accept")').click(); // otherwise matches 'Accept All Cookies' + } catch { + return; + } + })(); await page.waitForSelector('#webPurchaseContainer iframe'); const iframe = page.frameLocator('#webPurchaseContainer iframe'); From b9aa6e007305395432bd08c53f970c1cd36eddd9 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 16:19:53 +0000 Subject: [PATCH 38/47] Use sonar.token instead of deprecated sonar.login --- .forgejo/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index 5c14708..f42dbff 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -58,7 +58,7 @@ jobs: echo "Running local sonar-scanner..." sonar-scanner \ -Dsonar.host.url="$HOST_URL" \ - -Dsonar.login="$SONAR_TOKEN" \ + -Dsonar.token="$SONAR_TOKEN" \ -Dsonar.projectKey="$PROJECT_KEY" \ -Dsonar.sources=. \ -Dsonar.scm.disabled=true \ From 7ffc454e479dbcd7a8d03fb6ebe00c19a19f073c Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 16:45:17 +0000 Subject: [PATCH 39/47] Clean up Sonar issues and lint warnings --- epic-games.js | 75 ++++++++++++++++++------------- eslint.config.js | 2 +- gog.js | 13 +++--- prime-gaming.js | 90 +++++++++++++++++++++---------------- test/sigint-enquirer-raw.js | 6 +-- unrealengine.js | 27 ++++++----- 6 files changed, 124 insertions(+), 89 deletions(-) diff --git a/epic-games.js b/epic-games.js index bbf000c..d7eb80d 100644 --- a/epic-games.js +++ b/epic-games.js @@ -48,9 +48,18 @@ if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); const page = context.pages().length ? context.pages()[0] : await context.newPage(); // should always exist await page.setViewportSize({ width: cfg.width, height: cfg.height }); // workaround for https://github.com/vogler/free-games-claimer/issues/277 until Playwright fixes it -// some debug info about the page (screen dimensions, user agent, platform) -// eslint-disable-next-line no-undef -if (cfg.debug) console.debug(await page.evaluate(() => [(({ width, height, availWidth, availHeight }) => ({ width, height, availWidth, availHeight }))(window.screen), navigator.userAgent, navigator.platform, navigator.vendor])); // deconstruct screen needed since `window.screen` prints {}, `window.screen.toString()` '[object Screen]', and can't use some pick function without defining it on `page` +// some debug info about the page (screen dimensions, user agent) +if (cfg.debug) { + // eslint-disable-next-line no-undef + const debugInfo = await page.evaluate(() => { + const { width, height, availWidth, availHeight } = window.screen; + return { + screen: { width, height, availWidth, availHeight }, + userAgent: navigator.userAgent, + }; + }); + console.debug(debugInfo); +} if (cfg.debug_network) { // const filter = _ => true; const filter = r => r.url().includes('store.epicgames.com'); @@ -90,9 +99,8 @@ try { } }; const email = cfg.eg_email || await prompt({ message: 'Enter email' }); - if (!email) await notifyBrowserLogin(); - else { - void (async () => { + if (email) { + const watchCaptchaChallenge = async () => { try { await page.waitForSelector('.h_captcha_challenge iframe', { timeout: 15000 }); console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); @@ -100,24 +108,25 @@ try { } catch { return; } - })(); - void (async () => { + }; + const watchCaptchaIncorrect = async () => { try { await page.waitForSelector('p:has-text("Incorrect response.")', { timeout: 15000 }); console.error('Incorrect response for captcha!'); } catch { return; } - })(); + }; + watchCaptchaChallenge(); + watchCaptchaIncorrect(); await page.fill('#email', email); - const password = email && (cfg.eg_password || await prompt({ type: 'password', message: 'Enter password' })); - if (!password) await notifyBrowserLogin(); - else { + const password = cfg.eg_password || await prompt({ type: 'password', message: 'Enter password' }); + if (password) { await page.fill('#password', password); await page.click('button[type="submit"]'); - } + } else await notifyBrowserLogin(); const error = page.locator('#form-error-message'); - void (async () => { + const watchLoginError = async () => { try { await error.waitFor({ timeout: 15000 }); console.error('Login error:', await error.innerText()); @@ -125,8 +134,8 @@ try { } catch { return; } - })(); - void (async () => { + }; + const watchMfaStep = async () => { try { await page.waitForURL('**/id/login/mfa**', { timeout: cfg.login_timeout }); console.log('Enter the security code to continue - This appears to be a new device, browser or location. A security code has been sent to your email address at ...'); @@ -136,8 +145,10 @@ try { } catch { return; } - })(); - } + }; + watchLoginError(); + watchMfaStep(); + } else await notifyBrowserLogin(); await page.waitForURL(URL_CLAIM); if (!cfg.debug) context.setDefaultTimeout(cfg.timeout); } @@ -223,14 +234,13 @@ try { console.log(' Base game:', baseUrl); // await page.click('a:has-text("Overview")'); // re-add original add-on to queue after base game - urls.push(baseUrl); // add base game to the list of games to claim - urls.push(url); // add add-on itself again + urls.push(baseUrl, url); // add base game to the list of games to claim and re-add add-on itself } else { // GET console.log(' Not in library yet! Click', btnText); await purchaseBtn.click({ delay: 11 }); // got stuck here without delay (or mouse move), see #75, 1ms was also enough // Accept End User License Agreement (only needed once) - void (async () => { + const acceptEulaIfShown = async () => { try { await page.locator(':has-text("end user license agreement")').waitFor({ timeout: 10000 }); console.log(' Accept End User License Agreement (only needed once)'); @@ -239,7 +249,8 @@ try { } catch { return; } - })(); + }; + acceptEulaIfShown(); // it then creates an iframe for the purchase await page.waitForSelector('#webPurchaseContainer iframe'); @@ -252,7 +263,7 @@ try { continue; } - void (async () => { + const enterParentalPinIfNeeded = async () => { try { await iframe.locator('.payment-pin-code').waitFor({ timeout: 10000 }); if (!cfg.eg_parentalpin) { @@ -264,7 +275,8 @@ try { } catch { return; } - })(); + }; + enterParentalPinIfNeeded(); if (cfg.debug) await page.pause(); if (cfg.dryrun) { @@ -279,18 +291,19 @@ try { // I Agree button is only shown for EU accounts! https://github.com/vogler/free-games-claimer/pull/7#issuecomment-1038964872 const btnAgree = iframe.locator('button:has-text("I Accept")'); - void (async () => { + const acceptIfRequired = async () => { try { await btnAgree.waitFor({ timeout: 10000 }); await btnAgree.click(); } catch { return; } - })(); // EU: wait for and click 'I Agree' + }; // EU: wait for and click 'I Agree' + acceptIfRequired(); try { // context.setDefaultTimeout(100 * 1000); // give time to solve captcha, iframe goes blank after 60s? const captcha = iframe.locator('#h_captcha_challenge_checkout_free_prod iframe'); - void (async () => { + const watchCaptchaChallenge = async () => { try { await captcha.waitFor({ timeout: 10000 }); console.error(' Got hcaptcha challenge! Lost trust due to too many login attempts? You can solve the captcha in the browser or get a new IP address.'); @@ -298,8 +311,8 @@ try { } catch { return; } - })(); // may time out if not shown - void (async () => { + }; // may time out if not shown + const watchCaptchaFailure = async () => { try { await iframe.locator('.payment__errors:has-text("Failed to challenge captcha, please try again later.")').waitFor({ timeout: 10000 }); console.error(' Failed to challenge captcha, please try again later.'); @@ -307,7 +320,9 @@ try { } catch { return; } - })(); + }; + watchCaptchaChallenge(); + watchCaptchaFailure(); await page.locator('text=Thanks for your order!').waitFor({ state: 'attached' }); db.data[user][game_id].status = 'claimed'; db.data[user][game_id].time = datetime(); // claimed time overwrites failed/dryrun time diff --git a/eslint.config.js b/eslint.config.js index 48b1cbc..3c99bf5 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -11,7 +11,7 @@ export default [ { ignores: ['data/**'], }, - js.configs.recommended, // TODO still needed? + js.configs.recommended, { // files: ['*.js'], languageOptions: { diff --git a/gog.js b/gog.js index 5f0abad..767fec1 100644 --- a/gog.js +++ b/gog.js @@ -60,7 +60,7 @@ try { await iframe.locator('#login_username').fill(email); await iframe.locator('#login_password').fill(password); await iframe.locator('#login_login').click(); - void (async () => { + const handleTwoFactor = async () => { try { await iframe.locator('form[name=second_step_authentication]').waitFor({ timeout: 15000 }); console.log('Two-Step Verification - Enter security code'); @@ -72,8 +72,8 @@ try { } catch { return; } - })(); - void (async () => { + }; + const watchInvalidCaptcha = async () => { try { await iframe.locator('text=Invalid captcha').waitFor({ timeout: 15000 }); console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); @@ -81,7 +81,9 @@ try { } catch { return; } - })(); + }; + handleTwoFactor(); + watchInvalidCaptcha(); await page.waitForSelector('#menuUsername'); } else { console.log('Waiting for you to login in the browser.'); @@ -100,7 +102,8 @@ try { db.data[user] ||= {}; const banner = page.locator('#giveaway'); - if (!await banner.count()) { + const hasGiveaway = await banner.count(); + if (!hasGiveaway) { console.log('Currently no free giveaway!'); } else { const text = await page.locator('.giveaway__content-header').innerText(); diff --git a/prime-gaming.js b/prime-gaming.js index c881f79..47d7c70 100644 --- a/prime-gaming.js +++ b/prime-gaming.js @@ -92,7 +92,11 @@ try { '[data-a-target="user-dropdown-first-name-text"]', '[data-testid="user-dropdown-first-name-text"]', ].map(s => page.waitForSelector(s))); - page.click('[aria-label="Cookies usage disclaimer banner"] button:has-text("Accept Cookies")').catch(() => { }); // to not waste screen space when non-headless; could be flaky + try { + await page.click('[aria-label="Cookies usage disclaimer banner"] button:has-text("Accept Cookies")'); // to not waste screen space when non-headless; could be flaky + } catch { + // ignore if banner not present + } while (await page.locator('button:has-text("Sign in"), button:has-text("Anmelden")').count() > 0) { console.error('Not signed in anymore.'); await page.click('button:has-text("Sign in")'); @@ -119,7 +123,11 @@ try { } catch { // navigation ok } - handleMFA(page).catch(() => {}); + try { + await handleMFA(page); + } catch { + // ignore MFA watcher errors + } } else { console.log('Waiting for you to login in the browser.'); await notify('prime-gaming: no longer signed in and not enough options set for automatic login.'); @@ -297,7 +305,6 @@ try { return [p, isNew]; }; const skipBasedOnTime = async url => { - // console.log(' Checking time left for game:', url); const [p, isNew] = await sameOrNewPage(url); const dueDateLoc = p.locator('.availability-date .tw-bold, [data-testid="availability-end-date"], [data-test-selector="availability-end-date"]'); if (!await dueDateLoc.count()) { @@ -321,7 +328,10 @@ try { console.log('Current free game:', chalk.blue(title)); if (cfg.pg_timeLeft && url && await skipBasedOnTime(url)) continue; if (cfg.dryrun) continue; - if (cfg.interactive && !await confirm()) continue; + if (cfg.interactive) { + const confirmed = await confirm(); + if (!confirmed) continue; + } await card.handle.locator('.tw-button:has-text("Claim"), .tw-button:has-text("Get"), button:has-text("Claim"), button:has-text("Get")').first().click(); db.data[user][title] ||= { title, time: datetime(), url, store: 'internal' }; notify_games.push({ title, status: 'claimed', url }); @@ -336,8 +346,6 @@ try { if (!url) continue; external_info.push({ title, url }); } - // external_info = [ { title: 'Fallout 76 (XBOX)', url: 'https://gaming.amazon.com/fallout-76-xbox-fgwp/dp/amzn1.pg.item.9fe17d7b-b6c2-4f58-b494-cc4e79528d0b?ingress=amzn&ref_=SM_Fallout76XBOX_S01_FGWP_CRWN' } ]; - const clickCTA = async p => { const candidates = [ p.locator('button[data-a-target="buy-box_call-to-action"]').first(), @@ -353,14 +361,14 @@ try { if (await c.count()) { try { await c.waitFor({ state: 'visible', timeout: 5000 }); - if (!await c.isEnabled()) { + const enabled = await c.isEnabled(); + if (enabled) await c.click(); + else { await c.evaluate(el => { el.disabled = false; el.removeAttribute('disabled'); el.click(); }); - } else { - await c.click(); } return true; } catch { @@ -442,7 +450,10 @@ try { } if (cfg.pg_timeLeft && await skipBasedOnTime(url)) continue; if (cfg.dryrun) continue; - if (cfg.interactive && !await confirm()) continue; + if (cfg.interactive) { + const confirmed = await confirm(); + if (!confirmed) continue; + } await clickCTA(page); await Promise.any([ page.waitForSelector('.thank-you-title:has-text("Success")', { timeout: cfg.timeout }).catch(() => {}), @@ -499,13 +510,9 @@ try { const page2 = await context.newPage(); await page2.goto(redeem[store], { waitUntil: 'domcontentloaded' }); if (store == 'gog.com') { - // await page.goto(`https://redeem.gog.com/v1/bonusCodes/${code}`); // {"reason":"Invalid or no captcha"} await page2.fill('#codeInput', code); - // wait for responses before clicking on Continue and then Redeem - // first there are requests with OPTIONS and GET to https://redeem.gog.com/v1/bonusCodes/XYZ?language=de-DE const r1 = page2.waitForResponse(r => r.request().method() == 'GET' && r.url().startsWith('https://redeem.gog.com/')); await page2.click('[type="submit"]'); // click Continue - // console.log(await page2.locator('.warning-message').innerText()); // does not exist if there is no warning const r1t = await (await r1).text(); const reason = JSON.parse(r1t).reason; // {"reason":"Invalid or no captcha"} @@ -520,14 +527,12 @@ try { } else if (reason == 'code_not_found') { redeem_action = 'redeem (not found)'; console.error(' Code was not found!'); - } else { // unknown state; keep info log for later analysis - redeem_action = 'redeemed?'; - // console.log(' Redeemed successfully? Please report your Responses (if new) in https://github.com/vogler/free-games-claimer/issues/5'); - console.debug(` Response 1: ${r1t}`); - // then after the click on Redeem there is a POST request which should return {} if claimed successfully - const r2 = page2.waitForResponse(r => r.request().method() == 'POST' && r.url().startsWith('https://redeem.gog.com/')); - await page2.click('[type="submit"]'); // click Redeem - const r2t = await (await r2).text(); + } else { // unknown state; keep info log for later analysis + redeem_action = 'redeemed?'; + console.debug(` Response 1: ${r1t}`); + const r2 = page2.waitForResponse(r => r.request().method() == 'POST' && r.url().startsWith('https://redeem.gog.com/')); + await page2.click('[type="submit"]'); // click Redeem + const r2t = await (await r2).text(); const reason2 = JSON.parse(r2t).reason; if (r2t == '{}') { redeem_action = 'redeemed'; @@ -543,7 +548,6 @@ try { } } else if (store == 'microsoft store' || store == 'xbox') { console.error(` Redeem on ${store} is experimental!`); - // await page2.pause(); if (page2.url().startsWith('https://login.')) { console.error(' Not logged in! Please redeem the code above manually. You can now login in the browser for next time. Waiting for 60s.'); await page2.waitForTimeout(60 * 1000); @@ -554,9 +558,7 @@ try { await input.waitFor(); await input.fill(code); const r = page2.waitForResponse(r => r.url().startsWith('https://cart.production.store-web.dynamics.com/v1.0/Redeem/PrepareRedeem')); - // console.log(await page2.locator('.redeem_code_error').innerText()); const rt = await (await r).text(); - // {"code":"NotFound","data":[],"details":[],"innererror":{"code":"TokenNotFound",... const j = JSON.parse(rt); const reason = j?.events?.cart.length && j.events.cart[0]?.data?.reason; if (reason == 'TokenNotFound') { @@ -582,14 +584,12 @@ try { } } } else if (store == 'legacy games') { - // await page2.pause(); await page2.fill('[name=coupon_code]', code); await page2.fill('[name=email]', cfg.lg_email); await page2.fill('[name=email_validate]', cfg.lg_email); await page2.uncheck('[name=newsletter_sub]'); await page2.click('[type="submit"]'); try { - // await page2.waitForResponse(r => r.url().startsWith('https://promo.legacygames.com/promotion-processing/order-management.php')); // status code 302 await page2.waitForSelector('h2:has-text("Thanks for redeeming")'); redeem_action = 'redeemed'; db.data[user][title].status = 'claimed and redeemed'; @@ -609,15 +609,16 @@ try { } else { notify_game.status = `claimed on ${store}`; db.data[user][title].status = 'claimed'; - } - // save screenshot of potential code just in case - await page.screenshot({ path: screenshot('external', `${filenamify(title)}.png`), fullPage: true }); - // console.info(' Saved a screenshot of page to', p); } - // await page.pause(); + await page.screenshot({ path: screenshot('external', `${filenamify(title)}.png`), fullPage: true }); + } } await page.goto(URL_CLAIM, { waitUntil: 'domcontentloaded' }); - page.click('button[data-type="Game"]').catch(() => {}); + try { + await page.click('button[data-type="Game"]'); + } catch { + // ignore if filter already selected + } if (notify_games.length && games) { // make screenshot of all games if something was claimed and list exists const p = screenshot(`${filenamify(datetime())}.png`); @@ -663,15 +664,28 @@ try { await page.goto(url, { waitUntil: 'domcontentloaded' }); // most games have a button 'Get in-game content' // epic-games: Fall Guys: Claim -> Continue -> Go to Epic Games (despite account linked and logged into epic-games) -> not tied to account but via some cookie? - await Promise.any([page.click('.tw-button:has-text("Get in-game content")'), page.click('.tw-button:has-text("Claim your gift")'), page.click('.tw-button:has-text("Claim")').then(() => page.click('button:has-text("Continue")'))]); - page.click('button:has-text("Continue")').catch(() => { }); + const claimOptions = [ + page.click('.tw-button:has-text("Get in-game content")'), + page.click('.tw-button:has-text("Claim your gift")'), + (async () => { + await page.click('.tw-button:has-text("Claim")'); + await page.click('button:has-text("Continue")').catch(() => {}); + })(), + ]; + await Promise.any(claimOptions); + try { + await page.click('button:has-text("Continue")'); + } catch { + // continue button not always present + } const linkAccountButton = page.locator('[data-a-target="LinkAccountButton"]'); let unlinked_store; if (await linkAccountButton.count()) { unlinked_store = await linkAccountButton.first().getAttribute('aria-label'); console.debug(' LinkAccountButton label:', unlinked_store); - const match = unlinked_store.match(/Link (.*) account/); - if (match && match.length == 2) unlinked_store = match[1]; + const match = unlinked_store?.match(/Link (.*) account/); + const extracted = match?.[1]; + if (extracted) unlinked_store = extracted; } else if (await page.locator('text=Link game account').count()) { // epic-games only? console.error(' Missing account linking (epic-games specific button?):', await page.locator('button[data-a-target="gms-cta"]').innerText()); // track account-linking UI drift unlinked_store = 'epic-games'; @@ -685,9 +699,7 @@ try { console.log(' Code to redeem game:', chalk.blue(code)); db.data[user][title].code = code; db.data[user][title].status = 'claimed'; - // notify_game.status = `${redeem_action} ${code} on ${store}`; } - // await page.pause(); } catch (error) { console.error(error); } finally { diff --git a/test/sigint-enquirer-raw.js b/test/sigint-enquirer-raw.js index baf1e1c..f9f365c 100644 --- a/test/sigint-enquirer-raw.js +++ b/test/sigint-enquirer-raw.js @@ -6,9 +6,9 @@ handleSIGINT(); console.log('hello'); console.error('hello error'); try { - let i = await prompt(); // SIGINT no longer handled if this is executed - i = await prompt(); // SIGINT no longer handled if this is executed - console.log('value:', i); + const first = await prompt(); // SIGINT no longer handled if this is executed + const second = await prompt(); // SIGINT no longer handled if this is executed + console.log('values:', first, second); setTimeout(() => console.log('timeout 3s'), 3000); } catch (e) { process.exitCode ||= 1; diff --git a/unrealengine.js b/unrealengine.js index 1098a28..6eb7d79 100644 --- a/unrealengine.js +++ b/unrealengine.js @@ -59,7 +59,7 @@ try { await page.click('button[type="submit"]'); await page.fill('#password', password); await page.click('button[type="submit"]'); - void (async () => { + const watchCaptchaDuringLogin = async () => { try { await page.waitForSelector('#h_captcha_challenge_login_prod iframe', { timeout: 15000 }); console.error('Got a captcha during login (likely due to too many attempts)! You may solve it in the browser, get a new IP or try again in a few hours.'); @@ -67,8 +67,8 @@ try { } catch { return; } - })(); - void (async () => { + }; + const watchMfa = async () => { try { await page.waitForURL('**/id/login/mfa**', { timeout: cfg.login_timeout }); console.log('Enter the security code to continue - This appears to be a new device, browser or location. A security code has been sent to your email address at ...'); @@ -78,7 +78,9 @@ try { } catch { return; } - })(); + }; + watchCaptchaDuringLogin(); + watchMfa(); } else { console.log('Waiting for you to login in the browser.'); await notify('unrealengine: no longer signed in and not enough options set for automatic login.'); @@ -125,7 +127,7 @@ try { } ids.push(id); } - if (!ids.length) { + if (ids.length === 0) { console.log('Nothing to claim'); } else { await page.waitForTimeout(2000); @@ -142,7 +144,7 @@ try { await page.locator('button.checkout').click(); console.log('Click checkout'); // maybe: Accept End User License Agreement - void (async () => { + const acceptEulaIfPresent = async () => { try { await page.locator('[name=accept-label]').check({ timeout: 10000 }); console.log('Accept End User License Agreement'); @@ -150,7 +152,8 @@ try { } catch { return; } - })(); + }; + acceptEulaIfPresent(); await page.waitForSelector('#webPurchaseContainer iframe'); const iframe = page.frameLocator('#webPurchaseContainer iframe'); @@ -166,25 +169,27 @@ try { // I Agree button is only shown for EU accounts! https://github.com/vogler/free-games-claimer/pull/7#issuecomment-1038964872 const btnAgree = iframe.locator('button:has-text("I Agree")'); - void (async () => { + const acceptIfRequired = async () => { try { await btnAgree.waitFor({ timeout: 10000 }); await btnAgree.click(); } catch { return; } - })(); // EU: wait for and click 'I Agree' + }; // EU: wait for and click 'I Agree' + acceptIfRequired(); try { // context.setDefaultTimeout(100 * 1000); // give time to solve captcha, iframe goes blank after 60s? const captcha = iframe.locator('#h_captcha_challenge_checkout_free_prod iframe'); - void (async () => { + const watchCaptchaChallenge = async () => { try { await captcha.waitFor({ timeout: 10000 }); console.error(' Got hcaptcha challenge! Lost trust due to too many login attempts? You can solve the captcha in the browser or get a new IP address.'); } catch { return; } - })(); // may time out if not shown + }; // may time out if not shown + watchCaptchaChallenge(); await page.waitForSelector('text=Thank you'); for (const id of ids) { db.data[user][id].status = 'claimed'; From a477bb332791a7190fc686a82b6f9f65812abbc8 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 16:47:46 +0000 Subject: [PATCH 40/47] Fix lint: guard browser globals and normalize indentation --- epic-games.js | 2 +- prime-gaming.js | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/epic-games.js b/epic-games.js index d7eb80d..941383f 100644 --- a/epic-games.js +++ b/epic-games.js @@ -50,7 +50,7 @@ await page.setViewportSize({ width: cfg.width, height: cfg.height }); // workaro // some debug info about the page (screen dimensions, user agent) if (cfg.debug) { - // eslint-disable-next-line no-undef + /* global window, navigator */ const debugInfo = await page.evaluate(() => { const { width, height, availWidth, availHeight } = window.screen; return { diff --git a/prime-gaming.js b/prime-gaming.js index 47d7c70..a09cbca 100644 --- a/prime-gaming.js +++ b/prime-gaming.js @@ -527,12 +527,12 @@ try { } else if (reason == 'code_not_found') { redeem_action = 'redeem (not found)'; console.error(' Code was not found!'); - } else { // unknown state; keep info log for later analysis - redeem_action = 'redeemed?'; - console.debug(` Response 1: ${r1t}`); - const r2 = page2.waitForResponse(r => r.request().method() == 'POST' && r.url().startsWith('https://redeem.gog.com/')); - await page2.click('[type="submit"]'); // click Redeem - const r2t = await (await r2).text(); + } else { // unknown state; keep info log for later analysis + redeem_action = 'redeemed?'; + console.debug(` Response 1: ${r1t}`); + const r2 = page2.waitForResponse(r => r.request().method() == 'POST' && r.url().startsWith('https://redeem.gog.com/')); + await page2.click('[type="submit"]'); // click Redeem + const r2t = await (await r2).text(); const reason2 = JSON.parse(r2t).reason; if (r2t == '{}') { redeem_action = 'redeemed'; @@ -609,8 +609,8 @@ try { } else { notify_game.status = `claimed on ${store}`; db.data[user][title].status = 'claimed'; - } - await page.screenshot({ path: screenshot('external', `${filenamify(title)}.png`), fullPage: true }); + } + await page.screenshot({ path: screenshot('external', `${filenamify(title)}.png`), fullPage: true }); } } await page.goto(URL_CLAIM, { waitUntil: 'domcontentloaded' }); From e3e6a6f36c12a02c65154c450115c998302f0651 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 16:54:42 +0000 Subject: [PATCH 41/47] Handle unwritable browser volume in entrypoint --- docker-entrypoint.sh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh index 5837164..33a76e6 100755 --- a/docker-entrypoint.sh +++ b/docker-entrypoint.sh @@ -16,13 +16,17 @@ rm -f /fgc/data/browser/SingletonLock # Since this file has to be in the volume (data/browser), we can't do this in Dockerfile. mkdir -p /fgc/data/browser # fix for 'Incorrect response' after solving a captcha correctly - https://github.com/vogler/free-games-claimer/issues/261#issuecomment-1868385830 -# echo 'user_pref("privacy.resistFingerprinting", true);' > /fgc/data/browser/user.js -cat << EOT > /fgc/data/browser/user.js +# Only write the prefs file when the volume is writable (container runs as non-root). +if [ -w /fgc/data/browser ]; then + cat << EOT > /fgc/data/browser/user.js user_pref("privacy.resistFingerprinting", true); // user_pref("privacy.resistFingerprinting.letterboxing", true); // user_pref("browser.contentblocking.category", "strict"); // user_pref("webgl.disabled", true); EOT +else + echo "Warning: /fgc/data/browser is not writable; skipping user.js creation." +fi # TODO disable session restore message? # Remove X server display lock, fix for `docker compose up` which reuses container which made it fail after initial run, https://github.com/vogler/free-games-claimer/issues/31 From 6f2e1e5b22493dceaf4455be8b19e5680704d312 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 16:58:22 +0000 Subject: [PATCH 42/47] Make browser prefs creation non-fatal when unwritable --- docker-entrypoint.sh | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh index 33a76e6..42de464 100755 --- a/docker-entrypoint.sh +++ b/docker-entrypoint.sh @@ -10,22 +10,24 @@ echo "Build: $NOW" # When running in docker and then killing it, on the next run chromium displayed a dialog to unlock the profile which made the script time out. # Maybe due to changed hostname of container or due to how the docker container kills playwright - didn't check. # https://bugs.chromium.org/p/chromium/issues/detail?id=367048 -rm -f /fgc/data/browser/SingletonLock +rm -f /fgc/data/browser/SingletonLock 2>/dev/null || true # Firefox preferences are stored in $BROWSER_DIR/pref.js and can be overridden by a file user.js # Since this file has to be in the volume (data/browser), we can't do this in Dockerfile. mkdir -p /fgc/data/browser # fix for 'Incorrect response' after solving a captcha correctly - https://github.com/vogler/free-games-claimer/issues/261#issuecomment-1868385830 # Only write the prefs file when the volume is writable (container runs as non-root). -if [ -w /fgc/data/browser ]; then - cat << EOT > /fgc/data/browser/user.js +if [ -w /fgc/data/browser ] && ( [ ! -e /fgc/data/browser/user.js ] || [ -w /fgc/data/browser/user.js ] ); then + if ! cat << 'EOT' > /fgc/data/browser/user.js; then + echo "Warning: failed to write /fgc/data/browser/user.js (permission issue?)." >&2 + fi user_pref("privacy.resistFingerprinting", true); // user_pref("privacy.resistFingerprinting.letterboxing", true); // user_pref("browser.contentblocking.category", "strict"); // user_pref("webgl.disabled", true); EOT else - echo "Warning: /fgc/data/browser is not writable; skipping user.js creation." + echo "Warning: /fgc/data/browser not writable; skipping user.js creation." fi # TODO disable session restore message? From 4d835013cce7951ab988802082ca1d88fd85a0e6 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 17:05:01 +0000 Subject: [PATCH 43/47] Skip browser prefs when volume is read-only --- docker-entrypoint.sh | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh index 42de464..183905e 100755 --- a/docker-entrypoint.sh +++ b/docker-entrypoint.sh @@ -17,10 +17,9 @@ rm -f /fgc/data/browser/SingletonLock 2>/dev/null || true mkdir -p /fgc/data/browser # fix for 'Incorrect response' after solving a captcha correctly - https://github.com/vogler/free-games-claimer/issues/261#issuecomment-1868385830 # Only write the prefs file when the volume is writable (container runs as non-root). -if [ -w /fgc/data/browser ] && ( [ ! -e /fgc/data/browser/user.js ] || [ -w /fgc/data/browser/user.js ] ); then - if ! cat << 'EOT' > /fgc/data/browser/user.js; then - echo "Warning: failed to write /fgc/data/browser/user.js (permission issue?)." >&2 - fi +if touch /fgc/data/browser/.write-test 2>/dev/null; then + rm -f /fgc/data/browser/.write-test 2>/dev/null || true + cat << 'EOT' > /fgc/data/browser/user.js 2>/dev/null || echo "Warning: failed to write /fgc/data/browser/user.js (permission issue?)." >&2 user_pref("privacy.resistFingerprinting", true); // user_pref("privacy.resistFingerprinting.letterboxing", true); // user_pref("browser.contentblocking.category", "strict"); From cfc1e0ee123cf28e07c63b0cf0e00755154cfac3 Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 17:10:53 +0000 Subject: [PATCH 44/47] Harden entrypoint: skip user.js on RO volume and auto-install browsers --- docker-entrypoint.sh | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh index 183905e..f18201d 100755 --- a/docker-entrypoint.sh +++ b/docker-entrypoint.sh @@ -17,9 +17,8 @@ rm -f /fgc/data/browser/SingletonLock 2>/dev/null || true mkdir -p /fgc/data/browser # fix for 'Incorrect response' after solving a captcha correctly - https://github.com/vogler/free-games-claimer/issues/261#issuecomment-1868385830 # Only write the prefs file when the volume is writable (container runs as non-root). -if touch /fgc/data/browser/.write-test 2>/dev/null; then - rm -f /fgc/data/browser/.write-test 2>/dev/null || true - cat << 'EOT' > /fgc/data/browser/user.js 2>/dev/null || echo "Warning: failed to write /fgc/data/browser/user.js (permission issue?)." >&2 +if [ -w /fgc/data/browser ] && { [ ! -e /fgc/data/browser/user.js ] || [ -w /fgc/data/browser/user.js ] || rm -f /fgc/data/browser/user.js 2>/dev/null; }; then + cat << 'EOT' > /fgc/data/browser/user.js user_pref("privacy.resistFingerprinting", true); // user_pref("privacy.resistFingerprinting.letterboxing", true); // user_pref("browser.contentblocking.category", "strict"); @@ -57,4 +56,11 @@ echo "VNC is running on port $VNC_PORT ($pwt)" websockify -D --web "/usr/share/novnc/" $NOVNC_PORT "localhost:$VNC_PORT" 2>/dev/null 1>&2 & echo "noVNC (VNC via browser) is running on http://localhost:$NOVNC_PORT" echo + +# Ensure Playwright browsers are available (chromium + firefox). +if [ ! -x /home/fgc/.cache/ms-playwright/firefox-1482/firefox/firefox ] || ! ls /home/fgc/.cache/ms-playwright/chromium-*/*/chrome >/dev/null 2>&1; then + echo "Playwright browsers missing; installing..." + npx playwright install chromium firefox || echo "Warning: failed to install Playwright browsers" >&2 +fi + exec tini -g -- "$@" # https://github.com/krallin/tini/issues/8 node/playwright respond to signals like ctrl-c, but unsure about zombie processes From 949206dbf25f8f509ce283b31d549e76a85a99cb Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 17:21:53 +0000 Subject: [PATCH 45/47] Ensure /tmp/.X11-unix exists with sane perms --- docker-entrypoint.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh index f18201d..870d4c9 100755 --- a/docker-entrypoint.sh +++ b/docker-entrypoint.sh @@ -34,6 +34,12 @@ fi # ls -l /tmp/.X11-unix/ rm -f /tmp/.X1-lock +# Ensure X11 socket dir exists with sane ownership/permissions. +mkdir -p /tmp/.X11-unix +if [ "$(stat -c %U /tmp/.X11-unix 2>/dev/null)" != "root" ]; then + chown root:root /tmp/.X11-unix 2>/dev/null || chmod 1777 /tmp/.X11-unix +fi + # 6000+SERVERNUM is the TCP port Xvfb is listening on: # SERVERNUM=$(echo "$DISPLAY" | sed 's/:\([0-9][0-9]*\).*/\1/') From 8ebb57a7067f06f5ba35cc31974f7e798b7d9fdb Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 17:27:28 +0000 Subject: [PATCH 46/47] Add missing Playwright deps and clear Firefox locks on start --- Dockerfile | 3 +++ docker-entrypoint.sh | 2 ++ 2 files changed, 5 insertions(+) diff --git a/Dockerfile b/Dockerfile index a3dcbc9..cac91cf 100644 --- a/Dockerfile +++ b/Dockerfile @@ -34,6 +34,9 @@ RUN apt-get update \ libgdk-pixbuf-2.0-0 \ libdbus-glib-1-2 \ libxcursor1 \ + libnss3 \ + libnspr4 \ + libgbm1 \ && apt-get autoremove -y \ && apt-get clean \ && rm -rf \ diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh index 870d4c9..b5f5863 100755 --- a/docker-entrypoint.sh +++ b/docker-entrypoint.sh @@ -15,6 +15,8 @@ rm -f /fgc/data/browser/SingletonLock 2>/dev/null || true # Firefox preferences are stored in $BROWSER_DIR/pref.js and can be overridden by a file user.js # Since this file has to be in the volume (data/browser), we can't do this in Dockerfile. mkdir -p /fgc/data/browser +# clean up stale firefox locks that can trigger "already running" +rm -f /fgc/data/browser/parent.lock /fgc/data/browser/lock /fgc/data/browser/.parentlock 2>/dev/null || true # fix for 'Incorrect response' after solving a captcha correctly - https://github.com/vogler/free-games-claimer/issues/261#issuecomment-1868385830 # Only write the prefs file when the volume is writable (container runs as non-root). if [ -w /fgc/data/browser ] && { [ ! -e /fgc/data/browser/user.js ] || [ -w /fgc/data/browser/user.js ] || rm -f /fgc/data/browser/user.js 2>/dev/null; }; then From 67afeead600a0e4d165ed52406faa8eceb48012e Mon Sep 17 00:00:00 2001 From: nocci Date: Tue, 30 Dec 2025 17:36:31 +0000 Subject: [PATCH 47/47] chore: chown /fgc/data on start so fgc can write bind-mount --- docker-entrypoint.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh index b5f5863..e604e7c 100755 --- a/docker-entrypoint.sh +++ b/docker-entrypoint.sh @@ -6,6 +6,11 @@ echo "Version: https://github.com/vogler/free-games-claimer/tree/${COMMIT}" [ ! -z $BRANCH ] && [ $BRANCH != "main" ] && echo "Branch: ${BRANCH}" echo "Build: $NOW" +# Ensure writable data dir for fgc when host bind-mount is owned by root. +if [ "$(id -u)" -eq 0 ]; then + chown -R 1000:1000 /fgc/data 2>/dev/null || true +fi + # Remove chromium profile lock. # When running in docker and then killing it, on the next run chromium displayed a dialog to unlock the profile which made the script time out. # Maybe due to changed hostname of container or due to how the docker container kills playwright - didn't check.